From: Stefan Richter <stefanr@s5r6.in-berlin.de>
To: Mauro Carvalho Chehab <mchehab@redhat.com>
Cc: Linux Media Mailing List <linux-media@vger.kernel.org>,
Hans Verkuil <hverkuil@xs4all.nl>,
Sylwester Nawrocki <snjw23@gmail.com>
Subject: Re: [RFC PATCH 0/3] Improve Kconfig selection for media devices
Date: Mon, 28 May 2012 11:48:03 +0200 [thread overview]
Message-ID: <20120528114803.0d1a4881@stein> (raw)
In-Reply-To: <1338137803-12231-1-git-send-email-mchehab@redhat.com>
On May 27 Mauro Carvalho Chehab wrote:
> The Kconfig building system is improperly selecting some drivers,
> like analog TV tuners even when this is not required.
>
> Rearrange the Kconfig in a way to prevent that.
>
> Mauro Carvalho Chehab (3):
> media: reorganize the main Kconfig items
> media: Remove VIDEO_MEDIA Kconfig option
> media: only show V4L devices based on device type selection
On 1/3 "media: reorganize the main Kconfig items":
a) I agree with Sylvester that the MEDIA_WEBCAM_SUPP variable, prompt
text, and help text should be worded a bit more general. Wouldn't this
variable also cover industrial cameras and who knows what other kinds of
video inputs? I also agree with Sylvester about the SUPP vs. SUPPORT
thing.
b) Small typo in the MEDIA_ANALOG_TV_SUPP help text: of -> or.
c) The RC_CORE_SUPP help text gives the impression that RC core is
always needed if there is hardware with an IR feature. But the firedtv
driver is a case where the driver directly works on top of the input
subsystem rather than on RC core. Maybe there are more such cases.
(Currently we don't ask whether FireDTV owners want IR support; we
silently build the IR part of firedtv in if CONFIG_INPUT is set, and
silently omit the IR part of firedtv if CONFIG_INPUT was disabled, which
requires CONFIG_EXPERT.)
How about turning the "Remote Controller support" option into merely a
filter for standalone IR and RF receivers and transmitters, whereas
Kconfig options in the analog and digital TV categories silently do
"select RC_CORE if INPUT" for combined tuner + IR/RF rx/tx hardware?
--
Stefan Richter
-=====-===-- -=-= ===--
http://arcgraph.de/sr/
next prev parent reply other threads:[~2012-05-28 9:48 UTC|newest]
Thread overview: 36+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-05-24 15:34 [GIT PULL for v3.5-rc1] media updates for v3.5 Mauro Carvalho Chehab
2012-05-24 15:52 ` Antti Palosaari
2012-05-24 16:33 ` Ezequiel Garcia
2012-05-24 16:44 ` Mauro Carvalho Chehab
2012-05-24 20:42 ` Linus Torvalds
2012-05-24 22:33 ` Mauro Carvalho Chehab
2012-05-24 22:40 ` Linus Torvalds
2012-05-25 12:12 ` Mauro Carvalho Chehab
2012-05-25 14:49 ` Anssi Hannula
2012-05-25 15:21 ` Mauro Carvalho Chehab
2012-05-25 16:01 ` Anssi Hannula
2012-05-25 21:20 ` Guennadi Liakhovetski
2012-05-25 22:38 ` Stefan Richter
2012-05-27 14:47 ` Mauro Carvalho Chehab
2012-05-27 15:54 ` Mauro Carvalho Chehab
2012-05-27 16:56 ` [RFC PATCH 0/3] Improve Kconfig selection for media devices Mauro Carvalho Chehab
2012-05-27 16:56 ` [RFC PATCH 1/3] media: reorganize the main Kconfig items Mauro Carvalho Chehab
2012-05-27 17:15 ` Hans Verkuil
2012-05-27 17:20 ` Mauro Carvalho Chehab
2012-05-27 17:27 ` Sylwester Nawrocki
2012-05-27 16:56 ` [RFC PATCH 2/3] media: Remove VIDEO_MEDIA Kconfig option Mauro Carvalho Chehab
2012-05-27 16:56 ` [RFC PATCH 3/3] media: only show V4L devices based on device type selection Mauro Carvalho Chehab
2012-05-27 17:13 ` [RFC] file tree rearrangement - was: Re: [RFC PATCH 0/3] Improve Kconfig selection for media devices Mauro Carvalho Chehab
2012-05-27 17:25 ` Hans Verkuil
2012-05-27 18:47 ` Andy Walls
2012-05-27 20:15 ` Mauro Carvalho Chehab
2012-05-28 9:42 ` Hans Verkuil
2012-05-28 11:03 ` Mauro Carvalho Chehab
2012-05-28 11:45 ` Hans Verkuil
2012-05-28 12:10 ` Mauro Carvalho Chehab
2012-05-27 19:54 ` Mauro Carvalho Chehab
2012-05-28 9:12 ` Hans Verkuil
2012-05-28 9:48 ` Stefan Richter [this message]
2012-05-28 11:38 ` Mauro Carvalho Chehab
2012-05-28 12:17 ` Stefan Richter
2012-05-28 12:32 ` Mauro Carvalho Chehab
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120528114803.0d1a4881@stein \
--to=stefanr@s5r6.in-berlin.de \
--cc=hverkuil@xs4all.nl \
--cc=linux-media@vger.kernel.org \
--cc=mchehab@redhat.com \
--cc=snjw23@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).