From mboxrd@z Thu Jan  1 00:00:00 1970
Return-path: <linux-media-owner@vger.kernel.org>
Received: from rcsinet15.oracle.com ([148.87.113.117]:34213 "EHLO
	rcsinet15.oracle.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
	with ESMTP id S1752989Ab2FRU4o (ORCPT
	<rfc822;linux-media@vger.kernel.org>);
	Mon, 18 Jun 2012 16:56:44 -0400
Date: Mon, 18 Jun 2012 23:56:29 +0300
From: Dan Carpenter <dan.carpenter@oracle.com>
To: Ezequiel Garcia <elezegarcia@gmail.com>
Cc: Mauro Carvalho Chehab <mchehab@redhat.com>,
	linux-media <linux-media@vger.kernel.org>,
	Palash Bandyopadhyay <palash.bandyopadhyay@conexant.com>,
	stoth@kernellabs.com
Subject: Re: [PATCH 0/12] struct i2c_algo_bit_data cleanup on several drivers
Message-ID: <20120618205629.GI13539@mwanda>
References: <CALF0-+XS6gjiLDSGwumBp1xfXYvzii9f_Lw4qhyxVzwMzfh9Rg@mail.gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <CALF0-+XS6gjiLDSGwumBp1xfXYvzii9f_Lw4qhyxVzwMzfh9Rg@mail.gmail.com>
Sender: linux-media-owner@vger.kernel.org
List-ID: <linux-media.vger.kernel.org>

On Mon, Jun 18, 2012 at 04:23:14PM -0300, Ezequiel Garcia wrote:
> Hi Mauro,
> 
> This patchset cleans the i2c part of some drivers.
> This issue was recently reported by Dan Carpenter [1],
> and revealed wrong (and harmless) usage of struct i2c_algo_bit.
> 

How is this harmless?  We are setting the function pointers to
something completely bogus.  It seems like a bad thing.

regards,
dan carpenter