From: Dan Carpenter <dan.carpenter@oracle.com>
To: Ezequiel Garcia <elezegarcia@gmail.com>
Cc: Mauro Carvalho Chehab <mchehab@redhat.com>,
linux-media <linux-media@vger.kernel.org>,
Palash Bandyopadhyay <palash.bandyopadhyay@conexant.com>,
stoth@kernellabs.com
Subject: Re: [PATCH 0/12] struct i2c_algo_bit_data cleanup on several drivers
Date: Tue, 19 Jun 2012 00:17:18 +0300 [thread overview]
Message-ID: <20120618211718.GJ13539@mwanda> (raw)
In-Reply-To: <CALF0-+WX+cbF1s4vUBE0Fa6AMA3QcBwp7Bd1i=0rofZp7F_VAA@mail.gmail.com>
On Mon, Jun 18, 2012 at 06:00:52PM -0300, Ezequiel Garcia wrote:
> On Mon, Jun 18, 2012 at 5:56 PM, Dan Carpenter <dan.carpenter@oracle.com> wrote:
> > On Mon, Jun 18, 2012 at 04:23:14PM -0300, Ezequiel Garcia wrote:
> >> Hi Mauro,
> >>
> >> This patchset cleans the i2c part of some drivers.
> >> This issue was recently reported by Dan Carpenter [1],
> >> and revealed wrong (and harmless) usage of struct i2c_algo_bit.
> >>
> >
> > How is this harmless? We are setting the function pointers to
> > something completely bogus. It seems like a bad thing.
> >
>
> You're right, but that wrongly assigned struct algo_bit_data is never
> *ever* used,
> since it is not registered.
>
> So, I meant it was harmless in that way, perhaps it wasn't the right term.
No no. I didn't realize these files didn't call i2c_add_bus().
Harmless is the right term.
regards,
dan carpenter
next prev parent reply other threads:[~2012-06-18 21:17 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-06-18 19:23 [PATCH 0/12] struct i2c_algo_bit_data cleanup on several drivers Ezequiel Garcia
2012-06-18 20:30 ` Palash Bandyopadhyay
2012-06-18 20:51 ` Ezequiel Garcia
2012-06-18 20:56 ` Dan Carpenter
2012-06-18 21:00 ` Ezequiel Garcia
2012-06-18 21:17 ` Dan Carpenter [this message]
2012-06-27 16:51 ` [PATCH v2 0/9] " Ezequiel Garcia
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120618211718.GJ13539@mwanda \
--to=dan.carpenter@oracle.com \
--cc=elezegarcia@gmail.com \
--cc=linux-media@vger.kernel.org \
--cc=mchehab@redhat.com \
--cc=palash.bandyopadhyay@conexant.com \
--cc=stoth@kernellabs.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox