From: "David Härdeman" <david@hardeman.nu>
To: Anton Blanchard <anton@samba.org>
Cc: mchehab@infradead.org, linux-media@vger.kernel.org
Subject: Re: [PATCH 1/3] [media] winbond-cir: Fix txandrx module info
Date: Tue, 3 Jul 2012 22:18:47 +0200 [thread overview]
Message-ID: <20120703201847.GA29839@hardeman.nu> (raw)
In-Reply-To: <20120702115800.1275f944@kryten>
On Mon, Jul 02, 2012 at 11:58:00AM +1000, Anton Blanchard wrote:
>
>We aren't getting any module info for the txandx option because
>of a typo:
>
>parm: txandrx:bool
>
>Signed-off-by: Anton Blanchard <anton@samba.org>
Acked-by: David Härdeman <david@hardeman.nu>
>---
>
>Index: linux-2.6/drivers/media/rc/winbond-cir.c
>===================================================================
>--- linux-2.6.orig/drivers/media/rc/winbond-cir.c 2011-11-20 20:30:57.831906589 +1100
>+++ linux-2.6/drivers/media/rc/winbond-cir.c 2011-11-20 20:32:13.472362123 +1100
>@@ -232,7 +232,7 @@ MODULE_PARM_DESC(invert, "Invert the sig
>
> static int txandrx; /* default = 0 */
> module_param(txandrx, bool, 0444);
>-MODULE_PARM_DESC(invert, "Allow simultaneous TX and RX");
>+MODULE_PARM_DESC(txandrx, "Allow simultaneous TX and RX");
>
> static unsigned int wake_sc = 0x800F040C;
> module_param(wake_sc, uint, 0644);
>
prev parent reply other threads:[~2012-07-03 20:27 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-07-02 1:58 [PATCH 1/3] [media] winbond-cir: Fix txandrx module info Anton Blanchard
2012-07-02 1:58 ` [PATCH 2/3] [media] winbond-cir: Initialise timeout, driver_type and allowed_protos Anton Blanchard
2012-07-03 20:22 ` David Härdeman
2012-07-02 1:59 ` [PATCH 3/3] [media] winbond-cir: Adjust sample frequency to improve reliability Anton Blanchard
2012-07-03 20:28 ` David Härdeman
2012-07-05 10:30 ` Anton Blanchard
2012-07-05 11:04 ` Konstantin Dimitrov
2012-07-05 14:13 ` David Härdeman
2012-07-05 14:39 ` Konstantin Dimitrov
2012-07-05 14:45 ` David Härdeman
2012-07-05 14:56 ` Konstantin Dimitrov
2012-07-09 2:02 ` Anton Blanchard
2012-08-20 21:40 ` David Härdeman
2012-07-03 20:18 ` David Härdeman [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120703201847.GA29839@hardeman.nu \
--to=david@hardeman.nu \
--cc=anton@samba.org \
--cc=linux-media@vger.kernel.org \
--cc=mchehab@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).