From: Greg KH <gregkh@linuxfoundation.org>
To: Tomasz Stanislawski <t.stanislaws@samsung.com>
Cc: linux-media@vger.kernel.org, dri-devel@lists.freedesktop.org,
airlied@redhat.com, m.szyprowski@samsung.com,
kyungmin.park@samsung.com, laurent.pinchart@ideasonboard.com,
sumit.semwal@linaro.org, inki.dae@samsung.com,
daniel.vetter@ffwll.ch, rob@ti.com, pawel@osciak.com,
linaro-mm-sig@lists.linaro.org, linux-kernel@vger.kernel.org,
jy0922.shim@samsung.com, sw0312.kim@samsung.com,
dan.j.williams@intel.com, linux-doc@vger.kernel.org
Subject: Re: [PATCH v2 1/2] dma-buf: add reference counting for exporter module
Date: Thu, 9 Aug 2012 07:23:46 -0700 [thread overview]
Message-ID: <20120809142346.GA17402@kroah.com> (raw)
In-Reply-To: <1344504982-30415-2-git-send-email-t.stanislaws@samsung.com>
On Thu, Aug 09, 2012 at 11:36:21AM +0200, Tomasz Stanislawski wrote:
> This patch adds reference counting on a module that exported dma-buf and
> implements its operations. This prevents the module from being unloaded while
> DMABUF file is in use.
Why force all of the modules to be changed "by hand", and not just do
this automatically by changing the register function to include the
THIS_MODULE macro in it? Much like the pci_register_driver() function
is implemented in include/linux/pci.h?
That makes it impossible for driver authors to get it wrong, which is
always a good sign of a correct api.
thanks,
greg k-h
next prev parent reply other threads:[~2012-08-09 14:23 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-08-09 9:36 [PATCH v2 0/2] Enhance DMABUF with reference counting for exporter module Tomasz Stanislawski
2012-08-09 9:36 ` [PATCH v2 1/2] dma-buf: add " Tomasz Stanislawski
2012-08-09 14:23 ` Greg KH [this message]
2012-08-09 14:54 ` Tomasz Stanislawski
2012-08-09 9:36 ` [PATCH v2 2/2] drm: set owner field to for all DMABUF exporters Tomasz Stanislawski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120809142346.GA17402@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=airlied@redhat.com \
--cc=dan.j.williams@intel.com \
--cc=daniel.vetter@ffwll.ch \
--cc=dri-devel@lists.freedesktop.org \
--cc=inki.dae@samsung.com \
--cc=jy0922.shim@samsung.com \
--cc=kyungmin.park@samsung.com \
--cc=laurent.pinchart@ideasonboard.com \
--cc=linaro-mm-sig@lists.linaro.org \
--cc=linux-doc@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=m.szyprowski@samsung.com \
--cc=pawel@osciak.com \
--cc=rob@ti.com \
--cc=sumit.semwal@linaro.org \
--cc=sw0312.kim@samsung.com \
--cc=t.stanislaws@samsung.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).