From: Dan Carpenter <dan.carpenter@oracle.com>
To: mchehab@redhat.com
Cc: linux-media@vger.kernel.org
Subject: re: [media] lmedm04: fix build
Date: Mon, 13 Aug 2012 19:58:11 +0300 [thread overview]
Message-ID: <20120813165811.GB5363@elgon.mountain> (raw)
Hello Mauro Carvalho Chehab,
The patch db6651a9ebb3: "[media] lmedm04: fix build" from Aug 12,
2012, leads to the following warning:
drivers/media/dvb/dvb-usb-v2/lmedm04.c:769 lme2510_download_firmware()
error: usb_control_msg() 'data' too small (128 vs 265)
737 data = kzalloc(128, GFP_KERNEL);
^^^
data is 128 bytes.
738 if (!data) {
739 info("FRM Could not start Firmware Download"\
740 "(Buffer allocation failed)");
741 return -ENOMEM;
742 }
743
[snip]
768
769 usb_control_msg(d->udev, usb_rcvctrlpipe(d->udev, 0),
770 0x06, 0x80, 0x0200, 0x00, data, 0x0109, 1000);
^^^^^^
Smatch expects this parameter to equal to sizeof(data) or smaller
instead of 265.
regards,
dan carpenter
next reply other threads:[~2012-08-13 16:58 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-08-13 16:58 Dan Carpenter [this message]
2012-08-13 18:42 ` [PATCH] re: [media] lmedm04: fix build Malcolm Priestley
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120813165811.GB5363@elgon.mountain \
--to=dan.carpenter@oracle.com \
--cc=linux-media@vger.kernel.org \
--cc=mchehab@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox