From: Jonathan Corbet <corbet@lwn.net>
To: Mauro Carvalho Chehab <mchehab@redhat.com>
Cc: Chris Ball <cjb@laptop.org>, linux-media@vger.kernel.org
Subject: Re: [PATCH 2/2] marvell-cam: Build fix: missing "select VIDEOBUF2_VMALLOC"
Date: Thu, 16 Aug 2012 11:11:26 -0600 [thread overview]
Message-ID: <20120816111126.60443d36@lwn.net> (raw)
In-Reply-To: <50298248.2000609@redhat.com>
On Mon, 13 Aug 2012 19:40:08 -0300
Mauro Carvalho Chehab <mchehab@redhat.com> wrote:
> Ping?
>
> Is this patch needed or not?
Sorry, I have dropped vast numbers of balls over the last six months and
am far from having picked them all up.
Reviewing the conversation, I still must confess that I don't understand
the problem. Why is having the VB2 vmalloc support built as a module a
problem?
> Another alternative would be to change the Kconfig stuff to explicitly select
> the type of videobuf2 that would be used by those drivers, something like the
> enclosed (untested) patch.
The current Kconfig already has specific select lines for the supported
modes.
When I get a chance, I'll go in and try to reproduce the problem, but it
may be a little bit, sorry...
jon
prev parent reply other threads:[~2012-08-16 17:11 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-04-26 20:07 [PATCH 2/2] marvell-cam: Build fix: missing "select VIDEOBUF2_VMALLOC" Chris Ball
2012-04-27 16:03 ` Jonathan Corbet
2012-04-27 16:44 ` Chris Ball
2012-08-13 22:40 ` Mauro Carvalho Chehab
2012-08-16 17:11 ` Jonathan Corbet [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120816111126.60443d36@lwn.net \
--to=corbet@lwn.net \
--cc=cjb@laptop.org \
--cc=linux-media@vger.kernel.org \
--cc=mchehab@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).