From: "nibble.max" <nibble.max@gmail.com>
To: "Rémi Cardona" <remi.cardona@smartjog.com>
Cc: "Antti Palosaari" <crope@iki.fi>,
linux-media <linux-media@vger.kernel.org>
Subject: Re: Re: [PATCH 2/2] [media] ds3000: properly report firmware loadingissues
Date: Tue, 4 Sep 2012 10:19:53 +0800 [thread overview]
Message-ID: <201209041019509688584@gmail.com> (raw)
In-Reply-To: 201208311629500154084@gmail.com
>Hi Max,
>
>On 08/31/2012 10:29 AM, nibble.max wrote:
>> As remember that there is a fault in the tuner register read function in ds3000.c file.
>> It will cause the read back value wrong.
>
>Well, using 0x12 works out for most of the cards we have in the wild.
>Not knowing what 0x11 / 0x12 means, I'd be wary of suggesting such a
>change myself. Once I isolate the faulty cards, I'll try using 0x11 on
>them to see if it changes anything.
This value is related with i2c operation through demod i2c bus to access tuner i2c bus. tuner i2c bus is bridges with demod i2c bus. This value tells the demod that how many i2c stop will be detected. The i2c bus to tuner will be closed by the demod automatically, as soon as the demod detects such many i2c stops.
0x11 means there is only one i2c stop during tuner i2c operation.
0x12 means there are two i2c stop during tuner i2c operation.
In cx23885 i2c implement and flag=I2C_M_RD, for reading there is only one stop.
yes, 0x12 seems working since the operation after tuner reading operation is not critical.
Max
>
>Thanks for the pointer,
>
>Rémi
prev parent reply other threads:[~2012-09-04 2:19 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-08-30 9:36 [PATCH RFC 0/2] ds3000 firmware loading improvements Rémi Cardona
2012-08-30 9:36 ` [PATCH 1/2] [media] ds3000: Remove useless 'locking' Rémi Cardona
2012-09-03 14:13 ` Rémi Cardona
2012-08-30 9:36 ` [PATCH 2/2] [media] ds3000: properly report firmware loading issues Rémi Cardona
2012-08-30 13:39 ` Antti Palosaari
2012-08-30 15:21 ` Rémi Cardona
2012-08-30 16:00 ` Antti Palosaari
2012-09-03 13:27 ` Rémi Cardona
2012-08-31 8:29 ` Re: [PATCH 2/2] [media] ds3000: properly report firmware loadingissues nibble.max
2012-09-03 14:11 ` Rémi Cardona
2012-09-04 2:19 ` nibble.max [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201209041019509688584@gmail.com \
--to=nibble.max@gmail.com \
--cc=crope@iki.fi \
--cc=linux-media@vger.kernel.org \
--cc=remi.cardona@smartjog.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).