From: Hans Verkuil <hverkuil@xs4all.nl>
To: javier Martin <javier.martin@vista-silicon.com>
Cc: linux-media@vger.kernel.org, Jonathan Corbet <corbet@lwn.net>,
Mauro Carvalho Chehab <mchehab@infradead.org>,
Guennadi Liakhovetski <g.liakhovetski@gmx.de>,
Laurent Pinchart <laurent.pinchart@ideasonboard.com>,
brijohn@gmail.com
Subject: Re: Improving ov7670 sensor driver.
Date: Thu, 13 Sep 2012 13:32:32 +0200 [thread overview]
Message-ID: <201209131332.32924.hverkuil@xs4all.nl> (raw)
In-Reply-To: <CACKLOr1xpTv7775Uj6xmfbecDaQBaWMqB7htNjOLfwubQD8AbQ@mail.gmail.com>
On Thu 13 September 2012 13:19:14 javier Martin wrote:
> On 13 September 2012 13:00, Hans Verkuil <hverkuil@xs4all.nl> wrote:
> > On Thu 13 September 2012 12:47:53 javier Martin wrote:
> >> >> 3.- Adjust vstart/vstop in order to remove an horizontal green line.
> >> >>
> >> >> Why? Currently, in the driver, for VGA, vstart = 10 and vstop = 490.
> >> >> From our tests we found out that vstart = 14, vstop = 494 in order to
> >> >> remove a disgusting horizontal green line in ov7675.
> >> >> How? It seems these sensor aren't provided with a version register or
> >> >> anything similar so I can't think of a clean solution for this yet.
> >> >> Suggestions will be much appreciated.
> >> >
> >> > Using platform_data for this is what springs to mind.
> >>
> >> I had thought about it too but, there
> >
> > Unfinished sentence?
> >
>
> Yes. Sorry :)
>
> I meant that I had thought about it too but there are one pair of
> vstart,vstop values for each supported resolution: VGA, QVGA, CIF,
> QCIF.
> I could add 'vstart_vga', 'vstop_vga' as platform_data but in the
> future someone could want to add the same values for the other ones
> and I don't know if that would be acceptable.
>
> Another solution I just came up with would be adding a flag 'version'
> where we could indicate if we are dealing with an ov7670 or an ov7675
> and change those 'vstart', 'vstop' values internally based on this.
> This could be useful for some other issues in the future.
You can actually add support for a ov7675 to the ov7670 driver itself
by adding a ov7675 entry to the ov7670_id table. See for example the
i2c/saa7127.c driver on how to do that.
Regards,
Hans
next prev parent reply other threads:[~2012-09-13 11:32 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-09-13 9:48 Improving ov7670 sensor driver javier Martin
2012-09-13 10:07 ` Hans Verkuil
2012-09-13 10:47 ` javier Martin
2012-09-13 11:00 ` Hans Verkuil
2012-09-13 11:19 ` javier Martin
2012-09-13 11:32 ` Hans Verkuil [this message]
2012-09-13 13:00 ` Mauro Carvalho Chehab
2012-09-14 6:33 ` javier Martin
2012-09-14 22:05 ` Laurent Pinchart
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201209131332.32924.hverkuil@xs4all.nl \
--to=hverkuil@xs4all.nl \
--cc=brijohn@gmail.com \
--cc=corbet@lwn.net \
--cc=g.liakhovetski@gmx.de \
--cc=javier.martin@vista-silicon.com \
--cc=laurent.pinchart@ideasonboard.com \
--cc=linux-media@vger.kernel.org \
--cc=mchehab@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).