From: Anatolij Gustschin <agust@denx.de>
To: Guennadi Liakhovetski <g.liakhovetski@gmx.de>
Cc: linux-media@vger.kernel.org,
Mauro Carvalho Chehab <mchehab@infradead.org>,
dzu@denx.de
Subject: Re: [PATCH 2/3] mt9v022: fix the V4L2_CID_EXPOSURE control
Date: Fri, 21 Sep 2012 11:30:24 +0200 [thread overview]
Message-ID: <20120921113024.52133cf0@wker> (raw)
In-Reply-To: <Pine.LNX.4.64.1208241632130.20710@axis700.grange>
On Fri, 24 Aug 2012 16:32:57 +0200 (CEST)
Guennadi Liakhovetski <g.liakhovetski@gmx.de> wrote:
...
> > > But why do we have to write it here at all then? Autoexposure can be off
> > > only if the user has set exposure manually, using V4L2_CID_EXPOSURE_AUTO.
> > > In this case MT9V022_TOTAL_SHUTTER_WIDTH already contains the correct
> > > value. Why do we have to set it again? Maybe just adding a comment,
> > > explaining the above, would suffice?
> >
> > Actually we do not have to write it here, yes. Should I remove the shutter
> > register setting here entirely? And add a comment explaining, why?
>
> Remove it from the "else" clause, yes, please. And a comment would be
> good!
Ok, I'll resubmit a reworked patch.
Thanks,
Anatolij
next prev parent reply other threads:[~2012-09-21 9:30 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-08-24 9:10 [PATCH 0/3] various updates for mt9v022 driver Anatolij Gustschin
2012-08-24 9:10 ` [PATCH 1/3] mt9v022: add v4l2 controls for blanking and other register settings Anatolij Gustschin
2012-08-24 11:08 ` Guennadi Liakhovetski
2012-08-24 13:04 ` Detlev Zundel
2012-08-24 13:35 ` Guennadi Liakhovetski
2012-08-24 15:44 ` Detlev Zundel
2012-08-24 16:21 ` Anatolij Gustschin
2012-08-24 21:23 ` Guennadi Liakhovetski
2012-08-28 13:43 ` Anatolij Gustschin
2012-09-11 8:24 ` Guennadi Liakhovetski
2012-09-27 21:10 ` Anatolij Gustschin
2012-08-24 13:28 ` Anatolij Gustschin
2012-09-27 22:03 ` [PATCH v2 1/3] mt9v022: add v4l2 controls for blanking Anatolij Gustschin
2012-10-06 11:00 ` Anatolij Gustschin
2012-10-09 10:32 ` Guennadi Liakhovetski
2012-08-24 9:10 ` [PATCH 2/3] mt9v022: fix the V4L2_CID_EXPOSURE control Anatolij Gustschin
2012-08-24 11:22 ` Guennadi Liakhovetski
2012-08-24 14:17 ` Anatolij Gustschin
2012-08-24 14:32 ` Guennadi Liakhovetski
2012-09-21 9:30 ` Anatolij Gustschin [this message]
2012-09-27 22:04 ` [PATCH v2 " Anatolij Gustschin
2012-08-24 9:10 ` [PATCH 3/3] mt9v022: set y_skip_top field to zero Anatolij Gustschin
2012-08-24 11:23 ` Guennadi Liakhovetski
2012-08-24 13:34 ` Anatolij Gustschin
2012-09-11 8:55 ` Guennadi Liakhovetski
2012-09-21 9:28 ` Anatolij Gustschin
2012-09-27 22:05 ` [PATCH v2 3/3] mt9v022: set y_skip_top field to zero as default Anatolij Gustschin
[not found] ` <Pine.LNX.4.64.1209281413220.5428@axis700.grange>
[not found] ` <Pine.LNX.4.64.1209281420420.5428@axis700.grange>
2012-09-29 2:21 ` Eric Miao
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120921113024.52133cf0@wker \
--to=agust@denx.de \
--cc=dzu@denx.de \
--cc=g.liakhovetski@gmx.de \
--cc=linux-media@vger.kernel.org \
--cc=mchehab@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).