From: Dan Carpenter <dan.carpenter@oracle.com>
To: walter harms <wharms@bfs.de>
Cc: Mauro Carvalho Chehab <mchehab@infradead.org>,
"Leonid V. Fedorenchik" <leonidsbox@gmail.com>,
Thomas Meyer <thomas@m3y3r.de>,
Hans Verkuil <hans.verkuil@cisco.com>,
linux-media@vger.kernel.org, kernel-janitors@vger.kernel.org
Subject: Re: [patch] [media] cx25821: testing the wrong variable
Date: Sat, 29 Sep 2012 17:32:05 +0300 [thread overview]
Message-ID: <20120929143205.GN4587@mwanda> (raw)
In-Reply-To: <5066D2F6.10800@bfs.de>
On Sat, Sep 29, 2012 at 12:52:38PM +0200, walter harms wrote:
>
>
> Am 29.09.2012 09:12, schrieb Dan Carpenter:
> > ->input_filename could be NULL here. The intent was to test
> > ->_filename.
> >
> > Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
> > ---
> > I'm not totally convinced that using /root/vid411.yuv is the right idea.
> >
> > diff --git a/drivers/media/pci/cx25821/cx25821-video-upstream.c b/drivers/media/pci/cx25821/cx25821-video-upstream.c
> > index 52c13e0..6759fff 100644
> > --- a/drivers/media/pci/cx25821/cx25821-video-upstream.c
> > +++ b/drivers/media/pci/cx25821/cx25821-video-upstream.c
> > @@ -808,7 +808,7 @@ int cx25821_vidupstream_init_ch1(struct cx25821_dev *dev, int channel_select,
> > }
> >
> > /* Default if filename is empty string */
> > - if (strcmp(dev->input_filename, "") == 0) {
> > + if (strcmp(dev->_filename, "") == 0) {
> > if (dev->_isNTSC) {
> > dev->_filename =
> > (dev->_pixel_format == PIXEL_FRMT_411) ?
> > diff --git a/drivers/media/pci/cx25821/cx25821-video-upstream-ch2.c b/drivers/media/pci/cx25821/cx25821-video-upstream-ch2.c
> > index c8c94fb..d33fc1a 100644
> > --- a/drivers/media/pci/cx25821/cx25821-video-upstream-ch2.c
> > +++ b/drivers/media/pci/cx25821/cx25821-video-upstream-ch2.c
> > @@ -761,7 +761,7 @@ int cx25821_vidupstream_init_ch2(struct cx25821_dev *dev, int channel_select,
> > }
> >
> > /* Default if filename is empty string */
> > - if (strcmp(dev->input_filename_ch2, "") == 0) {
> > + if (strcmp(dev->_filename_ch2, "") == 0) {
> > if (dev->_isNTSC_ch2) {
> > dev->_filename_ch2 = (dev->_pixel_format_ch2 ==
> > PIXEL_FRMT_411) ? "/root/vid411.yuv" :
> >
>
> In this case stcmp seems a bit of a overkill. A simple
> *(dev->_filename_ch2) == 0
> should be ok ?
I prefer strcmp() actually. More readable.
regards,
dan carpenter
>
> re,
> wh
> --
> To unsubscribe from this list: send the line "unsubscribe kernel-janitors" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
next prev parent reply other threads:[~2012-09-29 14:32 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-09-29 7:12 [patch] [media] cx25821: testing the wrong variable Dan Carpenter
2012-09-29 10:52 ` walter harms
2012-09-29 14:32 ` Dan Carpenter [this message]
2012-09-29 15:17 ` Ezequiel Garcia
2012-10-07 12:49 ` Mauro Carvalho Chehab
2012-10-08 22:21 ` Palash Bandyopadhyay
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120929143205.GN4587@mwanda \
--to=dan.carpenter@oracle.com \
--cc=hans.verkuil@cisco.com \
--cc=kernel-janitors@vger.kernel.org \
--cc=leonidsbox@gmail.com \
--cc=linux-media@vger.kernel.org \
--cc=mchehab@infradead.org \
--cc=thomas@m3y3r.de \
--cc=wharms@bfs.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).