linux-media.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Mauro Carvalho Chehab <mchehab@redhat.com>
To: Damien Bally <biribi@free.fr>
Cc: Malcolm Priestley <tvboxspy@gmail.com>,
	Antti Palosaari <crope@iki.fi>,
	linux-media@vger.kernel.org
Subject: Re: [PATCH] usb id addition for Terratec Cinergy T Stick Dual rev. 2
Date: Mon, 1 Oct 2012 08:15:40 -0300	[thread overview]
Message-ID: <20121001081540.69bdae23@redhat.com> (raw)
In-Reply-To: <50688332.7020406@free.fr>

Em Sun, 30 Sep 2012 19:36:50 +0200
Damien Bally <biribi@free.fr> escreveu:

> 
> 
> Le 29/09/2012 19:33, Mauro Carvalho Chehab a écrit :
>   It seems that the it931x variant has bcdDevice equal to 2.00,
> > from Damien's email:
> >
> >     idVendor           0x0ccd TerraTec Electronic GmbH
> >     idProduct          0x0099
> >     bcdDevice            2.00
> >     iManufacturer           1 ITE Technologies, Inc.
> >     iProduct                2 DVB-T TV Stick
> >     iSerial                 0
> >
> > If the af9015 variant uses another bcdDevice, the fix should be simple.
> 
> Alas, according to 
> http://www.linuxtv.org/wiki/index.php/TerraTec_Cinergy_T_USB_Dual_RC the 
> af9015 variant appears to have the same bcdDevice. I join both lsusb 
> outputs for comparison.

Well, then the alternative is to let both drivers to handle this USB ID,
and add a code there on each of them that will check if the device is the
right one, perhaps by looking at iProduct string. If the driver doesn't
recognize it, it should return -ENODEV at .probe() time. The USB core will
call the second driver.

Regards,
Mauro

  reply	other threads:[~2012-10-01 11:15 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <5064A3AD.70009@free.fr>
2012-09-27 19:41 ` [PATCH] usb id addition for Terratec Cinergy T Stick Dual rev. 2 Antti Palosaari
2012-09-28 16:34   ` Damien Bally
2012-09-28 17:55     ` Antti Palosaari
2012-09-28 19:00       ` Damien Bally
2012-09-28 19:30       ` Malcolm Priestley
2012-09-29 17:33         ` Mauro Carvalho Chehab
2012-09-30 17:36           ` Damien Bally
2012-10-01 11:15             ` Mauro Carvalho Chehab [this message]
2012-10-01 11:21               ` Antti Palosaari
2012-10-06 15:40                 ` Mauro Carvalho Chehab
2013-01-07 19:37                   ` Antti Palosaari
2013-01-07 20:13                     ` Malcolm Priestley
2013-01-07 21:06                       ` Antti Palosaari

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20121001081540.69bdae23@redhat.com \
    --to=mchehab@redhat.com \
    --cc=biribi@free.fr \
    --cc=crope@iki.fi \
    --cc=linux-media@vger.kernel.org \
    --cc=tvboxspy@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).