From mboxrd@z Thu Jan 1 00:00:00 1970 Return-path: Received: from mx1.redhat.com ([209.132.183.28]:49848 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752584Ab2JFPkn convert rfc822-to-8bit (ORCPT ); Sat, 6 Oct 2012 11:40:43 -0400 Date: Sat, 6 Oct 2012 12:40:20 -0300 From: Mauro Carvalho Chehab To: Antti Palosaari Cc: Damien Bally , Malcolm Priestley , linux-media@vger.kernel.org Subject: Re: [PATCH] usb id addition for Terratec Cinergy T Stick Dual rev. 2 Message-ID: <20121006124020.2cc2f534@redhat.com> In-Reply-To: <50697CBE.8060001@iki.fi> References: <5064A3AD.70009@free.fr> <5064ABD2.2060106@iki.fi> <5065D1AC.5030800@free.fr> <5065E487.80502@iki.fi> <1348860617.2782.26.camel@Route3278> <20120929143305.4859603e@redhat.com> <50688332.7020406@free.fr> <20121001081540.69bdae23@redhat.com> <50697CBE.8060001@iki.fi> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8BIT Sender: linux-media-owner@vger.kernel.org List-ID: Em Mon, 01 Oct 2012 14:21:34 +0300 Antti Palosaari escreveu: > On 10/01/2012 02:15 PM, Mauro Carvalho Chehab wrote: > > Em Sun, 30 Sep 2012 19:36:50 +0200 > > Damien Bally escreveu: > > > >> > >> > >> Le 29/09/2012 19:33, Mauro Carvalho Chehab a écrit : > >> It seems that the it931x variant has bcdDevice equal to 2.00, > >>> from Damien's email: > >>> > >>> idVendor 0x0ccd TerraTec Electronic GmbH > >>> idProduct 0x0099 > >>> bcdDevice 2.00 > >>> iManufacturer 1 ITE Technologies, Inc. > >>> iProduct 2 DVB-T TV Stick > >>> iSerial 0 > >>> > >>> If the af9015 variant uses another bcdDevice, the fix should be simple. > >> > >> Alas, according to > >> http://www.linuxtv.org/wiki/index.php/TerraTec_Cinergy_T_USB_Dual_RC the > >> af9015 variant appears to have the same bcdDevice. I join both lsusb > >> outputs for comparison. > > > > Well, then the alternative is to let both drivers to handle this USB ID, > > and add a code there on each of them that will check if the device is the > > right one, perhaps by looking at iProduct string. If the driver doesn't > > recognize it, it should return -ENODEV at .probe() time. The USB core will > > call the second driver. > > It is the easiest solution, but there should be very careful. Those > strings could change from device to device. I used earlier af9015 eeprom > hash (those string as coming from the eeprom) to map TerraTec dual > remote controller and git bug report quite soon as it didn't worked. > After I looked the reason I found out they was changed some not > meaningful value. Yeah, those strings can change, especially when vendors don't care enough to use a different USB ID/bcdDevice for different models. Yet, seems to be the cleaner approach, among the alternatives. Regards, Mauro > > t. Antti -- Regards, Mauro