From: Mark Brown <broonie@opensource.wolfsonmicro.com>
To: Andrey Smirnov <andrey.smirnov@convergeddevices.net>
Cc: andrey.smrinov@convergeddevices.net, hverkuil@xs4all.nl,
mchehab@redhat.com, sameo@linux.intel.com, perex@perex.cz,
tiwai@suse.de, linux-media@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2 2/6] Add the main bulk of core driver for SI476x code
Date: Tue, 9 Oct 2012 15:33:53 +0900 [thread overview]
Message-ID: <20121009063349.GN8237@opensource.wolfsonmicro.com> (raw)
In-Reply-To: <1349488502-11293-3-git-send-email-andrey.smirnov@convergeddevices.net>
On Fri, Oct 05, 2012 at 06:54:58PM -0700, Andrey Smirnov wrote:
> + err = regulator_enable(core->supplies.va);
> + if (err < 0)
> + break;
> +
> + err = regulator_enable(core->supplies.vio2);
> + if (err < 0)
> + goto disable_va;
> +
> + err = regulator_enable(core->supplies.vd);
> + if (err < 0)
> + goto disable_vio2;
> +
> + err = regulator_enable(core->supplies.vio1);
> + if (err < 0)
> + goto disable_vd;
If the sequencing is critical here you should have comments explaining
what the requirement is, otherwise this looks like a prime candidate
for conversion to regulator_bulk_enable() (and similarly for all the
other regulator usage, it appears that all the regulators are worked
with in a bulk fashion).
next prev parent reply other threads:[~2012-10-09 6:34 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-10-06 1:54 [PATCH v2 0/6] A driver for Si476x series of chips Andrey Smirnov
2012-10-06 1:54 ` [PATCH v2 1/6] Add header files and Kbuild plumbing for SI476x MFD core Andrey Smirnov
2012-10-08 8:43 ` Hans Verkuil
2012-10-08 18:38 ` Andrey Smirnov
2012-10-09 9:53 ` Hans Verkuil
2012-12-18 19:37 ` Mauro Carvalho Chehab
2012-12-19 3:07 ` Andrey Smirnov
2012-12-19 11:09 ` Mark Brown
2012-10-06 1:54 ` [PATCH v2 2/6] Add the main bulk of core driver for SI476x code Andrey Smirnov
2012-10-09 6:33 ` Mark Brown [this message]
2012-10-09 23:06 ` Andrey Smirnov
2012-10-06 1:54 ` [PATCH v2 3/6] Add commands abstraction layer for SI476X MFD Andrey Smirnov
2012-10-08 8:56 ` Hans Verkuil
2012-10-08 20:06 ` Andrey Smirnov
2012-10-09 9:42 ` Hans Verkuil
2012-10-06 1:55 ` [PATCH v2 4/6] Add chip properties handling code " Andrey Smirnov
2012-10-06 1:55 ` [PATCH v2 5/6] Add a V4L2 driver " Andrey Smirnov
2012-10-08 9:30 ` Hans Verkuil
2012-10-08 17:57 ` Andrey Smirnov
2012-10-09 9:38 ` Hans Verkuil
2012-10-09 15:45 ` halli manjunatha
2012-10-06 1:55 ` [PATCH v2 6/6] Add a codec " Andrey Smirnov
2012-10-09 6:35 ` Mark Brown
2012-10-08 9:37 ` [PATCH v2 0/6] A driver for Si476x series of chips Hans Verkuil
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20121009063349.GN8237@opensource.wolfsonmicro.com \
--to=broonie@opensource.wolfsonmicro.com \
--cc=andrey.smirnov@convergeddevices.net \
--cc=andrey.smrinov@convergeddevices.net \
--cc=hverkuil@xs4all.nl \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=mchehab@redhat.com \
--cc=perex@perex.cz \
--cc=sameo@linux.intel.com \
--cc=tiwai@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).