* [PATCH 3/6] ARM: OMAP2+: Move plat/iovmm.h to include/linux/omap-iommu.h [not found] <20121018202707.11834.1438.stgit@muffinssi.local> @ 2012-10-18 20:28 ` Tony Lindgren 2012-10-18 20:56 ` Mauro Carvalho Chehab 2012-10-19 9:40 ` Laurent Pinchart 2012-10-18 20:28 ` [PATCH 4/6] ARM: OMAP2+: Move iommu2 to drivers/iommu/omap-iommu2.c Tony Lindgren 1 sibling, 2 replies; 21+ messages in thread From: Tony Lindgren @ 2012-10-18 20:28 UTC (permalink / raw) To: linux-arm-kernel Cc: Ohad Ben-Cohen, Joerg Roedel, Mauro Carvalho Chehab, Laurent Pinchart, Omar Ramirez Luna, linux-omap, Ido Yariv, linux-media Looks like the iommu framework does not have generic functions exported for all the needs yet. The hardware specific functions are defined in files like intel-iommu.h and amd-iommu.h. Follow the same standard for omap-iommu.h. This is needed because we are removing plat and mach includes for ARM common zImage support. Further work should continue in the iommu framework context as only pure platform data will be communicated from arch/arm/*omap*/* code to the iommu framework. Cc: Joerg Roedel <joerg.roedel@amd.com> Cc: Ohad Ben-Cohen <ohad@wizery.com> Cc: Ido Yariv <ido@wizery.com> Cc: Laurent Pinchart <laurent.pinchart@ideasonboard.com> Cc: Mauro Carvalho Chehab <mchehab@infradead.org> Cc: Omar Ramirez Luna <omar.luna@linaro.org> Cc: linux-media@vger.kernel.org Signed-off-by: Tony Lindgren <tony@atomide.com> --- arch/arm/mach-omap2/iommu2.c | 1 arch/arm/plat-omap/include/plat/iommu.h | 10 +-- arch/arm/plat-omap/include/plat/iovmm.h | 89 ---------------------------- drivers/iommu/omap-iommu-debug.c | 2 - drivers/iommu/omap-iommu.c | 1 drivers/iommu/omap-iovmm.c | 46 ++++++++++++++ drivers/media/platform/omap3isp/isp.c | 1 drivers/media/platform/omap3isp/isp.h | 2 - drivers/media/platform/omap3isp/ispccdc.c | 1 drivers/media/platform/omap3isp/ispstat.c | 1 drivers/media/platform/omap3isp/ispvideo.c | 2 - include/linux/omap-iommu.h | 47 +++++++++++++++ 12 files changed, 101 insertions(+), 102 deletions(-) delete mode 100644 arch/arm/plat-omap/include/plat/iovmm.h create mode 100644 include/linux/omap-iommu.h diff --git a/arch/arm/mach-omap2/iommu2.c b/arch/arm/mach-omap2/iommu2.c index eefc379..77cbf2f 100644 --- a/arch/arm/mach-omap2/iommu2.c +++ b/arch/arm/mach-omap2/iommu2.c @@ -17,6 +17,7 @@ #include <linux/module.h> #include <linux/slab.h> #include <linux/stringify.h> +#include <linux/omap-iommu.h> #include <plat/iommu.h> diff --git a/arch/arm/plat-omap/include/plat/iommu.h b/arch/arm/plat-omap/include/plat/iommu.h index 7e8c7b6..a4b71b1 100644 --- a/arch/arm/plat-omap/include/plat/iommu.h +++ b/arch/arm/plat-omap/include/plat/iommu.h @@ -216,13 +216,10 @@ static inline struct omap_iommu *dev_to_omap_iommu(struct device *dev) #define MMU_RAM_PADDR_SHIFT 12 #define MMU_RAM_PADDR_MASK \ ((~0UL >> MMU_RAM_PADDR_SHIFT) << MMU_RAM_PADDR_SHIFT) -#define MMU_RAM_ENDIAN_SHIFT 9 + #define MMU_RAM_ENDIAN_MASK (1 << MMU_RAM_ENDIAN_SHIFT) -#define MMU_RAM_ENDIAN_BIG (1 << MMU_RAM_ENDIAN_SHIFT) -#define MMU_RAM_ENDIAN_LITTLE (0 << MMU_RAM_ENDIAN_SHIFT) -#define MMU_RAM_ELSZ_SHIFT 7 #define MMU_RAM_ELSZ_MASK (3 << MMU_RAM_ELSZ_SHIFT) -#define MMU_RAM_ELSZ_8 (0 << MMU_RAM_ELSZ_SHIFT) + #define MMU_RAM_ELSZ_16 (1 << MMU_RAM_ELSZ_SHIFT) #define MMU_RAM_ELSZ_32 (2 << MMU_RAM_ELSZ_SHIFT) #define MMU_RAM_ELSZ_NONE (3 << MMU_RAM_ELSZ_SHIFT) @@ -269,9 +266,6 @@ extern int omap_iommu_set_isr(const char *name, void *priv), void *isr_priv); -extern void omap_iommu_save_ctx(struct device *dev); -extern void omap_iommu_restore_ctx(struct device *dev); - extern int omap_install_iommu_arch(const struct iommu_functions *ops); extern void omap_uninstall_iommu_arch(const struct iommu_functions *ops); diff --git a/arch/arm/plat-omap/include/plat/iovmm.h b/arch/arm/plat-omap/include/plat/iovmm.h deleted file mode 100644 index 498e57c..0000000 --- a/arch/arm/plat-omap/include/plat/iovmm.h +++ /dev/null @@ -1,89 +0,0 @@ -/* - * omap iommu: simple virtual address space management - * - * Copyright (C) 2008-2009 Nokia Corporation - * - * Written by Hiroshi DOYU <Hiroshi.DOYU@nokia.com> - * - * This program is free software; you can redistribute it and/or modify - * it under the terms of the GNU General Public License version 2 as - * published by the Free Software Foundation. - */ - -#ifndef __IOMMU_MMAP_H -#define __IOMMU_MMAP_H - -#include <linux/iommu.h> - -struct iovm_struct { - struct omap_iommu *iommu; /* iommu object which this belongs to */ - u32 da_start; /* area definition */ - u32 da_end; - u32 flags; /* IOVMF_: see below */ - struct list_head list; /* linked in ascending order */ - const struct sg_table *sgt; /* keep 'page' <-> 'da' mapping */ - void *va; /* mpu side mapped address */ -}; - -/* - * IOVMF_FLAGS: attribute for iommu virtual memory area(iovma) - * - * lower 16 bit is used for h/w and upper 16 bit is for s/w. - */ -#define IOVMF_SW_SHIFT 16 - -/* - * iovma: h/w flags derived from cam and ram attribute - */ -#define IOVMF_CAM_MASK (~((1 << 10) - 1)) -#define IOVMF_RAM_MASK (~IOVMF_CAM_MASK) - -#define IOVMF_PGSZ_MASK (3 << 0) -#define IOVMF_PGSZ_1M MMU_CAM_PGSZ_1M -#define IOVMF_PGSZ_64K MMU_CAM_PGSZ_64K -#define IOVMF_PGSZ_4K MMU_CAM_PGSZ_4K -#define IOVMF_PGSZ_16M MMU_CAM_PGSZ_16M - -#define IOVMF_ENDIAN_MASK (1 << 9) -#define IOVMF_ENDIAN_BIG MMU_RAM_ENDIAN_BIG -#define IOVMF_ENDIAN_LITTLE MMU_RAM_ENDIAN_LITTLE - -#define IOVMF_ELSZ_MASK (3 << 7) -#define IOVMF_ELSZ_8 MMU_RAM_ELSZ_8 -#define IOVMF_ELSZ_16 MMU_RAM_ELSZ_16 -#define IOVMF_ELSZ_32 MMU_RAM_ELSZ_32 -#define IOVMF_ELSZ_NONE MMU_RAM_ELSZ_NONE - -#define IOVMF_MIXED_MASK (1 << 6) -#define IOVMF_MIXED MMU_RAM_MIXED - -/* - * iovma: s/w flags, used for mapping and umapping internally. - */ -#define IOVMF_MMIO (1 << IOVMF_SW_SHIFT) -#define IOVMF_ALLOC (2 << IOVMF_SW_SHIFT) -#define IOVMF_ALLOC_MASK (3 << IOVMF_SW_SHIFT) - -/* "superpages" is supported just with physically linear pages */ -#define IOVMF_DISCONT (1 << (2 + IOVMF_SW_SHIFT)) -#define IOVMF_LINEAR (2 << (2 + IOVMF_SW_SHIFT)) -#define IOVMF_LINEAR_MASK (3 << (2 + IOVMF_SW_SHIFT)) - -#define IOVMF_DA_FIXED (1 << (4 + IOVMF_SW_SHIFT)) - - -extern struct iovm_struct *omap_find_iovm_area(struct device *dev, u32 da); -extern u32 -omap_iommu_vmap(struct iommu_domain *domain, struct device *dev, u32 da, - const struct sg_table *sgt, u32 flags); -extern struct sg_table *omap_iommu_vunmap(struct iommu_domain *domain, - struct device *dev, u32 da); -extern u32 -omap_iommu_vmalloc(struct iommu_domain *domain, struct device *dev, - u32 da, size_t bytes, u32 flags); -extern void -omap_iommu_vfree(struct iommu_domain *domain, struct device *dev, - const u32 da); -extern void *omap_da_to_va(struct device *dev, u32 da); - -#endif /* __IOMMU_MMAP_H */ diff --git a/drivers/iommu/omap-iommu-debug.c b/drivers/iommu/omap-iommu-debug.c index 0cac372..cf4a0b5 100644 --- a/drivers/iommu/omap-iommu-debug.c +++ b/drivers/iommu/omap-iommu-debug.c @@ -18,9 +18,9 @@ #include <linux/uaccess.h> #include <linux/platform_device.h> #include <linux/debugfs.h> +#include <linux/omap-iommu.h> #include <plat/iommu.h> -#include <plat/iovmm.h> #include "omap-iopgtable.h" diff --git a/drivers/iommu/omap-iommu.c b/drivers/iommu/omap-iommu.c index f2bbfb0..eadcfde 100644 --- a/drivers/iommu/omap-iommu.c +++ b/drivers/iommu/omap-iommu.c @@ -19,6 +19,7 @@ #include <linux/clk.h> #include <linux/platform_device.h> #include <linux/iommu.h> +#include <linux/omap-iommu.h> #include <linux/mutex.h> #include <linux/spinlock.h> diff --git a/drivers/iommu/omap-iovmm.c b/drivers/iommu/omap-iovmm.c index b332392..9852101 100644 --- a/drivers/iommu/omap-iovmm.c +++ b/drivers/iommu/omap-iovmm.c @@ -17,15 +17,59 @@ #include <linux/device.h> #include <linux/scatterlist.h> #include <linux/iommu.h> +#include <linux/omap-iommu.h> #include <asm/cacheflush.h> #include <asm/mach/map.h> #include <plat/iommu.h> -#include <plat/iovmm.h> #include "omap-iopgtable.h" +/* + * IOVMF_FLAGS: attribute for iommu virtual memory area(iovma) + * + * lower 16 bit is used for h/w and upper 16 bit is for s/w. + */ +#define IOVMF_SW_SHIFT 16 + +/* + * iovma: h/w flags derived from cam and ram attribute + */ +#define IOVMF_CAM_MASK (~((1 << 10) - 1)) +#define IOVMF_RAM_MASK (~IOVMF_CAM_MASK) + +#define IOVMF_PGSZ_MASK (3 << 0) +#define IOVMF_PGSZ_1M MMU_CAM_PGSZ_1M +#define IOVMF_PGSZ_64K MMU_CAM_PGSZ_64K +#define IOVMF_PGSZ_4K MMU_CAM_PGSZ_4K +#define IOVMF_PGSZ_16M MMU_CAM_PGSZ_16M + +#define IOVMF_ENDIAN_MASK (1 << 9) +#define IOVMF_ENDIAN_BIG MMU_RAM_ENDIAN_BIG + +#define IOVMF_ELSZ_MASK (3 << 7) +#define IOVMF_ELSZ_16 MMU_RAM_ELSZ_16 +#define IOVMF_ELSZ_32 MMU_RAM_ELSZ_32 +#define IOVMF_ELSZ_NONE MMU_RAM_ELSZ_NONE + +#define IOVMF_MIXED_MASK (1 << 6) +#define IOVMF_MIXED MMU_RAM_MIXED + +/* + * iovma: s/w flags, used for mapping and umapping internally. + */ +#define IOVMF_MMIO (1 << IOVMF_SW_SHIFT) +#define IOVMF_ALLOC (2 << IOVMF_SW_SHIFT) +#define IOVMF_ALLOC_MASK (3 << IOVMF_SW_SHIFT) + +/* "superpages" is supported just with physically linear pages */ +#define IOVMF_DISCONT (1 << (2 + IOVMF_SW_SHIFT)) +#define IOVMF_LINEAR (2 << (2 + IOVMF_SW_SHIFT)) +#define IOVMF_LINEAR_MASK (3 << (2 + IOVMF_SW_SHIFT)) + +#define IOVMF_DA_FIXED (1 << (4 + IOVMF_SW_SHIFT)) + static struct kmem_cache *iovm_area_cachep; /* return the offset of the first scatterlist entry in a sg table */ diff --git a/drivers/media/platform/omap3isp/isp.c b/drivers/media/platform/omap3isp/isp.c index 99640d8..d72bd38 100644 --- a/drivers/media/platform/omap3isp/isp.c +++ b/drivers/media/platform/omap3isp/isp.c @@ -66,6 +66,7 @@ #include <linux/slab.h> #include <linux/sched.h> #include <linux/vmalloc.h> +#include <linux/omap-iommu.h> #include <media/v4l2-common.h> #include <media/v4l2-device.h> diff --git a/drivers/media/platform/omap3isp/isp.h b/drivers/media/platform/omap3isp/isp.h index 8be7487..50be8c2 100644 --- a/drivers/media/platform/omap3isp/isp.h +++ b/drivers/media/platform/omap3isp/isp.h @@ -34,8 +34,6 @@ #include <linux/platform_device.h> #include <linux/wait.h> #include <linux/iommu.h> -#include <plat/iommu.h> -#include <plat/iovmm.h> #include "ispstat.h" #include "ispccdc.h" diff --git a/drivers/media/platform/omap3isp/ispccdc.c b/drivers/media/platform/omap3isp/ispccdc.c index 60181ab..b2d4976 100644 --- a/drivers/media/platform/omap3isp/ispccdc.c +++ b/drivers/media/platform/omap3isp/ispccdc.c @@ -32,6 +32,7 @@ #include <linux/mm.h> #include <linux/sched.h> #include <linux/slab.h> +#include <linux/omap-iommu.h> #include <media/v4l2-event.h> #include "isp.h" diff --git a/drivers/media/platform/omap3isp/ispstat.c b/drivers/media/platform/omap3isp/ispstat.c index d7ac76b..e135774 100644 --- a/drivers/media/platform/omap3isp/ispstat.c +++ b/drivers/media/platform/omap3isp/ispstat.c @@ -28,6 +28,7 @@ #include <linux/dma-mapping.h> #include <linux/slab.h> #include <linux/uaccess.h> +#include <linux/omap-iommu.h> #include "isp.h" diff --git a/drivers/media/platform/omap3isp/ispvideo.c b/drivers/media/platform/omap3isp/ispvideo.c index a0b737fe..2853bef 100644 --- a/drivers/media/platform/omap3isp/ispvideo.c +++ b/drivers/media/platform/omap3isp/ispvideo.c @@ -32,10 +32,10 @@ #include <linux/sched.h> #include <linux/slab.h> #include <linux/vmalloc.h> +#include <linux/omap-iommu.h> #include <media/v4l2-dev.h> #include <media/v4l2-ioctl.h> #include <plat/iommu.h> -#include <plat/iovmm.h> #include <plat/omap-pm.h> #include "ispvideo.h" diff --git a/include/linux/omap-iommu.h b/include/linux/omap-iommu.h new file mode 100644 index 0000000..bd12665 --- /dev/null +++ b/include/linux/omap-iommu.h @@ -0,0 +1,47 @@ +/* + * omap iommu: simple virtual address space management + * + * Copyright (C) 2008-2009 Nokia Corporation + * + * Written by Hiroshi DOYU <Hiroshi.DOYU@nokia.com> + * + * This program is free software; you can redistribute it and/or modify + * it under the terms of the GNU General Public License version 2 as + * published by the Free Software Foundation. + */ + +struct iovm_struct { + struct omap_iommu *iommu; /* iommu object which this belongs to */ + u32 da_start; /* area definition */ + u32 da_end; + u32 flags; /* IOVMF_: see below */ + struct list_head list; /* linked in ascending order */ + const struct sg_table *sgt; /* keep 'page' <-> 'da' mapping */ + void *va; /* mpu side mapped address */ +}; + +#define MMU_RAM_ENDIAN_SHIFT 9 +#define MMU_RAM_ENDIAN_LITTLE (0 << MMU_RAM_ENDIAN_SHIFT) +#define MMU_RAM_ELSZ_8 (0 << MMU_RAM_ELSZ_SHIFT) +#define IOVMF_ENDIAN_LITTLE MMU_RAM_ENDIAN_LITTLE +#define MMU_RAM_ELSZ_SHIFT 7 +#define IOVMF_ELSZ_8 MMU_RAM_ELSZ_8 + +struct iommu_domain; + +extern struct iovm_struct *omap_find_iovm_area(struct device *dev, u32 da); +extern u32 +omap_iommu_vmap(struct iommu_domain *domain, struct device *dev, u32 da, + const struct sg_table *sgt, u32 flags); +extern struct sg_table *omap_iommu_vunmap(struct iommu_domain *domain, + struct device *dev, u32 da); +extern u32 +omap_iommu_vmalloc(struct iommu_domain *domain, struct device *dev, + u32 da, size_t bytes, u32 flags); +extern void +omap_iommu_vfree(struct iommu_domain *domain, struct device *dev, + const u32 da); +extern void *omap_da_to_va(struct device *dev, u32 da); + +extern void omap_iommu_save_ctx(struct device *dev); +extern void omap_iommu_restore_ctx(struct device *dev); ^ permalink raw reply related [flat|nested] 21+ messages in thread
* Re: [PATCH 3/6] ARM: OMAP2+: Move plat/iovmm.h to include/linux/omap-iommu.h 2012-10-18 20:28 ` [PATCH 3/6] ARM: OMAP2+: Move plat/iovmm.h to include/linux/omap-iommu.h Tony Lindgren @ 2012-10-18 20:56 ` Mauro Carvalho Chehab 2012-10-18 22:11 ` Tony Lindgren 2012-10-19 9:40 ` Laurent Pinchart 1 sibling, 1 reply; 21+ messages in thread From: Mauro Carvalho Chehab @ 2012-10-18 20:56 UTC (permalink / raw) To: Tony Lindgren Cc: linux-arm-kernel, Ohad Ben-Cohen, Joerg Roedel, Laurent Pinchart, Omar Ramirez Luna, linux-omap, Ido Yariv, linux-media, mchehab Tony, Em Thu, 18 Oct 2012 13:28:42 -0700 Tony Lindgren <tony@atomide.com> escreveu: > Looks like the iommu framework does not have generic functions > exported for all the needs yet. The hardware specific functions > are defined in files like intel-iommu.h and amd-iommu.h. Follow > the same standard for omap-iommu.h. > > This is needed because we are removing plat and mach includes > for ARM common zImage support. Further work should continue > in the iommu framework context as only pure platform data will > be communicated from arch/arm/*omap*/* code to the iommu > framework. > > Cc: Joerg Roedel <joerg.roedel@amd.com> > Cc: Ohad Ben-Cohen <ohad@wizery.com> > Cc: Ido Yariv <ido@wizery.com> > Cc: Laurent Pinchart <laurent.pinchart@ideasonboard.com> > Cc: Mauro Carvalho Chehab <mchehab@infradead.org> > Cc: Omar Ramirez Luna <omar.luna@linaro.org> > Cc: linux-media@vger.kernel.org > Signed-off-by: Tony Lindgren <tony@atomide.com> > --- > arch/arm/mach-omap2/iommu2.c | 1 > arch/arm/plat-omap/include/plat/iommu.h | 10 +-- > arch/arm/plat-omap/include/plat/iovmm.h | 89 ---------------------------- > drivers/iommu/omap-iommu-debug.c | 2 - > drivers/iommu/omap-iommu.c | 1 > drivers/iommu/omap-iovmm.c | 46 ++++++++++++++ > drivers/media/platform/omap3isp/isp.c | 1 > drivers/media/platform/omap3isp/isp.h | 2 - > drivers/media/platform/omap3isp/ispccdc.c | 1 > drivers/media/platform/omap3isp/ispstat.c | 1 > drivers/media/platform/omap3isp/ispvideo.c | 2 - Acked-by: Mauro Carvalho Chehab <mchehab@redhat.com> It is better if you send this entire series through the ARM tree, keeping this hole series altogether (and avoiding the risk of breaking bisectability if it goes through separate trees). So, you can add my ack for those header moves for drivers/media/platform/*. Regards, Mauro -- Cheers, Mauro ^ permalink raw reply [flat|nested] 21+ messages in thread
* Re: [PATCH 3/6] ARM: OMAP2+: Move plat/iovmm.h to include/linux/omap-iommu.h 2012-10-18 20:56 ` Mauro Carvalho Chehab @ 2012-10-18 22:11 ` Tony Lindgren 0 siblings, 0 replies; 21+ messages in thread From: Tony Lindgren @ 2012-10-18 22:11 UTC (permalink / raw) To: Mauro Carvalho Chehab Cc: linux-arm-kernel, Ohad Ben-Cohen, Joerg Roedel, Laurent Pinchart, Omar Ramirez Luna, linux-omap, Ido Yariv, linux-media, mchehab * Mauro Carvalho Chehab <mchehab@redhat.com> [121018 13:58]: > Tony, > > Em Thu, 18 Oct 2012 13:28:42 -0700 > Tony Lindgren <tony@atomide.com> escreveu: > > > Looks like the iommu framework does not have generic functions > > exported for all the needs yet. The hardware specific functions > > are defined in files like intel-iommu.h and amd-iommu.h. Follow > > the same standard for omap-iommu.h. > > > > This is needed because we are removing plat and mach includes > > for ARM common zImage support. Further work should continue > > in the iommu framework context as only pure platform data will > > be communicated from arch/arm/*omap*/* code to the iommu > > framework. > > > > Cc: Joerg Roedel <joerg.roedel@amd.com> > > Cc: Ohad Ben-Cohen <ohad@wizery.com> > > Cc: Ido Yariv <ido@wizery.com> > > Cc: Laurent Pinchart <laurent.pinchart@ideasonboard.com> > > Cc: Mauro Carvalho Chehab <mchehab@infradead.org> > > Cc: Omar Ramirez Luna <omar.luna@linaro.org> > > Cc: linux-media@vger.kernel.org > > Signed-off-by: Tony Lindgren <tony@atomide.com> > > --- > > arch/arm/mach-omap2/iommu2.c | 1 > > arch/arm/plat-omap/include/plat/iommu.h | 10 +-- > > arch/arm/plat-omap/include/plat/iovmm.h | 89 ---------------------------- > > drivers/iommu/omap-iommu-debug.c | 2 - > > drivers/iommu/omap-iommu.c | 1 > > drivers/iommu/omap-iovmm.c | 46 ++++++++++++++ > > drivers/media/platform/omap3isp/isp.c | 1 > > drivers/media/platform/omap3isp/isp.h | 2 - > > drivers/media/platform/omap3isp/ispccdc.c | 1 > > drivers/media/platform/omap3isp/ispstat.c | 1 > > drivers/media/platform/omap3isp/ispvideo.c | 2 - > > Acked-by: Mauro Carvalho Chehab <mchehab@redhat.com> > > It is better if you send this entire series through the ARM tree, keeping > this hole series altogether (and avoiding the risk of breaking bisectability > if it goes through separate trees). So, you can add my ack for those header > moves for drivers/media/platform/*. Yes thanks. Once people are happy with these, I will push just these patches on v3.7-rc1 alone into omap-for-v3.8/cleanup-headers-iommu so both media and iommu tree can merge them in too as needed. Regards, Tony ^ permalink raw reply [flat|nested] 21+ messages in thread
* Re: [PATCH 3/6] ARM: OMAP2+: Move plat/iovmm.h to include/linux/omap-iommu.h 2012-10-18 20:28 ` [PATCH 3/6] ARM: OMAP2+: Move plat/iovmm.h to include/linux/omap-iommu.h Tony Lindgren 2012-10-18 20:56 ` Mauro Carvalho Chehab @ 2012-10-19 9:40 ` Laurent Pinchart 2012-10-19 16:14 ` Tony Lindgren 2012-10-24 22:34 ` Tony Lindgren 1 sibling, 2 replies; 21+ messages in thread From: Laurent Pinchart @ 2012-10-19 9:40 UTC (permalink / raw) To: Tony Lindgren Cc: linux-arm-kernel, Ohad Ben-Cohen, Joerg Roedel, Mauro Carvalho Chehab, Omar Ramirez Luna, linux-omap, Ido Yariv, linux-media Hi Tony, Thanks for the patch. On Thursday 18 October 2012 13:28:42 Tony Lindgren wrote: > Looks like the iommu framework does not have generic functions > exported for all the needs yet. The hardware specific functions > are defined in files like intel-iommu.h and amd-iommu.h. Follow > the same standard for omap-iommu.h. > > This is needed because we are removing plat and mach includes > for ARM common zImage support. Further work should continue > in the iommu framework context as only pure platform data will > be communicated from arch/arm/*omap*/* code to the iommu > framework. > > Cc: Joerg Roedel <joerg.roedel@amd.com> > Cc: Ohad Ben-Cohen <ohad@wizery.com> > Cc: Ido Yariv <ido@wizery.com> > Cc: Laurent Pinchart <laurent.pinchart@ideasonboard.com> > Cc: Mauro Carvalho Chehab <mchehab@infradead.org> > Cc: Omar Ramirez Luna <omar.luna@linaro.org> > Cc: linux-media@vger.kernel.org > Signed-off-by: Tony Lindgren <tony@atomide.com> > --- > arch/arm/mach-omap2/iommu2.c | 1 > arch/arm/plat-omap/include/plat/iommu.h | 10 +-- > arch/arm/plat-omap/include/plat/iovmm.h | 89 ------------------------- > drivers/iommu/omap-iommu-debug.c | 2 - > drivers/iommu/omap-iommu.c | 1 > drivers/iommu/omap-iovmm.c | 46 ++++++++++++++ > drivers/media/platform/omap3isp/isp.c | 1 > drivers/media/platform/omap3isp/isp.h | 2 - > drivers/media/platform/omap3isp/ispccdc.c | 1 > drivers/media/platform/omap3isp/ispstat.c | 1 > drivers/media/platform/omap3isp/ispvideo.c | 2 - > include/linux/omap-iommu.h | 47 +++++++++++++++ > 12 files changed, 101 insertions(+), 102 deletions(-) > delete mode 100644 arch/arm/plat-omap/include/plat/iovmm.h > create mode 100644 include/linux/omap-iommu.h > > diff --git a/arch/arm/mach-omap2/iommu2.c b/arch/arm/mach-omap2/iommu2.c > index eefc379..77cbf2f 100644 > --- a/arch/arm/mach-omap2/iommu2.c > +++ b/arch/arm/mach-omap2/iommu2.c > @@ -17,6 +17,7 @@ > #include <linux/module.h> > #include <linux/slab.h> > #include <linux/stringify.h> > +#include <linux/omap-iommu.h> Nitpicking, please keep the headers sorted alphabetically, here and in all locations below (especially the OMAP3 ISP driver). (OK, there's already one misplaced #include, but let's not make it worse :-)) > #include <plat/iommu.h> > > diff --git a/arch/arm/plat-omap/include/plat/iommu.h > b/arch/arm/plat-omap/include/plat/iommu.h index 7e8c7b6..a4b71b1 100644 > --- a/arch/arm/plat-omap/include/plat/iommu.h > +++ b/arch/arm/plat-omap/include/plat/iommu.h > @@ -216,13 +216,10 @@ static inline struct omap_iommu > *dev_to_omap_iommu(struct device *dev) #define MMU_RAM_PADDR_SHIFT 12 > #define MMU_RAM_PADDR_MASK \ > ((~0UL >> MMU_RAM_PADDR_SHIFT) << MMU_RAM_PADDR_SHIFT) > -#define MMU_RAM_ENDIAN_SHIFT 9 > + > #define MMU_RAM_ENDIAN_MASK (1 << MMU_RAM_ENDIAN_SHIFT) > -#define MMU_RAM_ENDIAN_BIG (1 << MMU_RAM_ENDIAN_SHIFT) > -#define MMU_RAM_ENDIAN_LITTLE (0 << MMU_RAM_ENDIAN_SHIFT) > -#define MMU_RAM_ELSZ_SHIFT 7 > #define MMU_RAM_ELSZ_MASK (3 << MMU_RAM_ELSZ_SHIFT) > -#define MMU_RAM_ELSZ_8 (0 << MMU_RAM_ELSZ_SHIFT) > + > #define MMU_RAM_ELSZ_16 (1 << MMU_RAM_ELSZ_SHIFT) > #define MMU_RAM_ELSZ_32 (2 << MMU_RAM_ELSZ_SHIFT) > #define MMU_RAM_ELSZ_NONE (3 << MMU_RAM_ELSZ_SHIFT) I plan to push cleanup patches for the staging tidspbridge driver that get rid of the local register definitions and use plat/iommu.h instead. That's obviously an interim solution as in the long run the driver should use the IOMMU API, but in the meantime it's a step in the right direction. Would it then make sense to move all those definitions to include/linux/omap-iommu.h, not just the ones used by the OMAP3 ISP driver ? > @@ -269,9 +266,6 @@ extern int omap_iommu_set_isr(const char *name, > void *priv), > void *isr_priv); > > -extern void omap_iommu_save_ctx(struct device *dev); > -extern void omap_iommu_restore_ctx(struct device *dev); > - > extern int omap_install_iommu_arch(const struct iommu_functions *ops); > extern void omap_uninstall_iommu_arch(const struct iommu_functions *ops); > > diff --git a/arch/arm/plat-omap/include/plat/iovmm.h > b/arch/arm/plat-omap/include/plat/iovmm.h deleted file mode 100644 > index 498e57c..0000000 > --- a/arch/arm/plat-omap/include/plat/iovmm.h > +++ /dev/null > @@ -1,89 +0,0 @@ > -/* > - * omap iommu: simple virtual address space management > - * > - * Copyright (C) 2008-2009 Nokia Corporation > - * > - * Written by Hiroshi DOYU <Hiroshi.DOYU@nokia.com> > - * > - * This program is free software; you can redistribute it and/or modify > - * it under the terms of the GNU General Public License version 2 as > - * published by the Free Software Foundation. > - */ > - > -#ifndef __IOMMU_MMAP_H > -#define __IOMMU_MMAP_H > - > -#include <linux/iommu.h> > - > -struct iovm_struct { > - struct omap_iommu *iommu; /* iommu object which this belongs to */ > - u32 da_start; /* area definition */ > - u32 da_end; > - u32 flags; /* IOVMF_: see below */ > - struct list_head list; /* linked in ascending order */ > - const struct sg_table *sgt; /* keep 'page' <-> 'da' mapping */ > - void *va; /* mpu side mapped address */ > -}; > - > -/* > - * IOVMF_FLAGS: attribute for iommu virtual memory area(iovma) > - * > - * lower 16 bit is used for h/w and upper 16 bit is for s/w. > - */ > -#define IOVMF_SW_SHIFT 16 > - > -/* > - * iovma: h/w flags derived from cam and ram attribute > - */ > -#define IOVMF_CAM_MASK (~((1 << 10) - 1)) > -#define IOVMF_RAM_MASK (~IOVMF_CAM_MASK) > - > -#define IOVMF_PGSZ_MASK (3 << 0) > -#define IOVMF_PGSZ_1M MMU_CAM_PGSZ_1M > -#define IOVMF_PGSZ_64K MMU_CAM_PGSZ_64K > -#define IOVMF_PGSZ_4K MMU_CAM_PGSZ_4K > -#define IOVMF_PGSZ_16M MMU_CAM_PGSZ_16M > - > -#define IOVMF_ENDIAN_MASK (1 << 9) > -#define IOVMF_ENDIAN_BIG MMU_RAM_ENDIAN_BIG > -#define IOVMF_ENDIAN_LITTLE MMU_RAM_ENDIAN_LITTLE > - > -#define IOVMF_ELSZ_MASK (3 << 7) > -#define IOVMF_ELSZ_8 MMU_RAM_ELSZ_8 > -#define IOVMF_ELSZ_16 MMU_RAM_ELSZ_16 > -#define IOVMF_ELSZ_32 MMU_RAM_ELSZ_32 > -#define IOVMF_ELSZ_NONE MMU_RAM_ELSZ_NONE > - > -#define IOVMF_MIXED_MASK (1 << 6) > -#define IOVMF_MIXED MMU_RAM_MIXED > - > -/* > - * iovma: s/w flags, used for mapping and umapping internally. > - */ > -#define IOVMF_MMIO (1 << IOVMF_SW_SHIFT) > -#define IOVMF_ALLOC (2 << IOVMF_SW_SHIFT) > -#define IOVMF_ALLOC_MASK (3 << IOVMF_SW_SHIFT) > - > -/* "superpages" is supported just with physically linear pages */ > -#define IOVMF_DISCONT (1 << (2 + IOVMF_SW_SHIFT)) > -#define IOVMF_LINEAR (2 << (2 + IOVMF_SW_SHIFT)) > -#define IOVMF_LINEAR_MASK (3 << (2 + IOVMF_SW_SHIFT)) > - > -#define IOVMF_DA_FIXED (1 << (4 + IOVMF_SW_SHIFT)) > - > - > -extern struct iovm_struct *omap_find_iovm_area(struct device *dev, u32 da); > -extern u32 > -omap_iommu_vmap(struct iommu_domain *domain, struct device *dev, u32 da, > - const struct sg_table *sgt, u32 flags); > -extern struct sg_table *omap_iommu_vunmap(struct iommu_domain *domain, > - struct device *dev, u32 da); > -extern u32 > -omap_iommu_vmalloc(struct iommu_domain *domain, struct device *dev, > - u32 da, size_t bytes, u32 flags); > -extern void > -omap_iommu_vfree(struct iommu_domain *domain, struct device *dev, > - const u32 da); > -extern void *omap_da_to_va(struct device *dev, u32 da); > - > -#endif /* __IOMMU_MMAP_H */ > diff --git a/drivers/iommu/omap-iommu-debug.c > b/drivers/iommu/omap-iommu-debug.c index 0cac372..cf4a0b5 100644 > --- a/drivers/iommu/omap-iommu-debug.c > +++ b/drivers/iommu/omap-iommu-debug.c > @@ -18,9 +18,9 @@ > #include <linux/uaccess.h> > #include <linux/platform_device.h> > #include <linux/debugfs.h> > +#include <linux/omap-iommu.h> > > #include <plat/iommu.h> > -#include <plat/iovmm.h> > > #include "omap-iopgtable.h" > > diff --git a/drivers/iommu/omap-iommu.c b/drivers/iommu/omap-iommu.c > index f2bbfb0..eadcfde 100644 > --- a/drivers/iommu/omap-iommu.c > +++ b/drivers/iommu/omap-iommu.c > @@ -19,6 +19,7 @@ > #include <linux/clk.h> > #include <linux/platform_device.h> > #include <linux/iommu.h> > +#include <linux/omap-iommu.h> > #include <linux/mutex.h> > #include <linux/spinlock.h> > > diff --git a/drivers/iommu/omap-iovmm.c b/drivers/iommu/omap-iovmm.c > index b332392..9852101 100644 > --- a/drivers/iommu/omap-iovmm.c > +++ b/drivers/iommu/omap-iovmm.c > @@ -17,15 +17,59 @@ > #include <linux/device.h> > #include <linux/scatterlist.h> > #include <linux/iommu.h> > +#include <linux/omap-iommu.h> > > #include <asm/cacheflush.h> > #include <asm/mach/map.h> > > #include <plat/iommu.h> > -#include <plat/iovmm.h> > > #include "omap-iopgtable.h" > > +/* > + * IOVMF_FLAGS: attribute for iommu virtual memory area(iovma) > + * > + * lower 16 bit is used for h/w and upper 16 bit is for s/w. > + */ > +#define IOVMF_SW_SHIFT 16 > + > +/* > + * iovma: h/w flags derived from cam and ram attribute > + */ > +#define IOVMF_CAM_MASK (~((1 << 10) - 1)) > +#define IOVMF_RAM_MASK (~IOVMF_CAM_MASK) > + > +#define IOVMF_PGSZ_MASK (3 << 0) > +#define IOVMF_PGSZ_1M MMU_CAM_PGSZ_1M > +#define IOVMF_PGSZ_64K MMU_CAM_PGSZ_64K > +#define IOVMF_PGSZ_4K MMU_CAM_PGSZ_4K > +#define IOVMF_PGSZ_16M MMU_CAM_PGSZ_16M > + > +#define IOVMF_ENDIAN_MASK (1 << 9) > +#define IOVMF_ENDIAN_BIG MMU_RAM_ENDIAN_BIG > + > +#define IOVMF_ELSZ_MASK (3 << 7) > +#define IOVMF_ELSZ_16 MMU_RAM_ELSZ_16 > +#define IOVMF_ELSZ_32 MMU_RAM_ELSZ_32 > +#define IOVMF_ELSZ_NONE MMU_RAM_ELSZ_NONE > + > +#define IOVMF_MIXED_MASK (1 << 6) > +#define IOVMF_MIXED MMU_RAM_MIXED > + > +/* > + * iovma: s/w flags, used for mapping and umapping internally. > + */ > +#define IOVMF_MMIO (1 << IOVMF_SW_SHIFT) > +#define IOVMF_ALLOC (2 << IOVMF_SW_SHIFT) > +#define IOVMF_ALLOC_MASK (3 << IOVMF_SW_SHIFT) > + > +/* "superpages" is supported just with physically linear pages */ > +#define IOVMF_DISCONT (1 << (2 + IOVMF_SW_SHIFT)) > +#define IOVMF_LINEAR (2 << (2 + IOVMF_SW_SHIFT)) > +#define IOVMF_LINEAR_MASK (3 << (2 + IOVMF_SW_SHIFT)) > + > +#define IOVMF_DA_FIXED (1 << (4 + IOVMF_SW_SHIFT)) > + > static struct kmem_cache *iovm_area_cachep; > > /* return the offset of the first scatterlist entry in a sg table */ > diff --git a/drivers/media/platform/omap3isp/isp.c > b/drivers/media/platform/omap3isp/isp.c index 99640d8..d72bd38 100644 > --- a/drivers/media/platform/omap3isp/isp.c > +++ b/drivers/media/platform/omap3isp/isp.c > @@ -66,6 +66,7 @@ > #include <linux/slab.h> > #include <linux/sched.h> > #include <linux/vmalloc.h> > +#include <linux/omap-iommu.h> > > #include <media/v4l2-common.h> > #include <media/v4l2-device.h> > diff --git a/drivers/media/platform/omap3isp/isp.h > b/drivers/media/platform/omap3isp/isp.h index 8be7487..50be8c2 100644 > --- a/drivers/media/platform/omap3isp/isp.h > +++ b/drivers/media/platform/omap3isp/isp.h > @@ -34,8 +34,6 @@ > #include <linux/platform_device.h> > #include <linux/wait.h> > #include <linux/iommu.h> > -#include <plat/iommu.h> > -#include <plat/iovmm.h> > > #include "ispstat.h" > #include "ispccdc.h" > diff --git a/drivers/media/platform/omap3isp/ispccdc.c > b/drivers/media/platform/omap3isp/ispccdc.c index 60181ab..b2d4976 100644 > --- a/drivers/media/platform/omap3isp/ispccdc.c > +++ b/drivers/media/platform/omap3isp/ispccdc.c > @@ -32,6 +32,7 @@ > #include <linux/mm.h> > #include <linux/sched.h> > #include <linux/slab.h> > +#include <linux/omap-iommu.h> > #include <media/v4l2-event.h> > > #include "isp.h" > diff --git a/drivers/media/platform/omap3isp/ispstat.c > b/drivers/media/platform/omap3isp/ispstat.c index d7ac76b..e135774 100644 > --- a/drivers/media/platform/omap3isp/ispstat.c > +++ b/drivers/media/platform/omap3isp/ispstat.c > @@ -28,6 +28,7 @@ > #include <linux/dma-mapping.h> > #include <linux/slab.h> > #include <linux/uaccess.h> > +#include <linux/omap-iommu.h> > > #include "isp.h" > > diff --git a/drivers/media/platform/omap3isp/ispvideo.c > b/drivers/media/platform/omap3isp/ispvideo.c index a0b737fe..2853bef 100644 > --- a/drivers/media/platform/omap3isp/ispvideo.c > +++ b/drivers/media/platform/omap3isp/ispvideo.c > @@ -32,10 +32,10 @@ > #include <linux/sched.h> > #include <linux/slab.h> > #include <linux/vmalloc.h> > +#include <linux/omap-iommu.h> > #include <media/v4l2-dev.h> > #include <media/v4l2-ioctl.h> > #include <plat/iommu.h> > -#include <plat/iovmm.h> > #include <plat/omap-pm.h> > > #include "ispvideo.h" > diff --git a/include/linux/omap-iommu.h b/include/linux/omap-iommu.h > new file mode 100644 > index 0000000..bd12665 > --- /dev/null > +++ b/include/linux/omap-iommu.h > @@ -0,0 +1,47 @@ > +/* > + * omap iommu: simple virtual address space management > + * > + * Copyright (C) 2008-2009 Nokia Corporation > + * > + * Written by Hiroshi DOYU <Hiroshi.DOYU@nokia.com> > + * > + * This program is free software; you can redistribute it and/or modify > + * it under the terms of the GNU General Public License version 2 as > + * published by the Free Software Foundation. > + */ Missing #ifndef #define ... #endif > + > +struct iovm_struct { > + struct omap_iommu *iommu; /* iommu object which this belongs to */ > + u32 da_start; /* area definition */ > + u32 da_end; > + u32 flags; /* IOVMF_: see below */ > + struct list_head list; /* linked in ascending order */ > + const struct sg_table *sgt; /* keep 'page' <-> 'da' mapping */ > + void *va; /* mpu side mapped address */ > +}; > + > +#define MMU_RAM_ENDIAN_SHIFT 9 > +#define MMU_RAM_ENDIAN_LITTLE (0 << MMU_RAM_ENDIAN_SHIFT) > +#define MMU_RAM_ELSZ_8 (0 << MMU_RAM_ELSZ_SHIFT) > +#define IOVMF_ENDIAN_LITTLE MMU_RAM_ENDIAN_LITTLE > +#define MMU_RAM_ELSZ_SHIFT 7 > +#define IOVMF_ELSZ_8 MMU_RAM_ELSZ_8 Shouldn't this header be split in include/linux/omap-iommu.h and include/linux/omap-iovmm.h ? I would also move all the hardware IOVMF flags to include/linux/omap-iovmm.h, not just the two currently used by the OMAP3 ISP driver. The software flags can be kept in drivers/iommu/omap-iovmm.c. > +struct iommu_domain; > + > +extern struct iovm_struct *omap_find_iovm_area(struct device *dev, u32 da); > +extern u32 > +omap_iommu_vmap(struct iommu_domain *domain, struct device *dev, u32 da, > + const struct sg_table *sgt, u32 flags); > +extern struct sg_table *omap_iommu_vunmap(struct iommu_domain *domain, > + struct device *dev, u32 da); > +extern u32 > +omap_iommu_vmalloc(struct iommu_domain *domain, struct device *dev, > + u32 da, size_t bytes, u32 flags); > +extern void > +omap_iommu_vfree(struct iommu_domain *domain, struct device *dev, > + const u32 da); > +extern void *omap_da_to_va(struct device *dev, u32 da); > + > +extern void omap_iommu_save_ctx(struct device *dev); > +extern void omap_iommu_restore_ctx(struct device *dev); Do we really need to prefix functions with 'extern' ? -- Regards, Laurent Pinchart ^ permalink raw reply [flat|nested] 21+ messages in thread
* Re: [PATCH 3/6] ARM: OMAP2+: Move plat/iovmm.h to include/linux/omap-iommu.h 2012-10-19 9:40 ` Laurent Pinchart @ 2012-10-19 16:14 ` Tony Lindgren 2012-10-24 22:34 ` Tony Lindgren 1 sibling, 0 replies; 21+ messages in thread From: Tony Lindgren @ 2012-10-19 16:14 UTC (permalink / raw) To: Laurent Pinchart Cc: linux-arm-kernel, Ohad Ben-Cohen, Joerg Roedel, Mauro Carvalho Chehab, Omar Ramirez Luna, linux-omap, Ido Yariv, linux-media * Laurent Pinchart <laurent.pinchart@ideasonboard.com> [121019 02:41]: > > Nitpicking, please keep the headers sorted alphabetically, here and in all > locations below (especially the OMAP3 ISP driver). > > (OK, there's already one misplaced #include, but let's not make it worse :-)) Sure I'll check that. > I plan to push cleanup patches for the staging tidspbridge driver that get rid > of the local register definitions and use plat/iommu.h instead. That's > obviously an interim solution as in the long run the driver should use the > IOMMU API, but in the meantime it's a step in the right direction. Would it > then make sense to move all those definitions to include/linux/omap-iommu.h, > not just the ones used by the OMAP3 ISP driver ? Well these patches are just intended to fix the platform data interface between core ARM code and iommu. At this point I really don't want to get involved in the iommu framework. What you are asking should be coordinated with Joerg and Ohad. Ideally the iommu framework would provide the API to the drivers to use, and there would not be any need to have include/linux/omap-iommu.h. If you ask me, I would just rip out the code that's not following the iommu API immediately and have it resubmitted in a sane way :) > Shouldn't this header be split in include/linux/omap-iommu.h and > include/linux/omap-iovmm.h ? I would also move all the hardware IOVMF flags to > include/linux/omap-iovmm.h, not just the two currently used by the OMAP3 ISP > driver. The software flags can be kept in drivers/iommu/omap-iovmm.c. I just fixed up things to follow what's being done with the iommu framework currently. Probably keeping only omap-iommu.h available is the best way to go until the iommu framework provides the interfaces, but again that's up to Joerg and Ohad. > > +extern void omap_iommu_save_ctx(struct device *dev); > > +extern void omap_iommu_restore_ctx(struct device *dev); > > Do we really need to prefix functions with 'extern' ? Yes since they are exported, I just moved them. Again, this is something that should be handled eventually via the iommu framework using runtime PM and not be exported at all. Again, I would just rip out that code if you ask me and replace it with comments until fixed. Regards, Tony ^ permalink raw reply [flat|nested] 21+ messages in thread
* Re: [PATCH 3/6] ARM: OMAP2+: Move plat/iovmm.h to include/linux/omap-iommu.h 2012-10-19 9:40 ` Laurent Pinchart 2012-10-19 16:14 ` Tony Lindgren @ 2012-10-24 22:34 ` Tony Lindgren 2012-10-24 23:53 ` Laurent Pinchart 1 sibling, 1 reply; 21+ messages in thread From: Tony Lindgren @ 2012-10-24 22:34 UTC (permalink / raw) To: Laurent Pinchart Cc: linux-arm-kernel, Ohad Ben-Cohen, Joerg Roedel, Mauro Carvalho Chehab, Omar Ramirez Luna, linux-omap, Ido Yariv, linux-media * Laurent Pinchart <laurent.pinchart@ideasonboard.com> [121019 02:41]: > On Thursday 18 October 2012 13:28:42 Tony Lindgren wrote: > > --- a/arch/arm/mach-omap2/iommu2.c > > +++ b/arch/arm/mach-omap2/iommu2.c > > @@ -17,6 +17,7 @@ > > #include <linux/module.h> > > #include <linux/slab.h> > > #include <linux/stringify.h> > > +#include <linux/omap-iommu.h> > > Nitpicking, please keep the headers sorted alphabetically, here and in all > locations below (especially the OMAP3 ISP driver). > > (OK, there's already one misplaced #include, but let's not make it worse :-)) This is fixed now. > > --- /dev/null > > +++ b/include/linux/omap-iommu.h > > @@ -0,0 +1,47 @@ > > +/* > > + * omap iommu: simple virtual address space management > > + * > > + * Copyright (C) 2008-2009 Nokia Corporation > > + * > > + * Written by Hiroshi DOYU <Hiroshi.DOYU@nokia.com> > > + * > > + * This program is free software; you can redistribute it and/or modify > > + * it under the terms of the GNU General Public License version 2 as > > + * published by the Free Software Foundation. > > + */ > > Missing #ifndef #define ... #endif I've added it as _OMAP_IOMMU_H_, looks like both intel-iommu.h and amd-iommu.h have it. Hopefully that's OK for you as a base to do further iommu patches on, updated patch below. BTW, doing a test compile on v3.7-rc2, I'm seeing the following warnings for omap3isp for isp_video_ioctl_ops: drivers/media/platform/omap3isp/ispvideo.c:1213: warning: initialization from incompatible pointer type drivers/media/platform/omap3isp/ispccdc.c:2303: warning: initialization from incompatible pointer type drivers/media/platform/omap3isp/ispccdc.c:2304: warning: initialization from incompatible pointer type drivers/media/platform/omap3isp/isph3a_aewb.c:282: warning: initialization from incompatible pointer type drivers/media/platform/omap3isp/isph3a_aewb.c:283: warning: initialization from incompatible pointer type drivers/media/platform/omap3isp/isph3a_af.c:347: warning: initialization from incompatible pointer type drivers/media/platform/omap3isp/isph3a_af.c:348: warning: initialization from incompatible pointer type drivers/media/platform/omap3isp/isphist.c:453: warning: initialization from incompatible pointer type drivers/media/platform/omap3isp/isphist.c:454: warning: initialization from incompatible pointer type Regards, Tony From: Tony Lindgren <tony@atomide.com> Date: Thu, 18 Oct 2012 11:03:16 -0700 Subject: [PATCH] ARM: OMAP2+: Move plat/iovmm.h to include/linux/omap-iommu.h Looks like the iommu framework does not have generic functions exported for all the needs yet. The hardware specific functions are defined in files like intel-iommu.h and amd-iommu.h. Follow the same standard for omap-iommu.h. This is needed because we are removing plat and mach includes for ARM common zImage support. Further work should continue in the iommu framework context as only pure platform data will be communicated from arch/arm/*omap*/* code to the iommu framework. Cc: Joerg Roedel <joerg.roedel@amd.com> Cc: Ohad Ben-Cohen <ohad@wizery.com> Cc: Ido Yariv <ido@wizery.com> Cc: Laurent Pinchart <laurent.pinchart@ideasonboard.com> Cc: Mauro Carvalho Chehab <mchehab@infradead.org> Cc: Omar Ramirez Luna <omar.luna@linaro.org> Cc: linux-media@vger.kernel.org Signed-off-by: Tony Lindgren <tony@atomide.com> diff --git a/arch/arm/mach-omap2/iommu2.c b/arch/arm/mach-omap2/iommu2.c index eefc379..e8116cf 100644 --- a/arch/arm/mach-omap2/iommu2.c +++ b/arch/arm/mach-omap2/iommu2.c @@ -15,6 +15,7 @@ #include <linux/device.h> #include <linux/jiffies.h> #include <linux/module.h> +#include <linux/omap-iommu.h> #include <linux/slab.h> #include <linux/stringify.h> diff --git a/arch/arm/plat-omap/include/plat/iommu.h b/arch/arm/plat-omap/include/plat/iommu.h index 7e8c7b6..a4b71b1 100644 --- a/arch/arm/plat-omap/include/plat/iommu.h +++ b/arch/arm/plat-omap/include/plat/iommu.h @@ -216,13 +216,10 @@ static inline struct omap_iommu *dev_to_omap_iommu(struct device *dev) #define MMU_RAM_PADDR_SHIFT 12 #define MMU_RAM_PADDR_MASK \ ((~0UL >> MMU_RAM_PADDR_SHIFT) << MMU_RAM_PADDR_SHIFT) -#define MMU_RAM_ENDIAN_SHIFT 9 + #define MMU_RAM_ENDIAN_MASK (1 << MMU_RAM_ENDIAN_SHIFT) -#define MMU_RAM_ENDIAN_BIG (1 << MMU_RAM_ENDIAN_SHIFT) -#define MMU_RAM_ENDIAN_LITTLE (0 << MMU_RAM_ENDIAN_SHIFT) -#define MMU_RAM_ELSZ_SHIFT 7 #define MMU_RAM_ELSZ_MASK (3 << MMU_RAM_ELSZ_SHIFT) -#define MMU_RAM_ELSZ_8 (0 << MMU_RAM_ELSZ_SHIFT) + #define MMU_RAM_ELSZ_16 (1 << MMU_RAM_ELSZ_SHIFT) #define MMU_RAM_ELSZ_32 (2 << MMU_RAM_ELSZ_SHIFT) #define MMU_RAM_ELSZ_NONE (3 << MMU_RAM_ELSZ_SHIFT) @@ -269,9 +266,6 @@ extern int omap_iommu_set_isr(const char *name, void *priv), void *isr_priv); -extern void omap_iommu_save_ctx(struct device *dev); -extern void omap_iommu_restore_ctx(struct device *dev); - extern int omap_install_iommu_arch(const struct iommu_functions *ops); extern void omap_uninstall_iommu_arch(const struct iommu_functions *ops); diff --git a/arch/arm/plat-omap/include/plat/iovmm.h b/arch/arm/plat-omap/include/plat/iovmm.h deleted file mode 100644 index 498e57c..0000000 --- a/arch/arm/plat-omap/include/plat/iovmm.h +++ /dev/null @@ -1,89 +0,0 @@ -/* - * omap iommu: simple virtual address space management - * - * Copyright (C) 2008-2009 Nokia Corporation - * - * Written by Hiroshi DOYU <Hiroshi.DOYU@nokia.com> - * - * This program is free software; you can redistribute it and/or modify - * it under the terms of the GNU General Public License version 2 as - * published by the Free Software Foundation. - */ - -#ifndef __IOMMU_MMAP_H -#define __IOMMU_MMAP_H - -#include <linux/iommu.h> - -struct iovm_struct { - struct omap_iommu *iommu; /* iommu object which this belongs to */ - u32 da_start; /* area definition */ - u32 da_end; - u32 flags; /* IOVMF_: see below */ - struct list_head list; /* linked in ascending order */ - const struct sg_table *sgt; /* keep 'page' <-> 'da' mapping */ - void *va; /* mpu side mapped address */ -}; - -/* - * IOVMF_FLAGS: attribute for iommu virtual memory area(iovma) - * - * lower 16 bit is used for h/w and upper 16 bit is for s/w. - */ -#define IOVMF_SW_SHIFT 16 - -/* - * iovma: h/w flags derived from cam and ram attribute - */ -#define IOVMF_CAM_MASK (~((1 << 10) - 1)) -#define IOVMF_RAM_MASK (~IOVMF_CAM_MASK) - -#define IOVMF_PGSZ_MASK (3 << 0) -#define IOVMF_PGSZ_1M MMU_CAM_PGSZ_1M -#define IOVMF_PGSZ_64K MMU_CAM_PGSZ_64K -#define IOVMF_PGSZ_4K MMU_CAM_PGSZ_4K -#define IOVMF_PGSZ_16M MMU_CAM_PGSZ_16M - -#define IOVMF_ENDIAN_MASK (1 << 9) -#define IOVMF_ENDIAN_BIG MMU_RAM_ENDIAN_BIG -#define IOVMF_ENDIAN_LITTLE MMU_RAM_ENDIAN_LITTLE - -#define IOVMF_ELSZ_MASK (3 << 7) -#define IOVMF_ELSZ_8 MMU_RAM_ELSZ_8 -#define IOVMF_ELSZ_16 MMU_RAM_ELSZ_16 -#define IOVMF_ELSZ_32 MMU_RAM_ELSZ_32 -#define IOVMF_ELSZ_NONE MMU_RAM_ELSZ_NONE - -#define IOVMF_MIXED_MASK (1 << 6) -#define IOVMF_MIXED MMU_RAM_MIXED - -/* - * iovma: s/w flags, used for mapping and umapping internally. - */ -#define IOVMF_MMIO (1 << IOVMF_SW_SHIFT) -#define IOVMF_ALLOC (2 << IOVMF_SW_SHIFT) -#define IOVMF_ALLOC_MASK (3 << IOVMF_SW_SHIFT) - -/* "superpages" is supported just with physically linear pages */ -#define IOVMF_DISCONT (1 << (2 + IOVMF_SW_SHIFT)) -#define IOVMF_LINEAR (2 << (2 + IOVMF_SW_SHIFT)) -#define IOVMF_LINEAR_MASK (3 << (2 + IOVMF_SW_SHIFT)) - -#define IOVMF_DA_FIXED (1 << (4 + IOVMF_SW_SHIFT)) - - -extern struct iovm_struct *omap_find_iovm_area(struct device *dev, u32 da); -extern u32 -omap_iommu_vmap(struct iommu_domain *domain, struct device *dev, u32 da, - const struct sg_table *sgt, u32 flags); -extern struct sg_table *omap_iommu_vunmap(struct iommu_domain *domain, - struct device *dev, u32 da); -extern u32 -omap_iommu_vmalloc(struct iommu_domain *domain, struct device *dev, - u32 da, size_t bytes, u32 flags); -extern void -omap_iommu_vfree(struct iommu_domain *domain, struct device *dev, - const u32 da); -extern void *omap_da_to_va(struct device *dev, u32 da); - -#endif /* __IOMMU_MMAP_H */ diff --git a/drivers/iommu/omap-iommu-debug.c b/drivers/iommu/omap-iommu-debug.c index 0cac372..cf4a0b5 100644 --- a/drivers/iommu/omap-iommu-debug.c +++ b/drivers/iommu/omap-iommu-debug.c @@ -18,9 +18,9 @@ #include <linux/uaccess.h> #include <linux/platform_device.h> #include <linux/debugfs.h> +#include <linux/omap-iommu.h> #include <plat/iommu.h> -#include <plat/iovmm.h> #include "omap-iopgtable.h" diff --git a/drivers/iommu/omap-iommu.c b/drivers/iommu/omap-iommu.c index f2bbfb0..eadcfde 100644 --- a/drivers/iommu/omap-iommu.c +++ b/drivers/iommu/omap-iommu.c @@ -19,6 +19,7 @@ #include <linux/clk.h> #include <linux/platform_device.h> #include <linux/iommu.h> +#include <linux/omap-iommu.h> #include <linux/mutex.h> #include <linux/spinlock.h> diff --git a/drivers/iommu/omap-iovmm.c b/drivers/iommu/omap-iovmm.c index b332392..9852101 100644 --- a/drivers/iommu/omap-iovmm.c +++ b/drivers/iommu/omap-iovmm.c @@ -17,15 +17,59 @@ #include <linux/device.h> #include <linux/scatterlist.h> #include <linux/iommu.h> +#include <linux/omap-iommu.h> #include <asm/cacheflush.h> #include <asm/mach/map.h> #include <plat/iommu.h> -#include <plat/iovmm.h> #include "omap-iopgtable.h" +/* + * IOVMF_FLAGS: attribute for iommu virtual memory area(iovma) + * + * lower 16 bit is used for h/w and upper 16 bit is for s/w. + */ +#define IOVMF_SW_SHIFT 16 + +/* + * iovma: h/w flags derived from cam and ram attribute + */ +#define IOVMF_CAM_MASK (~((1 << 10) - 1)) +#define IOVMF_RAM_MASK (~IOVMF_CAM_MASK) + +#define IOVMF_PGSZ_MASK (3 << 0) +#define IOVMF_PGSZ_1M MMU_CAM_PGSZ_1M +#define IOVMF_PGSZ_64K MMU_CAM_PGSZ_64K +#define IOVMF_PGSZ_4K MMU_CAM_PGSZ_4K +#define IOVMF_PGSZ_16M MMU_CAM_PGSZ_16M + +#define IOVMF_ENDIAN_MASK (1 << 9) +#define IOVMF_ENDIAN_BIG MMU_RAM_ENDIAN_BIG + +#define IOVMF_ELSZ_MASK (3 << 7) +#define IOVMF_ELSZ_16 MMU_RAM_ELSZ_16 +#define IOVMF_ELSZ_32 MMU_RAM_ELSZ_32 +#define IOVMF_ELSZ_NONE MMU_RAM_ELSZ_NONE + +#define IOVMF_MIXED_MASK (1 << 6) +#define IOVMF_MIXED MMU_RAM_MIXED + +/* + * iovma: s/w flags, used for mapping and umapping internally. + */ +#define IOVMF_MMIO (1 << IOVMF_SW_SHIFT) +#define IOVMF_ALLOC (2 << IOVMF_SW_SHIFT) +#define IOVMF_ALLOC_MASK (3 << IOVMF_SW_SHIFT) + +/* "superpages" is supported just with physically linear pages */ +#define IOVMF_DISCONT (1 << (2 + IOVMF_SW_SHIFT)) +#define IOVMF_LINEAR (2 << (2 + IOVMF_SW_SHIFT)) +#define IOVMF_LINEAR_MASK (3 << (2 + IOVMF_SW_SHIFT)) + +#define IOVMF_DA_FIXED (1 << (4 + IOVMF_SW_SHIFT)) + static struct kmem_cache *iovm_area_cachep; /* return the offset of the first scatterlist entry in a sg table */ diff --git a/drivers/media/platform/omap3isp/isp.c b/drivers/media/platform/omap3isp/isp.c index 99640d8..7f182f0 100644 --- a/drivers/media/platform/omap3isp/isp.c +++ b/drivers/media/platform/omap3isp/isp.c @@ -61,6 +61,7 @@ #include <linux/i2c.h> #include <linux/interrupt.h> #include <linux/module.h> +#include <linux/omap-iommu.h> #include <linux/platform_device.h> #include <linux/regulator/consumer.h> #include <linux/slab.h> diff --git a/drivers/media/platform/omap3isp/isp.h b/drivers/media/platform/omap3isp/isp.h index 8be7487..8d68669 100644 --- a/drivers/media/platform/omap3isp/isp.h +++ b/drivers/media/platform/omap3isp/isp.h @@ -31,11 +31,9 @@ #include <media/v4l2-device.h> #include <linux/device.h> #include <linux/io.h> +#include <linux/iommu.h> #include <linux/platform_device.h> #include <linux/wait.h> -#include <linux/iommu.h> -#include <plat/iommu.h> -#include <plat/iovmm.h> #include "ispstat.h" #include "ispccdc.h" diff --git a/drivers/media/platform/omap3isp/ispccdc.c b/drivers/media/platform/omap3isp/ispccdc.c index 60181ab..6ae1ffb2 100644 --- a/drivers/media/platform/omap3isp/ispccdc.c +++ b/drivers/media/platform/omap3isp/ispccdc.c @@ -30,6 +30,7 @@ #include <linux/device.h> #include <linux/dma-mapping.h> #include <linux/mm.h> +#include <linux/omap-iommu.h> #include <linux/sched.h> #include <linux/slab.h> #include <media/v4l2-event.h> diff --git a/drivers/media/platform/omap3isp/ispstat.c b/drivers/media/platform/omap3isp/ispstat.c index d7ac76b..0408a32 100644 --- a/drivers/media/platform/omap3isp/ispstat.c +++ b/drivers/media/platform/omap3isp/ispstat.c @@ -27,6 +27,7 @@ #include <linux/dma-mapping.h> #include <linux/slab.h> +#include <linux/omap-iommu.h> #include <linux/uaccess.h> #include "isp.h" diff --git a/drivers/media/platform/omap3isp/ispvideo.c b/drivers/media/platform/omap3isp/ispvideo.c index a0b737fe..a4b8290 100644 --- a/drivers/media/platform/omap3isp/ispvideo.c +++ b/drivers/media/platform/omap3isp/ispvideo.c @@ -27,6 +27,7 @@ #include <linux/clk.h> #include <linux/mm.h> #include <linux/module.h> +#include <linux/omap-iommu.h> #include <linux/pagemap.h> #include <linux/scatterlist.h> #include <linux/sched.h> @@ -35,7 +36,6 @@ #include <media/v4l2-dev.h> #include <media/v4l2-ioctl.h> #include <plat/iommu.h> -#include <plat/iovmm.h> #include <plat/omap-pm.h> #include "ispvideo.h" diff --git a/include/linux/omap-iommu.h b/include/linux/omap-iommu.h new file mode 100644 index 0000000..cac78de --- /dev/null +++ b/include/linux/omap-iommu.h @@ -0,0 +1,52 @@ +/* + * omap iommu: simple virtual address space management + * + * Copyright (C) 2008-2009 Nokia Corporation + * + * Written by Hiroshi DOYU <Hiroshi.DOYU@nokia.com> + * + * This program is free software; you can redistribute it and/or modify + * it under the terms of the GNU General Public License version 2 as + * published by the Free Software Foundation. + */ + +#ifndef _INTEL_IOMMU_H_ +#define _INTEL_IOMMU_H_ + +struct iovm_struct { + struct omap_iommu *iommu; /* iommu object which this belongs to */ + u32 da_start; /* area definition */ + u32 da_end; + u32 flags; /* IOVMF_: see below */ + struct list_head list; /* linked in ascending order */ + const struct sg_table *sgt; /* keep 'page' <-> 'da' mapping */ + void *va; /* mpu side mapped address */ +}; + +#define MMU_RAM_ENDIAN_SHIFT 9 +#define MMU_RAM_ENDIAN_LITTLE (0 << MMU_RAM_ENDIAN_SHIFT) +#define MMU_RAM_ELSZ_8 (0 << MMU_RAM_ELSZ_SHIFT) +#define IOVMF_ENDIAN_LITTLE MMU_RAM_ENDIAN_LITTLE +#define MMU_RAM_ELSZ_SHIFT 7 +#define IOVMF_ELSZ_8 MMU_RAM_ELSZ_8 + +struct iommu_domain; + +extern struct iovm_struct *omap_find_iovm_area(struct device *dev, u32 da); +extern u32 +omap_iommu_vmap(struct iommu_domain *domain, struct device *dev, u32 da, + const struct sg_table *sgt, u32 flags); +extern struct sg_table *omap_iommu_vunmap(struct iommu_domain *domain, + struct device *dev, u32 da); +extern u32 +omap_iommu_vmalloc(struct iommu_domain *domain, struct device *dev, + u32 da, size_t bytes, u32 flags); +extern void +omap_iommu_vfree(struct iommu_domain *domain, struct device *dev, + const u32 da); +extern void *omap_da_to_va(struct device *dev, u32 da); + +extern void omap_iommu_save_ctx(struct device *dev); +extern void omap_iommu_restore_ctx(struct device *dev); + +#endif ^ permalink raw reply related [flat|nested] 21+ messages in thread
* Re: [PATCH 3/6] ARM: OMAP2+: Move plat/iovmm.h to include/linux/omap-iommu.h 2012-10-24 22:34 ` Tony Lindgren @ 2012-10-24 23:53 ` Laurent Pinchart 2012-10-25 0:25 ` Tony Lindgren 0 siblings, 1 reply; 21+ messages in thread From: Laurent Pinchart @ 2012-10-24 23:53 UTC (permalink / raw) To: Tony Lindgren Cc: linux-arm-kernel, Ohad Ben-Cohen, Joerg Roedel, Mauro Carvalho Chehab, Omar Ramirez Luna, linux-omap, Ido Yariv, linux-media Hi Tony, On Wednesday 24 October 2012 15:34:12 Tony Lindgren wrote: > * Laurent Pinchart <laurent.pinchart@ideasonboard.com> [121019 02:41]: > > On Thursday 18 October 2012 13:28:42 Tony Lindgren wrote: > > > --- a/arch/arm/mach-omap2/iommu2.c > > > +++ b/arch/arm/mach-omap2/iommu2.c > > > @@ -17,6 +17,7 @@ > > > > > > #include <linux/module.h> > > > #include <linux/slab.h> > > > #include <linux/stringify.h> > > > > > > +#include <linux/omap-iommu.h> > > > > Nitpicking, please keep the headers sorted alphabetically, here and in all > > locations below (especially the OMAP3 ISP driver). > > > > (OK, there's already one misplaced #include, but let's not make it worse > > :-)) > > This is fixed now. > > > > --- /dev/null > > > +++ b/include/linux/omap-iommu.h > > > @@ -0,0 +1,47 @@ > > > +/* > > > + * omap iommu: simple virtual address space management > > > + * > > > + * Copyright (C) 2008-2009 Nokia Corporation > > > + * > > > + * Written by Hiroshi DOYU <Hiroshi.DOYU@nokia.com> > > > + * > > > + * This program is free software; you can redistribute it and/or modify > > > + * it under the terms of the GNU General Public License version 2 as > > > + * published by the Free Software Foundation. > > > + */ > > > > Missing #ifndef #define ... #endif > > I've added it as _OMAP_IOMMU_H_, looks like both intel-iommu.h and > amd-iommu.h have it. > > Hopefully that's OK for you as a base to do further iommu patches > on, updated patch below. > > BTW, doing a test compile on v3.7-rc2, I'm seeing the following warnings > for omap3isp for isp_video_ioctl_ops: > > drivers/media/platform/omap3isp/ispvideo.c:1213: warning: initialization > from incompatible pointer type > drivers/media/platform/omap3isp/ispccdc.c:2303: warning: initialization > from incompatible pointer type > drivers/media/platform/omap3isp/ispccdc.c:2304: warning: initialization > from incompatible pointer type > drivers/media/platform/omap3isp/isph3a_aewb.c:282: warning: initialization > from incompatible pointer type > drivers/media/platform/omap3isp/isph3a_aewb.c:283: warning: initialization > from incompatible pointer type > drivers/media/platform/omap3isp/isph3a_af.c:347: warning: initialization > from incompatible pointer type > drivers/media/platform/omap3isp/isph3a_af.c:348: warning: initialization > from incompatible pointer type > drivers/media/platform/omap3isp/isphist.c:453: warning: initialization from > incompatible pointer type > drivers/media/platform/omap3isp/isphist.c:454: warning: initialization from > incompatible pointer type I've just sent a pull request to linux-media for v3.7 with fixes for those. -- Regards, Laurent Pinchart ^ permalink raw reply [flat|nested] 21+ messages in thread
* Re: [PATCH 3/6] ARM: OMAP2+: Move plat/iovmm.h to include/linux/omap-iommu.h 2012-10-24 23:53 ` Laurent Pinchart @ 2012-10-25 0:25 ` Tony Lindgren 0 siblings, 0 replies; 21+ messages in thread From: Tony Lindgren @ 2012-10-25 0:25 UTC (permalink / raw) To: Laurent Pinchart Cc: linux-arm-kernel, Ohad Ben-Cohen, Joerg Roedel, Mauro Carvalho Chehab, Omar Ramirez Luna, linux-omap, Ido Yariv, linux-media * Laurent Pinchart <laurent.pinchart@ideasonboard.com> [121024 16:54]: > On Wednesday 24 October 2012 15:34:12 Tony Lindgren wrote: > > > > BTW, doing a test compile on v3.7-rc2, I'm seeing the following warnings > > for omap3isp for isp_video_ioctl_ops: > > > > drivers/media/platform/omap3isp/ispvideo.c:1213: warning: initialization > > from incompatible pointer type > > drivers/media/platform/omap3isp/ispccdc.c:2303: warning: initialization > > from incompatible pointer type > > drivers/media/platform/omap3isp/ispccdc.c:2304: warning: initialization > > from incompatible pointer type > > drivers/media/platform/omap3isp/isph3a_aewb.c:282: warning: initialization > > from incompatible pointer type > > drivers/media/platform/omap3isp/isph3a_aewb.c:283: warning: initialization > > from incompatible pointer type > > drivers/media/platform/omap3isp/isph3a_af.c:347: warning: initialization > > from incompatible pointer type > > drivers/media/platform/omap3isp/isph3a_af.c:348: warning: initialization > > from incompatible pointer type > > drivers/media/platform/omap3isp/isphist.c:453: warning: initialization from > > incompatible pointer type > > drivers/media/platform/omap3isp/isphist.c:454: warning: initialization from > > incompatible pointer type > > I've just sent a pull request to linux-media for v3.7 with fixes for those. OK thanks! Tony ^ permalink raw reply [flat|nested] 21+ messages in thread
* [PATCH 4/6] ARM: OMAP2+: Move iommu2 to drivers/iommu/omap-iommu2.c [not found] <20121018202707.11834.1438.stgit@muffinssi.local> 2012-10-18 20:28 ` [PATCH 3/6] ARM: OMAP2+: Move plat/iovmm.h to include/linux/omap-iommu.h Tony Lindgren @ 2012-10-18 20:28 ` Tony Lindgren 1 sibling, 0 replies; 21+ messages in thread From: Tony Lindgren @ 2012-10-18 20:28 UTC (permalink / raw) To: linux-arm-kernel Cc: Ohad Ben-Cohen, Joerg Roedel, Mauro Carvalho Chehab, Laurent Pinchart, Omar Ramirez Luna, linux-omap, Ido Yariv, linux-media This file should not be in arch/arm. Move it to drivers/iommu to allow making most of the header local to drivers/iommu. This is needed as we are removing plat and mach includes from drivers for ARM common zImage support. Cc: Joerg Roedel <joerg.roedel@amd.com> Cc: Ohad Ben-Cohen <ohad@wizery.com> Cc: Ido Yariv <ido@wizery.com> Cc: Laurent Pinchart <laurent.pinchart@ideasonboard.com> Cc: Mauro Carvalho Chehab <mchehab@infradead.org> Cc: Omar Ramirez Luna <omar.luna@linaro.org> Cc: linux-media@vger.kernel.org Signed-off-by: Tony Lindgren <tony@atomide.com> --- arch/arm/mach-omap2/Makefile | 2 arch/arm/plat-omap/include/plat/iommu.h | 272 ++----------------------------- drivers/iommu/Makefile | 1 drivers/iommu/omap-iommu-debug.c | 1 drivers/iommu/omap-iommu.c | 19 ++ drivers/iommu/omap-iommu.h | 255 +++++++++++++++++++++++++++++ drivers/iommu/omap-iommu2.c | 2 drivers/iommu/omap-iopgtable.h | 22 --- drivers/iommu/omap-iovmm.c | 1 9 files changed, 293 insertions(+), 282 deletions(-) create mode 100644 drivers/iommu/omap-iommu.h rename arch/arm/mach-omap2/iommu2.c => drivers/iommu/omap-iommu2.c (99%) diff --git a/arch/arm/mach-omap2/Makefile b/arch/arm/mach-omap2/Makefile index fe40d9e..d6721a7 100644 --- a/arch/arm/mach-omap2/Makefile +++ b/arch/arm/mach-omap2/Makefile @@ -184,8 +184,6 @@ obj-$(CONFIG_HW_PERF_EVENTS) += pmu.o obj-$(CONFIG_OMAP_MBOX_FWK) += mailbox_mach.o mailbox_mach-objs := mailbox.o -obj-$(CONFIG_OMAP_IOMMU) += iommu2.o - iommu-$(CONFIG_OMAP_IOMMU) := omap-iommu.o obj-y += $(iommu-m) $(iommu-y) diff --git a/arch/arm/plat-omap/include/plat/iommu.h b/arch/arm/plat-omap/include/plat/iommu.h index a4b71b1..c677b9f 100644 --- a/arch/arm/plat-omap/include/plat/iommu.h +++ b/arch/arm/plat-omap/include/plat/iommu.h @@ -10,103 +10,21 @@ * published by the Free Software Foundation. */ -#ifndef __MACH_IOMMU_H -#define __MACH_IOMMU_H - -#include <linux/io.h> - -#if defined(CONFIG_ARCH_OMAP1) -#error "iommu for this processor not implemented yet" -#endif - -struct iotlb_entry { - u32 da; - u32 pa; - u32 pgsz, prsvd, valid; - union { - u16 ap; - struct { - u32 endian, elsz, mixed; - }; - }; -}; - -struct omap_iommu { - const char *name; - struct module *owner; - struct clk *clk; - void __iomem *regbase; - struct device *dev; - void *isr_priv; - struct iommu_domain *domain; - - unsigned int refcount; - spinlock_t iommu_lock; /* global for this whole object */ - - /* - * We don't change iopgd for a situation like pgd for a task, - * but share it globally for each iommu. - */ - u32 *iopgd; - spinlock_t page_table_lock; /* protect iopgd */ - - int nr_tlb_entries; - - struct list_head mmap; - struct mutex mmap_lock; /* protect mmap */ - - void *ctx; /* iommu context: registres saved area */ - u32 da_start; - u32 da_end; -}; - -struct cr_regs { - union { - struct { - u16 cam_l; - u16 cam_h; - }; - u32 cam; - }; - union { - struct { - u16 ram_l; - u16 ram_h; - }; - u32 ram; - }; -}; - -struct iotlb_lock { - short base; - short vict; -}; - -/* architecture specific functions */ -struct iommu_functions { - unsigned long version; - - int (*enable)(struct omap_iommu *obj); - void (*disable)(struct omap_iommu *obj); - void (*set_twl)(struct omap_iommu *obj, bool on); - u32 (*fault_isr)(struct omap_iommu *obj, u32 *ra); - - void (*tlb_read_cr)(struct omap_iommu *obj, struct cr_regs *cr); - void (*tlb_load_cr)(struct omap_iommu *obj, struct cr_regs *cr); - - struct cr_regs *(*alloc_cr)(struct omap_iommu *obj, - struct iotlb_entry *e); - int (*cr_valid)(struct cr_regs *cr); - u32 (*cr_to_virt)(struct cr_regs *cr); - void (*cr_to_e)(struct cr_regs *cr, struct iotlb_entry *e); - ssize_t (*dump_cr)(struct omap_iommu *obj, struct cr_regs *cr, - char *buf); - - u32 (*get_pte_attr)(struct iotlb_entry *e); +#define MMU_REG_SIZE 256 - void (*save_ctx)(struct omap_iommu *obj); - void (*restore_ctx)(struct omap_iommu *obj); - ssize_t (*dump_ctx)(struct omap_iommu *obj, char *buf, ssize_t len); +/** + * struct iommu_arch_data - omap iommu private data + * @name: name of the iommu device + * @iommu_dev: handle of the iommu device + * + * This is an omap iommu private data object, which binds an iommu user + * to its iommu device. This object should be placed at the iommu user's + * dev_archdata so generic IOMMU API can be used without having to + * utilize omap-specific plumbing anymore. + */ +struct omap_iommu_arch_data { + const char *name; + struct omap_iommu *iommu_dev; }; /** @@ -129,165 +47,3 @@ struct iommu_platform_data { u32 da_start; u32 da_end; }; - -/** - * struct iommu_arch_data - omap iommu private data - * @name: name of the iommu device - * @iommu_dev: handle of the iommu device - * - * This is an omap iommu private data object, which binds an iommu user - * to its iommu device. This object should be placed at the iommu user's - * dev_archdata so generic IOMMU API can be used without having to - * utilize omap-specific plumbing anymore. - */ -struct omap_iommu_arch_data { - const char *name; - struct omap_iommu *iommu_dev; -}; - -#ifdef CONFIG_IOMMU_API -/** - * dev_to_omap_iommu() - retrieves an omap iommu object from a user device - * @dev: iommu client device - */ -static inline struct omap_iommu *dev_to_omap_iommu(struct device *dev) -{ - struct omap_iommu_arch_data *arch_data = dev->archdata.iommu; - - return arch_data->iommu_dev; -} -#endif - -/* IOMMU errors */ -#define OMAP_IOMMU_ERR_TLB_MISS (1 << 0) -#define OMAP_IOMMU_ERR_TRANS_FAULT (1 << 1) -#define OMAP_IOMMU_ERR_EMU_MISS (1 << 2) -#define OMAP_IOMMU_ERR_TBLWALK_FAULT (1 << 3) -#define OMAP_IOMMU_ERR_MULTIHIT_FAULT (1 << 4) - -/* - * MMU Register offsets - */ -#define MMU_REVISION 0x00 -#define MMU_SYSCONFIG 0x10 -#define MMU_SYSSTATUS 0x14 -#define MMU_IRQSTATUS 0x18 -#define MMU_IRQENABLE 0x1c -#define MMU_WALKING_ST 0x40 -#define MMU_CNTL 0x44 -#define MMU_FAULT_AD 0x48 -#define MMU_TTB 0x4c -#define MMU_LOCK 0x50 -#define MMU_LD_TLB 0x54 -#define MMU_CAM 0x58 -#define MMU_RAM 0x5c -#define MMU_GFLUSH 0x60 -#define MMU_FLUSH_ENTRY 0x64 -#define MMU_READ_CAM 0x68 -#define MMU_READ_RAM 0x6c -#define MMU_EMU_FAULT_AD 0x70 - -#define MMU_REG_SIZE 256 - -/* - * MMU Register bit definitions - */ -#define MMU_LOCK_BASE_SHIFT 10 -#define MMU_LOCK_BASE_MASK (0x1f << MMU_LOCK_BASE_SHIFT) -#define MMU_LOCK_BASE(x) \ - ((x & MMU_LOCK_BASE_MASK) >> MMU_LOCK_BASE_SHIFT) - -#define MMU_LOCK_VICT_SHIFT 4 -#define MMU_LOCK_VICT_MASK (0x1f << MMU_LOCK_VICT_SHIFT) -#define MMU_LOCK_VICT(x) \ - ((x & MMU_LOCK_VICT_MASK) >> MMU_LOCK_VICT_SHIFT) - -#define MMU_CAM_VATAG_SHIFT 12 -#define MMU_CAM_VATAG_MASK \ - ((~0UL >> MMU_CAM_VATAG_SHIFT) << MMU_CAM_VATAG_SHIFT) -#define MMU_CAM_P (1 << 3) -#define MMU_CAM_V (1 << 2) -#define MMU_CAM_PGSZ_MASK 3 -#define MMU_CAM_PGSZ_1M (0 << 0) -#define MMU_CAM_PGSZ_64K (1 << 0) -#define MMU_CAM_PGSZ_4K (2 << 0) -#define MMU_CAM_PGSZ_16M (3 << 0) - -#define MMU_RAM_PADDR_SHIFT 12 -#define MMU_RAM_PADDR_MASK \ - ((~0UL >> MMU_RAM_PADDR_SHIFT) << MMU_RAM_PADDR_SHIFT) - -#define MMU_RAM_ENDIAN_MASK (1 << MMU_RAM_ENDIAN_SHIFT) -#define MMU_RAM_ELSZ_MASK (3 << MMU_RAM_ELSZ_SHIFT) - -#define MMU_RAM_ELSZ_16 (1 << MMU_RAM_ELSZ_SHIFT) -#define MMU_RAM_ELSZ_32 (2 << MMU_RAM_ELSZ_SHIFT) -#define MMU_RAM_ELSZ_NONE (3 << MMU_RAM_ELSZ_SHIFT) -#define MMU_RAM_MIXED_SHIFT 6 -#define MMU_RAM_MIXED_MASK (1 << MMU_RAM_MIXED_SHIFT) -#define MMU_RAM_MIXED MMU_RAM_MIXED_MASK - -/* - * utilities for super page(16MB, 1MB, 64KB and 4KB) - */ - -#define iopgsz_max(bytes) \ - (((bytes) >= SZ_16M) ? SZ_16M : \ - ((bytes) >= SZ_1M) ? SZ_1M : \ - ((bytes) >= SZ_64K) ? SZ_64K : \ - ((bytes) >= SZ_4K) ? SZ_4K : 0) - -#define bytes_to_iopgsz(bytes) \ - (((bytes) == SZ_16M) ? MMU_CAM_PGSZ_16M : \ - ((bytes) == SZ_1M) ? MMU_CAM_PGSZ_1M : \ - ((bytes) == SZ_64K) ? MMU_CAM_PGSZ_64K : \ - ((bytes) == SZ_4K) ? MMU_CAM_PGSZ_4K : -1) - -#define iopgsz_to_bytes(iopgsz) \ - (((iopgsz) == MMU_CAM_PGSZ_16M) ? SZ_16M : \ - ((iopgsz) == MMU_CAM_PGSZ_1M) ? SZ_1M : \ - ((iopgsz) == MMU_CAM_PGSZ_64K) ? SZ_64K : \ - ((iopgsz) == MMU_CAM_PGSZ_4K) ? SZ_4K : 0) - -#define iopgsz_ok(bytes) (bytes_to_iopgsz(bytes) >= 0) - -/* - * global functions - */ -extern u32 omap_iommu_arch_version(void); - -extern void omap_iotlb_cr_to_e(struct cr_regs *cr, struct iotlb_entry *e); - -extern int -omap_iopgtable_store_entry(struct omap_iommu *obj, struct iotlb_entry *e); - -extern int omap_iommu_set_isr(const char *name, - int (*isr)(struct omap_iommu *obj, u32 da, u32 iommu_errs, - void *priv), - void *isr_priv); - -extern int omap_install_iommu_arch(const struct iommu_functions *ops); -extern void omap_uninstall_iommu_arch(const struct iommu_functions *ops); - -extern int omap_foreach_iommu_device(void *data, - int (*fn)(struct device *, void *)); - -extern ssize_t -omap_iommu_dump_ctx(struct omap_iommu *obj, char *buf, ssize_t len); -extern size_t -omap_dump_tlb_entries(struct omap_iommu *obj, char *buf, ssize_t len); - -/* - * register accessors - */ -static inline u32 iommu_read_reg(struct omap_iommu *obj, size_t offs) -{ - return __raw_readl(obj->regbase + offs); -} - -static inline void iommu_write_reg(struct omap_iommu *obj, u32 val, size_t offs) -{ - __raw_writel(val, obj->regbase + offs); -} - -#endif /* __MACH_IOMMU_H */ diff --git a/drivers/iommu/Makefile b/drivers/iommu/Makefile index 14a4d5f..f66b816 100644 --- a/drivers/iommu/Makefile +++ b/drivers/iommu/Makefile @@ -7,6 +7,7 @@ obj-$(CONFIG_DMAR_TABLE) += dmar.o obj-$(CONFIG_INTEL_IOMMU) += iova.o intel-iommu.o obj-$(CONFIG_IRQ_REMAP) += intel_irq_remapping.o irq_remapping.o obj-$(CONFIG_OMAP_IOMMU) += omap-iommu.o +obj-$(CONFIG_OMAP_IOMMU) += omap-iommu2.o obj-$(CONFIG_OMAP_IOVMM) += omap-iovmm.o obj-$(CONFIG_OMAP_IOMMU_DEBUG) += omap-iommu-debug.o obj-$(CONFIG_TEGRA_IOMMU_GART) += tegra-gart.o diff --git a/drivers/iommu/omap-iommu-debug.c b/drivers/iommu/omap-iommu-debug.c index cf4a0b5..d0427bd 100644 --- a/drivers/iommu/omap-iommu-debug.c +++ b/drivers/iommu/omap-iommu-debug.c @@ -23,6 +23,7 @@ #include <plat/iommu.h> #include "omap-iopgtable.h" +#include "omap-iommu.h" #define MAXCOLUMN 100 /* for short messages */ diff --git a/drivers/iommu/omap-iommu.c b/drivers/iommu/omap-iommu.c index eadcfde..4db86e1 100644 --- a/drivers/iommu/omap-iommu.c +++ b/drivers/iommu/omap-iommu.c @@ -22,12 +22,14 @@ #include <linux/omap-iommu.h> #include <linux/mutex.h> #include <linux/spinlock.h> +#include <linux/io.h> #include <asm/cacheflush.h> #include <plat/iommu.h> #include "omap-iopgtable.h" +#include "omap-iommu.h" #define for_each_iotlb_cr(obj, n, __i, cr) \ for (__i = 0; \ @@ -1016,6 +1018,23 @@ static void iopte_cachep_ctor(void *iopte) clean_dcache_area(iopte, IOPTE_TABLE_SIZE); } +static u32 iotlb_init_entry(struct iotlb_entry *e, u32 da, u32 pa, + u32 flags) +{ + memset(e, 0, sizeof(*e)); + + e->da = da; + e->pa = pa; + e->valid = 1; + /* FIXME: add OMAP1 support */ + e->pgsz = flags & MMU_CAM_PGSZ_MASK; + e->endian = flags & MMU_RAM_ENDIAN_MASK; + e->elsz = flags & MMU_RAM_ELSZ_MASK; + e->mixed = flags & MMU_RAM_MIXED_MASK; + + return iopgsz_to_bytes(e->pgsz); +} + static int omap_iommu_map(struct iommu_domain *domain, unsigned long da, phys_addr_t pa, size_t bytes, int prot) { diff --git a/drivers/iommu/omap-iommu.h b/drivers/iommu/omap-iommu.h new file mode 100644 index 0000000..8c3378d --- /dev/null +++ b/drivers/iommu/omap-iommu.h @@ -0,0 +1,255 @@ +/* + * omap iommu: main structures + * + * Copyright (C) 2008-2009 Nokia Corporation + * + * Written by Hiroshi DOYU <Hiroshi.DOYU@nokia.com> + * + * This program is free software; you can redistribute it and/or modify + * it under the terms of the GNU General Public License version 2 as + * published by the Free Software Foundation. + */ + +#if defined(CONFIG_ARCH_OMAP1) +#error "iommu for this processor not implemented yet" +#endif + +struct iotlb_entry { + u32 da; + u32 pa; + u32 pgsz, prsvd, valid; + union { + u16 ap; + struct { + u32 endian, elsz, mixed; + }; + }; +}; + +struct omap_iommu { + const char *name; + struct module *owner; + struct clk *clk; + void __iomem *regbase; + struct device *dev; + void *isr_priv; + struct iommu_domain *domain; + + unsigned int refcount; + spinlock_t iommu_lock; /* global for this whole object */ + + /* + * We don't change iopgd for a situation like pgd for a task, + * but share it globally for each iommu. + */ + u32 *iopgd; + spinlock_t page_table_lock; /* protect iopgd */ + + int nr_tlb_entries; + + struct list_head mmap; + struct mutex mmap_lock; /* protect mmap */ + + void *ctx; /* iommu context: registres saved area */ + u32 da_start; + u32 da_end; +}; + +struct cr_regs { + union { + struct { + u16 cam_l; + u16 cam_h; + }; + u32 cam; + }; + union { + struct { + u16 ram_l; + u16 ram_h; + }; + u32 ram; + }; +}; + +struct iotlb_lock { + short base; + short vict; +}; + +/* architecture specific functions */ +struct iommu_functions { + unsigned long version; + + int (*enable)(struct omap_iommu *obj); + void (*disable)(struct omap_iommu *obj); + void (*set_twl)(struct omap_iommu *obj, bool on); + u32 (*fault_isr)(struct omap_iommu *obj, u32 *ra); + + void (*tlb_read_cr)(struct omap_iommu *obj, struct cr_regs *cr); + void (*tlb_load_cr)(struct omap_iommu *obj, struct cr_regs *cr); + + struct cr_regs *(*alloc_cr)(struct omap_iommu *obj, + struct iotlb_entry *e); + int (*cr_valid)(struct cr_regs *cr); + u32 (*cr_to_virt)(struct cr_regs *cr); + void (*cr_to_e)(struct cr_regs *cr, struct iotlb_entry *e); + ssize_t (*dump_cr)(struct omap_iommu *obj, struct cr_regs *cr, + char *buf); + + u32 (*get_pte_attr)(struct iotlb_entry *e); + + void (*save_ctx)(struct omap_iommu *obj); + void (*restore_ctx)(struct omap_iommu *obj); + ssize_t (*dump_ctx)(struct omap_iommu *obj, char *buf, ssize_t len); +}; + +#ifdef CONFIG_IOMMU_API +/** + * dev_to_omap_iommu() - retrieves an omap iommu object from a user device + * @dev: iommu client device + */ +static inline struct omap_iommu *dev_to_omap_iommu(struct device *dev) +{ + struct omap_iommu_arch_data *arch_data = dev->archdata.iommu; + + return arch_data->iommu_dev; +} +#endif + +/* IOMMU errors */ +#define OMAP_IOMMU_ERR_TLB_MISS (1 << 0) +#define OMAP_IOMMU_ERR_TRANS_FAULT (1 << 1) +#define OMAP_IOMMU_ERR_EMU_MISS (1 << 2) +#define OMAP_IOMMU_ERR_TBLWALK_FAULT (1 << 3) +#define OMAP_IOMMU_ERR_MULTIHIT_FAULT (1 << 4) + +/* + * MMU Register offsets + */ +#define MMU_REVISION 0x00 +#define MMU_SYSCONFIG 0x10 +#define MMU_SYSSTATUS 0x14 +#define MMU_IRQSTATUS 0x18 +#define MMU_IRQENABLE 0x1c +#define MMU_WALKING_ST 0x40 +#define MMU_CNTL 0x44 +#define MMU_FAULT_AD 0x48 +#define MMU_TTB 0x4c +#define MMU_LOCK 0x50 +#define MMU_LD_TLB 0x54 +#define MMU_CAM 0x58 +#define MMU_RAM 0x5c +#define MMU_GFLUSH 0x60 +#define MMU_FLUSH_ENTRY 0x64 +#define MMU_READ_CAM 0x68 +#define MMU_READ_RAM 0x6c +#define MMU_EMU_FAULT_AD 0x70 + +#define MMU_REG_SIZE 256 + +/* + * MMU Register bit definitions + */ +#define MMU_LOCK_BASE_SHIFT 10 +#define MMU_LOCK_BASE_MASK (0x1f << MMU_LOCK_BASE_SHIFT) +#define MMU_LOCK_BASE(x) \ + ((x & MMU_LOCK_BASE_MASK) >> MMU_LOCK_BASE_SHIFT) + +#define MMU_LOCK_VICT_SHIFT 4 +#define MMU_LOCK_VICT_MASK (0x1f << MMU_LOCK_VICT_SHIFT) +#define MMU_LOCK_VICT(x) \ + ((x & MMU_LOCK_VICT_MASK) >> MMU_LOCK_VICT_SHIFT) + +#define MMU_CAM_VATAG_SHIFT 12 +#define MMU_CAM_VATAG_MASK \ + ((~0UL >> MMU_CAM_VATAG_SHIFT) << MMU_CAM_VATAG_SHIFT) +#define MMU_CAM_P (1 << 3) +#define MMU_CAM_V (1 << 2) +#define MMU_CAM_PGSZ_MASK 3 +#define MMU_CAM_PGSZ_1M (0 << 0) +#define MMU_CAM_PGSZ_64K (1 << 0) +#define MMU_CAM_PGSZ_4K (2 << 0) +#define MMU_CAM_PGSZ_16M (3 << 0) + +#define MMU_RAM_PADDR_SHIFT 12 +#define MMU_RAM_PADDR_MASK \ + ((~0UL >> MMU_RAM_PADDR_SHIFT) << MMU_RAM_PADDR_SHIFT) + +#define MMU_RAM_ENDIAN_MASK (1 << MMU_RAM_ENDIAN_SHIFT) +#define MMU_RAM_ENDIAN_BIG (1 << MMU_RAM_ENDIAN_SHIFT) + +#define MMU_RAM_ELSZ_MASK (3 << MMU_RAM_ELSZ_SHIFT) +#define MMU_RAM_ELSZ_8 (0 << MMU_RAM_ELSZ_SHIFT) +#define MMU_RAM_ELSZ_16 (1 << MMU_RAM_ELSZ_SHIFT) +#define MMU_RAM_ELSZ_32 (2 << MMU_RAM_ELSZ_SHIFT) +#define MMU_RAM_ELSZ_NONE (3 << MMU_RAM_ELSZ_SHIFT) +#define MMU_RAM_MIXED_SHIFT 6 +#define MMU_RAM_MIXED_MASK (1 << MMU_RAM_MIXED_SHIFT) +#define MMU_RAM_MIXED MMU_RAM_MIXED_MASK + +/* + * utilities for super page(16MB, 1MB, 64KB and 4KB) + */ + +#define iopgsz_max(bytes) \ + (((bytes) >= SZ_16M) ? SZ_16M : \ + ((bytes) >= SZ_1M) ? SZ_1M : \ + ((bytes) >= SZ_64K) ? SZ_64K : \ + ((bytes) >= SZ_4K) ? SZ_4K : 0) + +#define bytes_to_iopgsz(bytes) \ + (((bytes) == SZ_16M) ? MMU_CAM_PGSZ_16M : \ + ((bytes) == SZ_1M) ? MMU_CAM_PGSZ_1M : \ + ((bytes) == SZ_64K) ? MMU_CAM_PGSZ_64K : \ + ((bytes) == SZ_4K) ? MMU_CAM_PGSZ_4K : -1) + +#define iopgsz_to_bytes(iopgsz) \ + (((iopgsz) == MMU_CAM_PGSZ_16M) ? SZ_16M : \ + ((iopgsz) == MMU_CAM_PGSZ_1M) ? SZ_1M : \ + ((iopgsz) == MMU_CAM_PGSZ_64K) ? SZ_64K : \ + ((iopgsz) == MMU_CAM_PGSZ_4K) ? SZ_4K : 0) + +#define iopgsz_ok(bytes) (bytes_to_iopgsz(bytes) >= 0) + +/* + * global functions + */ +extern u32 omap_iommu_arch_version(void); + +extern void omap_iotlb_cr_to_e(struct cr_regs *cr, struct iotlb_entry *e); + +extern int +omap_iopgtable_store_entry(struct omap_iommu *obj, struct iotlb_entry *e); + +extern int omap_iommu_set_isr(const char *name, + int (*isr)(struct omap_iommu *obj, u32 da, u32 iommu_errs, + void *priv), + void *isr_priv); + +extern void omap_iommu_save_ctx(struct device *dev); +extern void omap_iommu_restore_ctx(struct device *dev); + +extern int omap_install_iommu_arch(const struct iommu_functions *ops); +extern void omap_uninstall_iommu_arch(const struct iommu_functions *ops); + +extern int omap_foreach_iommu_device(void *data, + int (*fn)(struct device *, void *)); + +extern ssize_t +omap_iommu_dump_ctx(struct omap_iommu *obj, char *buf, ssize_t len); +extern size_t +omap_dump_tlb_entries(struct omap_iommu *obj, char *buf, ssize_t len); + +/* + * register accessors + */ +static inline u32 iommu_read_reg(struct omap_iommu *obj, size_t offs) +{ + return __raw_readl(obj->regbase + offs); +} + +static inline void iommu_write_reg(struct omap_iommu *obj, u32 val, size_t offs) +{ + __raw_writel(val, obj->regbase + offs); +} diff --git a/arch/arm/mach-omap2/iommu2.c b/drivers/iommu/omap-iommu2.c similarity index 99% rename from arch/arm/mach-omap2/iommu2.c rename to drivers/iommu/omap-iommu2.c index 77cbf2f..066e6b2 100644 --- a/arch/arm/mach-omap2/iommu2.c +++ b/drivers/iommu/omap-iommu2.c @@ -17,9 +17,11 @@ #include <linux/module.h> #include <linux/slab.h> #include <linux/stringify.h> +#include <linux/io.h> #include <linux/omap-iommu.h> #include <plat/iommu.h> +#include "omap-iommu.h" /* * omap2 architecture specific register bit definitions diff --git a/drivers/iommu/omap-iopgtable.h b/drivers/iommu/omap-iopgtable.h index 66a8139..cd4ae9e 100644 --- a/drivers/iommu/omap-iopgtable.h +++ b/drivers/iommu/omap-iopgtable.h @@ -10,9 +10,6 @@ * published by the Free Software Foundation. */ -#ifndef __PLAT_OMAP_IOMMU_H -#define __PLAT_OMAP_IOMMU_H - /* * "L2 table" address mask and size definitions. */ @@ -97,24 +94,5 @@ static inline phys_addr_t omap_iommu_translate(u32 d, u32 va, u32 mask) #define iopte_index(da) (((da) >> IOPTE_SHIFT) & (PTRS_PER_IOPTE - 1)) #define iopte_offset(iopgd, da) (iopgd_page_vaddr(iopgd) + iopte_index(da)) -static inline u32 iotlb_init_entry(struct iotlb_entry *e, u32 da, u32 pa, - u32 flags) -{ - memset(e, 0, sizeof(*e)); - - e->da = da; - e->pa = pa; - e->valid = 1; - /* FIXME: add OMAP1 support */ - e->pgsz = flags & MMU_CAM_PGSZ_MASK; - e->endian = flags & MMU_RAM_ENDIAN_MASK; - e->elsz = flags & MMU_RAM_ELSZ_MASK; - e->mixed = flags & MMU_RAM_MIXED_MASK; - - return iopgsz_to_bytes(e->pgsz); -} - #define to_iommu(dev) \ (struct omap_iommu *)platform_get_drvdata(to_platform_device(dev)) - -#endif /* __PLAT_OMAP_IOMMU_H */ diff --git a/drivers/iommu/omap-iovmm.c b/drivers/iommu/omap-iovmm.c index 9852101..3e3b242 100644 --- a/drivers/iommu/omap-iovmm.c +++ b/drivers/iommu/omap-iovmm.c @@ -25,6 +25,7 @@ #include <plat/iommu.h> #include "omap-iopgtable.h" +#include "omap-iommu.h" /* * IOVMF_FLAGS: attribute for iommu virtual memory area(iovma) ^ permalink raw reply related [flat|nested] 21+ messages in thread
[parent not found: <20121025001913.2082.31062.stgit@muffinssi.local>]
* [PATCH 3/6] ARM: OMAP2+: Move plat/iovmm.h to include/linux/omap-iommu.h [not found] <20121025001913.2082.31062.stgit@muffinssi.local> @ 2012-10-25 0:20 ` Tony Lindgren 2012-10-25 8:39 ` Laurent Pinchart 0 siblings, 1 reply; 21+ messages in thread From: Tony Lindgren @ 2012-10-25 0:20 UTC (permalink / raw) To: linux-arm-kernel Cc: Ohad Ben-Cohen, Mauro Carvalho Chehab, Joerg Roedel, Laurent Pinchart, Omar Ramirez Luna, linux-omap, Ido Yariv, linux-media Looks like the iommu framework does not have generic functions exported for all the needs yet. The hardware specific functions are defined in files like intel-iommu.h and amd-iommu.h. Follow the same standard for omap-iommu.h. This is needed because we are removing plat and mach includes for ARM common zImage support. Further work should continue in the iommu framework context as only pure platform data will be communicated from arch/arm/*omap*/* code to the iommu framework. Cc: Joerg Roedel <joerg.roedel@amd.com> Cc: Ohad Ben-Cohen <ohad@wizery.com> Cc: Ido Yariv <ido@wizery.com> Cc: Laurent Pinchart <laurent.pinchart@ideasonboard.com> Cc: Omar Ramirez Luna <omar.luna@linaro.org> Cc: linux-media@vger.kernel.org Acked-by: Mauro Carvalho Chehab <mchehab@redhat.com> Signed-off-by: Tony Lindgren <tony@atomide.com> --- arch/arm/mach-omap2/iommu2.c | 1 arch/arm/plat-omap/include/plat/iommu.h | 10 +-- arch/arm/plat-omap/include/plat/iovmm.h | 89 ---------------------------- drivers/iommu/omap-iommu-debug.c | 2 - drivers/iommu/omap-iommu.c | 1 drivers/iommu/omap-iovmm.c | 46 ++++++++++++++ drivers/media/platform/omap3isp/isp.c | 1 drivers/media/platform/omap3isp/isp.h | 4 - drivers/media/platform/omap3isp/ispccdc.c | 1 drivers/media/platform/omap3isp/ispstat.c | 1 drivers/media/platform/omap3isp/ispvideo.c | 2 - include/linux/omap-iommu.h | 52 ++++++++++++++++ 12 files changed, 107 insertions(+), 103 deletions(-) delete mode 100644 arch/arm/plat-omap/include/plat/iovmm.h create mode 100644 include/linux/omap-iommu.h diff --git a/arch/arm/mach-omap2/iommu2.c b/arch/arm/mach-omap2/iommu2.c index eefc379..e8116cf 100644 --- a/arch/arm/mach-omap2/iommu2.c +++ b/arch/arm/mach-omap2/iommu2.c @@ -15,6 +15,7 @@ #include <linux/device.h> #include <linux/jiffies.h> #include <linux/module.h> +#include <linux/omap-iommu.h> #include <linux/slab.h> #include <linux/stringify.h> diff --git a/arch/arm/plat-omap/include/plat/iommu.h b/arch/arm/plat-omap/include/plat/iommu.h index 7e8c7b6..a4b71b1 100644 --- a/arch/arm/plat-omap/include/plat/iommu.h +++ b/arch/arm/plat-omap/include/plat/iommu.h @@ -216,13 +216,10 @@ static inline struct omap_iommu *dev_to_omap_iommu(struct device *dev) #define MMU_RAM_PADDR_SHIFT 12 #define MMU_RAM_PADDR_MASK \ ((~0UL >> MMU_RAM_PADDR_SHIFT) << MMU_RAM_PADDR_SHIFT) -#define MMU_RAM_ENDIAN_SHIFT 9 + #define MMU_RAM_ENDIAN_MASK (1 << MMU_RAM_ENDIAN_SHIFT) -#define MMU_RAM_ENDIAN_BIG (1 << MMU_RAM_ENDIAN_SHIFT) -#define MMU_RAM_ENDIAN_LITTLE (0 << MMU_RAM_ENDIAN_SHIFT) -#define MMU_RAM_ELSZ_SHIFT 7 #define MMU_RAM_ELSZ_MASK (3 << MMU_RAM_ELSZ_SHIFT) -#define MMU_RAM_ELSZ_8 (0 << MMU_RAM_ELSZ_SHIFT) + #define MMU_RAM_ELSZ_16 (1 << MMU_RAM_ELSZ_SHIFT) #define MMU_RAM_ELSZ_32 (2 << MMU_RAM_ELSZ_SHIFT) #define MMU_RAM_ELSZ_NONE (3 << MMU_RAM_ELSZ_SHIFT) @@ -269,9 +266,6 @@ extern int omap_iommu_set_isr(const char *name, void *priv), void *isr_priv); -extern void omap_iommu_save_ctx(struct device *dev); -extern void omap_iommu_restore_ctx(struct device *dev); - extern int omap_install_iommu_arch(const struct iommu_functions *ops); extern void omap_uninstall_iommu_arch(const struct iommu_functions *ops); diff --git a/arch/arm/plat-omap/include/plat/iovmm.h b/arch/arm/plat-omap/include/plat/iovmm.h deleted file mode 100644 index 498e57c..0000000 --- a/arch/arm/plat-omap/include/plat/iovmm.h +++ /dev/null @@ -1,89 +0,0 @@ -/* - * omap iommu: simple virtual address space management - * - * Copyright (C) 2008-2009 Nokia Corporation - * - * Written by Hiroshi DOYU <Hiroshi.DOYU@nokia.com> - * - * This program is free software; you can redistribute it and/or modify - * it under the terms of the GNU General Public License version 2 as - * published by the Free Software Foundation. - */ - -#ifndef __IOMMU_MMAP_H -#define __IOMMU_MMAP_H - -#include <linux/iommu.h> - -struct iovm_struct { - struct omap_iommu *iommu; /* iommu object which this belongs to */ - u32 da_start; /* area definition */ - u32 da_end; - u32 flags; /* IOVMF_: see below */ - struct list_head list; /* linked in ascending order */ - const struct sg_table *sgt; /* keep 'page' <-> 'da' mapping */ - void *va; /* mpu side mapped address */ -}; - -/* - * IOVMF_FLAGS: attribute for iommu virtual memory area(iovma) - * - * lower 16 bit is used for h/w and upper 16 bit is for s/w. - */ -#define IOVMF_SW_SHIFT 16 - -/* - * iovma: h/w flags derived from cam and ram attribute - */ -#define IOVMF_CAM_MASK (~((1 << 10) - 1)) -#define IOVMF_RAM_MASK (~IOVMF_CAM_MASK) - -#define IOVMF_PGSZ_MASK (3 << 0) -#define IOVMF_PGSZ_1M MMU_CAM_PGSZ_1M -#define IOVMF_PGSZ_64K MMU_CAM_PGSZ_64K -#define IOVMF_PGSZ_4K MMU_CAM_PGSZ_4K -#define IOVMF_PGSZ_16M MMU_CAM_PGSZ_16M - -#define IOVMF_ENDIAN_MASK (1 << 9) -#define IOVMF_ENDIAN_BIG MMU_RAM_ENDIAN_BIG -#define IOVMF_ENDIAN_LITTLE MMU_RAM_ENDIAN_LITTLE - -#define IOVMF_ELSZ_MASK (3 << 7) -#define IOVMF_ELSZ_8 MMU_RAM_ELSZ_8 -#define IOVMF_ELSZ_16 MMU_RAM_ELSZ_16 -#define IOVMF_ELSZ_32 MMU_RAM_ELSZ_32 -#define IOVMF_ELSZ_NONE MMU_RAM_ELSZ_NONE - -#define IOVMF_MIXED_MASK (1 << 6) -#define IOVMF_MIXED MMU_RAM_MIXED - -/* - * iovma: s/w flags, used for mapping and umapping internally. - */ -#define IOVMF_MMIO (1 << IOVMF_SW_SHIFT) -#define IOVMF_ALLOC (2 << IOVMF_SW_SHIFT) -#define IOVMF_ALLOC_MASK (3 << IOVMF_SW_SHIFT) - -/* "superpages" is supported just with physically linear pages */ -#define IOVMF_DISCONT (1 << (2 + IOVMF_SW_SHIFT)) -#define IOVMF_LINEAR (2 << (2 + IOVMF_SW_SHIFT)) -#define IOVMF_LINEAR_MASK (3 << (2 + IOVMF_SW_SHIFT)) - -#define IOVMF_DA_FIXED (1 << (4 + IOVMF_SW_SHIFT)) - - -extern struct iovm_struct *omap_find_iovm_area(struct device *dev, u32 da); -extern u32 -omap_iommu_vmap(struct iommu_domain *domain, struct device *dev, u32 da, - const struct sg_table *sgt, u32 flags); -extern struct sg_table *omap_iommu_vunmap(struct iommu_domain *domain, - struct device *dev, u32 da); -extern u32 -omap_iommu_vmalloc(struct iommu_domain *domain, struct device *dev, - u32 da, size_t bytes, u32 flags); -extern void -omap_iommu_vfree(struct iommu_domain *domain, struct device *dev, - const u32 da); -extern void *omap_da_to_va(struct device *dev, u32 da); - -#endif /* __IOMMU_MMAP_H */ diff --git a/drivers/iommu/omap-iommu-debug.c b/drivers/iommu/omap-iommu-debug.c index 0cac372..cf4a0b5 100644 --- a/drivers/iommu/omap-iommu-debug.c +++ b/drivers/iommu/omap-iommu-debug.c @@ -18,9 +18,9 @@ #include <linux/uaccess.h> #include <linux/platform_device.h> #include <linux/debugfs.h> +#include <linux/omap-iommu.h> #include <plat/iommu.h> -#include <plat/iovmm.h> #include "omap-iopgtable.h" diff --git a/drivers/iommu/omap-iommu.c b/drivers/iommu/omap-iommu.c index f2bbfb0..eadcfde 100644 --- a/drivers/iommu/omap-iommu.c +++ b/drivers/iommu/omap-iommu.c @@ -19,6 +19,7 @@ #include <linux/clk.h> #include <linux/platform_device.h> #include <linux/iommu.h> +#include <linux/omap-iommu.h> #include <linux/mutex.h> #include <linux/spinlock.h> diff --git a/drivers/iommu/omap-iovmm.c b/drivers/iommu/omap-iovmm.c index b332392..9852101 100644 --- a/drivers/iommu/omap-iovmm.c +++ b/drivers/iommu/omap-iovmm.c @@ -17,15 +17,59 @@ #include <linux/device.h> #include <linux/scatterlist.h> #include <linux/iommu.h> +#include <linux/omap-iommu.h> #include <asm/cacheflush.h> #include <asm/mach/map.h> #include <plat/iommu.h> -#include <plat/iovmm.h> #include "omap-iopgtable.h" +/* + * IOVMF_FLAGS: attribute for iommu virtual memory area(iovma) + * + * lower 16 bit is used for h/w and upper 16 bit is for s/w. + */ +#define IOVMF_SW_SHIFT 16 + +/* + * iovma: h/w flags derived from cam and ram attribute + */ +#define IOVMF_CAM_MASK (~((1 << 10) - 1)) +#define IOVMF_RAM_MASK (~IOVMF_CAM_MASK) + +#define IOVMF_PGSZ_MASK (3 << 0) +#define IOVMF_PGSZ_1M MMU_CAM_PGSZ_1M +#define IOVMF_PGSZ_64K MMU_CAM_PGSZ_64K +#define IOVMF_PGSZ_4K MMU_CAM_PGSZ_4K +#define IOVMF_PGSZ_16M MMU_CAM_PGSZ_16M + +#define IOVMF_ENDIAN_MASK (1 << 9) +#define IOVMF_ENDIAN_BIG MMU_RAM_ENDIAN_BIG + +#define IOVMF_ELSZ_MASK (3 << 7) +#define IOVMF_ELSZ_16 MMU_RAM_ELSZ_16 +#define IOVMF_ELSZ_32 MMU_RAM_ELSZ_32 +#define IOVMF_ELSZ_NONE MMU_RAM_ELSZ_NONE + +#define IOVMF_MIXED_MASK (1 << 6) +#define IOVMF_MIXED MMU_RAM_MIXED + +/* + * iovma: s/w flags, used for mapping and umapping internally. + */ +#define IOVMF_MMIO (1 << IOVMF_SW_SHIFT) +#define IOVMF_ALLOC (2 << IOVMF_SW_SHIFT) +#define IOVMF_ALLOC_MASK (3 << IOVMF_SW_SHIFT) + +/* "superpages" is supported just with physically linear pages */ +#define IOVMF_DISCONT (1 << (2 + IOVMF_SW_SHIFT)) +#define IOVMF_LINEAR (2 << (2 + IOVMF_SW_SHIFT)) +#define IOVMF_LINEAR_MASK (3 << (2 + IOVMF_SW_SHIFT)) + +#define IOVMF_DA_FIXED (1 << (4 + IOVMF_SW_SHIFT)) + static struct kmem_cache *iovm_area_cachep; /* return the offset of the first scatterlist entry in a sg table */ diff --git a/drivers/media/platform/omap3isp/isp.c b/drivers/media/platform/omap3isp/isp.c index 99640d8..7f182f0 100644 --- a/drivers/media/platform/omap3isp/isp.c +++ b/drivers/media/platform/omap3isp/isp.c @@ -61,6 +61,7 @@ #include <linux/i2c.h> #include <linux/interrupt.h> #include <linux/module.h> +#include <linux/omap-iommu.h> #include <linux/platform_device.h> #include <linux/regulator/consumer.h> #include <linux/slab.h> diff --git a/drivers/media/platform/omap3isp/isp.h b/drivers/media/platform/omap3isp/isp.h index 8be7487..8d68669 100644 --- a/drivers/media/platform/omap3isp/isp.h +++ b/drivers/media/platform/omap3isp/isp.h @@ -31,11 +31,9 @@ #include <media/v4l2-device.h> #include <linux/device.h> #include <linux/io.h> +#include <linux/iommu.h> #include <linux/platform_device.h> #include <linux/wait.h> -#include <linux/iommu.h> -#include <plat/iommu.h> -#include <plat/iovmm.h> #include "ispstat.h" #include "ispccdc.h" diff --git a/drivers/media/platform/omap3isp/ispccdc.c b/drivers/media/platform/omap3isp/ispccdc.c index 60181ab..6ae1ffb2 100644 --- a/drivers/media/platform/omap3isp/ispccdc.c +++ b/drivers/media/platform/omap3isp/ispccdc.c @@ -30,6 +30,7 @@ #include <linux/device.h> #include <linux/dma-mapping.h> #include <linux/mm.h> +#include <linux/omap-iommu.h> #include <linux/sched.h> #include <linux/slab.h> #include <media/v4l2-event.h> diff --git a/drivers/media/platform/omap3isp/ispstat.c b/drivers/media/platform/omap3isp/ispstat.c index d7ac76b..35c3823 100644 --- a/drivers/media/platform/omap3isp/ispstat.c +++ b/drivers/media/platform/omap3isp/ispstat.c @@ -26,6 +26,7 @@ */ #include <linux/dma-mapping.h> +#include <linux/omap-iommu.h> #include <linux/slab.h> #include <linux/uaccess.h> diff --git a/drivers/media/platform/omap3isp/ispvideo.c b/drivers/media/platform/omap3isp/ispvideo.c index a0b737fe..a4b8290 100644 --- a/drivers/media/platform/omap3isp/ispvideo.c +++ b/drivers/media/platform/omap3isp/ispvideo.c @@ -27,6 +27,7 @@ #include <linux/clk.h> #include <linux/mm.h> #include <linux/module.h> +#include <linux/omap-iommu.h> #include <linux/pagemap.h> #include <linux/scatterlist.h> #include <linux/sched.h> @@ -35,7 +36,6 @@ #include <media/v4l2-dev.h> #include <media/v4l2-ioctl.h> #include <plat/iommu.h> -#include <plat/iovmm.h> #include <plat/omap-pm.h> #include "ispvideo.h" diff --git a/include/linux/omap-iommu.h b/include/linux/omap-iommu.h new file mode 100644 index 0000000..cac78de --- /dev/null +++ b/include/linux/omap-iommu.h @@ -0,0 +1,52 @@ +/* + * omap iommu: simple virtual address space management + * + * Copyright (C) 2008-2009 Nokia Corporation + * + * Written by Hiroshi DOYU <Hiroshi.DOYU@nokia.com> + * + * This program is free software; you can redistribute it and/or modify + * it under the terms of the GNU General Public License version 2 as + * published by the Free Software Foundation. + */ + +#ifndef _INTEL_IOMMU_H_ +#define _INTEL_IOMMU_H_ + +struct iovm_struct { + struct omap_iommu *iommu; /* iommu object which this belongs to */ + u32 da_start; /* area definition */ + u32 da_end; + u32 flags; /* IOVMF_: see below */ + struct list_head list; /* linked in ascending order */ + const struct sg_table *sgt; /* keep 'page' <-> 'da' mapping */ + void *va; /* mpu side mapped address */ +}; + +#define MMU_RAM_ENDIAN_SHIFT 9 +#define MMU_RAM_ENDIAN_LITTLE (0 << MMU_RAM_ENDIAN_SHIFT) +#define MMU_RAM_ELSZ_8 (0 << MMU_RAM_ELSZ_SHIFT) +#define IOVMF_ENDIAN_LITTLE MMU_RAM_ENDIAN_LITTLE +#define MMU_RAM_ELSZ_SHIFT 7 +#define IOVMF_ELSZ_8 MMU_RAM_ELSZ_8 + +struct iommu_domain; + +extern struct iovm_struct *omap_find_iovm_area(struct device *dev, u32 da); +extern u32 +omap_iommu_vmap(struct iommu_domain *domain, struct device *dev, u32 da, + const struct sg_table *sgt, u32 flags); +extern struct sg_table *omap_iommu_vunmap(struct iommu_domain *domain, + struct device *dev, u32 da); +extern u32 +omap_iommu_vmalloc(struct iommu_domain *domain, struct device *dev, + u32 da, size_t bytes, u32 flags); +extern void +omap_iommu_vfree(struct iommu_domain *domain, struct device *dev, + const u32 da); +extern void *omap_da_to_va(struct device *dev, u32 da); + +extern void omap_iommu_save_ctx(struct device *dev); +extern void omap_iommu_restore_ctx(struct device *dev); + +#endif ^ permalink raw reply related [flat|nested] 21+ messages in thread
* Re: [PATCH 3/6] ARM: OMAP2+: Move plat/iovmm.h to include/linux/omap-iommu.h 2012-10-25 0:20 ` [PATCH 3/6] ARM: OMAP2+: Move plat/iovmm.h to include/linux/omap-iommu.h Tony Lindgren @ 2012-10-25 8:39 ` Laurent Pinchart 2012-10-25 16:56 ` Tony Lindgren 0 siblings, 1 reply; 21+ messages in thread From: Laurent Pinchart @ 2012-10-25 8:39 UTC (permalink / raw) To: Tony Lindgren Cc: linux-arm-kernel, Ohad Ben-Cohen, Mauro Carvalho Chehab, Joerg Roedel, Omar Ramirez Luna, linux-omap, Ido Yariv, linux-media Hi Tony, Thanks for the patch. On Wednesday 24 October 2012 17:20:56 Tony Lindgren wrote: > Looks like the iommu framework does not have generic functions > exported for all the needs yet. The hardware specific functions > are defined in files like intel-iommu.h and amd-iommu.h. Follow > the same standard for omap-iommu.h. > > This is needed because we are removing plat and mach includes > for ARM common zImage support. Further work should continue > in the iommu framework context as only pure platform data will > be communicated from arch/arm/*omap*/* code to the iommu > framework. > > Cc: Joerg Roedel <joerg.roedel@amd.com> > Cc: Ohad Ben-Cohen <ohad@wizery.com> > Cc: Ido Yariv <ido@wizery.com> > Cc: Laurent Pinchart <laurent.pinchart@ideasonboard.com> > Cc: Omar Ramirez Luna <omar.luna@linaro.org> > Cc: linux-media@vger.kernel.org > Acked-by: Mauro Carvalho Chehab <mchehab@redhat.com> > Signed-off-by: Tony Lindgren <tony@atomide.com> > --- > arch/arm/mach-omap2/iommu2.c | 1 > arch/arm/plat-omap/include/plat/iommu.h | 10 +-- > arch/arm/plat-omap/include/plat/iovmm.h | 89 > ---------------------------- drivers/iommu/omap-iommu-debug.c | > 2 - > drivers/iommu/omap-iommu.c | 1 > drivers/iommu/omap-iovmm.c | 46 ++++++++++++++ > drivers/media/platform/omap3isp/isp.c | 1 > drivers/media/platform/omap3isp/isp.h | 4 - > drivers/media/platform/omap3isp/ispccdc.c | 1 > drivers/media/platform/omap3isp/ispstat.c | 1 > drivers/media/platform/omap3isp/ispvideo.c | 2 - > include/linux/omap-iommu.h | 52 ++++++++++++++++ > 12 files changed, 107 insertions(+), 103 deletions(-) > delete mode 100644 arch/arm/plat-omap/include/plat/iovmm.h > create mode 100644 include/linux/omap-iommu.h > > diff --git a/arch/arm/mach-omap2/iommu2.c b/arch/arm/mach-omap2/iommu2.c > index eefc379..e8116cf 100644 > --- a/arch/arm/mach-omap2/iommu2.c > +++ b/arch/arm/mach-omap2/iommu2.c > @@ -15,6 +15,7 @@ > #include <linux/device.h> > #include <linux/jiffies.h> > #include <linux/module.h> > +#include <linux/omap-iommu.h> > #include <linux/slab.h> > #include <linux/stringify.h> > > diff --git a/arch/arm/plat-omap/include/plat/iommu.h > b/arch/arm/plat-omap/include/plat/iommu.h index 7e8c7b6..a4b71b1 100644 > --- a/arch/arm/plat-omap/include/plat/iommu.h > +++ b/arch/arm/plat-omap/include/plat/iommu.h > @@ -216,13 +216,10 @@ static inline struct omap_iommu > *dev_to_omap_iommu(struct device *dev) #define MMU_RAM_PADDR_SHIFT 12 > #define MMU_RAM_PADDR_MASK \ > ((~0UL >> MMU_RAM_PADDR_SHIFT) << MMU_RAM_PADDR_SHIFT) > -#define MMU_RAM_ENDIAN_SHIFT 9 > + > #define MMU_RAM_ENDIAN_MASK (1 << MMU_RAM_ENDIAN_SHIFT) > -#define MMU_RAM_ENDIAN_BIG (1 << MMU_RAM_ENDIAN_SHIFT) > -#define MMU_RAM_ENDIAN_LITTLE (0 << MMU_RAM_ENDIAN_SHIFT) > -#define MMU_RAM_ELSZ_SHIFT 7 > #define MMU_RAM_ELSZ_MASK (3 << MMU_RAM_ELSZ_SHIFT) > -#define MMU_RAM_ELSZ_8 (0 << MMU_RAM_ELSZ_SHIFT) > + > #define MMU_RAM_ELSZ_16 (1 << MMU_RAM_ELSZ_SHIFT) > #define MMU_RAM_ELSZ_32 (2 << MMU_RAM_ELSZ_SHIFT) > #define MMU_RAM_ELSZ_NONE (3 << MMU_RAM_ELSZ_SHIFT) > @@ -269,9 +266,6 @@ extern int omap_iommu_set_isr(const char *name, > void *priv), > void *isr_priv); > > -extern void omap_iommu_save_ctx(struct device *dev); > -extern void omap_iommu_restore_ctx(struct device *dev); > - > extern int omap_install_iommu_arch(const struct iommu_functions *ops); > extern void omap_uninstall_iommu_arch(const struct iommu_functions *ops); > > diff --git a/arch/arm/plat-omap/include/plat/iovmm.h > b/arch/arm/plat-omap/include/plat/iovmm.h deleted file mode 100644 > index 498e57c..0000000 > --- a/arch/arm/plat-omap/include/plat/iovmm.h > +++ /dev/null > @@ -1,89 +0,0 @@ > -/* > - * omap iommu: simple virtual address space management > - * > - * Copyright (C) 2008-2009 Nokia Corporation > - * > - * Written by Hiroshi DOYU <Hiroshi.DOYU@nokia.com> > - * > - * This program is free software; you can redistribute it and/or modify > - * it under the terms of the GNU General Public License version 2 as > - * published by the Free Software Foundation. > - */ > - > -#ifndef __IOMMU_MMAP_H > -#define __IOMMU_MMAP_H > - > -#include <linux/iommu.h> > - > -struct iovm_struct { > - struct omap_iommu *iommu; /* iommu object which this belongs to */ > - u32 da_start; /* area definition */ > - u32 da_end; > - u32 flags; /* IOVMF_: see below */ > - struct list_head list; /* linked in ascending order */ > - const struct sg_table *sgt; /* keep 'page' <-> 'da' mapping */ > - void *va; /* mpu side mapped address */ > -}; > - > -/* > - * IOVMF_FLAGS: attribute for iommu virtual memory area(iovma) > - * > - * lower 16 bit is used for h/w and upper 16 bit is for s/w. > - */ > -#define IOVMF_SW_SHIFT 16 > - > -/* > - * iovma: h/w flags derived from cam and ram attribute > - */ > -#define IOVMF_CAM_MASK (~((1 << 10) - 1)) > -#define IOVMF_RAM_MASK (~IOVMF_CAM_MASK) > - > -#define IOVMF_PGSZ_MASK (3 << 0) > -#define IOVMF_PGSZ_1M MMU_CAM_PGSZ_1M > -#define IOVMF_PGSZ_64K MMU_CAM_PGSZ_64K > -#define IOVMF_PGSZ_4K MMU_CAM_PGSZ_4K > -#define IOVMF_PGSZ_16M MMU_CAM_PGSZ_16M > - > -#define IOVMF_ENDIAN_MASK (1 << 9) > -#define IOVMF_ENDIAN_BIG MMU_RAM_ENDIAN_BIG > -#define IOVMF_ENDIAN_LITTLE MMU_RAM_ENDIAN_LITTLE > - > -#define IOVMF_ELSZ_MASK (3 << 7) > -#define IOVMF_ELSZ_8 MMU_RAM_ELSZ_8 > -#define IOVMF_ELSZ_16 MMU_RAM_ELSZ_16 > -#define IOVMF_ELSZ_32 MMU_RAM_ELSZ_32 > -#define IOVMF_ELSZ_NONE MMU_RAM_ELSZ_NONE > - > -#define IOVMF_MIXED_MASK (1 << 6) > -#define IOVMF_MIXED MMU_RAM_MIXED > - > -/* > - * iovma: s/w flags, used for mapping and umapping internally. > - */ > -#define IOVMF_MMIO (1 << IOVMF_SW_SHIFT) > -#define IOVMF_ALLOC (2 << IOVMF_SW_SHIFT) > -#define IOVMF_ALLOC_MASK (3 << IOVMF_SW_SHIFT) > - > -/* "superpages" is supported just with physically linear pages */ > -#define IOVMF_DISCONT (1 << (2 + IOVMF_SW_SHIFT)) > -#define IOVMF_LINEAR (2 << (2 + IOVMF_SW_SHIFT)) > -#define IOVMF_LINEAR_MASK (3 << (2 + IOVMF_SW_SHIFT)) > - > -#define IOVMF_DA_FIXED (1 << (4 + IOVMF_SW_SHIFT)) > - > - > -extern struct iovm_struct *omap_find_iovm_area(struct device *dev, u32 da); > -extern u32 > -omap_iommu_vmap(struct iommu_domain *domain, struct device *dev, u32 da, > - const struct sg_table *sgt, u32 flags); > -extern struct sg_table *omap_iommu_vunmap(struct iommu_domain *domain, > - struct device *dev, u32 da); > -extern u32 > -omap_iommu_vmalloc(struct iommu_domain *domain, struct device *dev, > - u32 da, size_t bytes, u32 flags); > -extern void > -omap_iommu_vfree(struct iommu_domain *domain, struct device *dev, > - const u32 da); > -extern void *omap_da_to_va(struct device *dev, u32 da); > - > -#endif /* __IOMMU_MMAP_H */ > diff --git a/drivers/iommu/omap-iommu-debug.c > b/drivers/iommu/omap-iommu-debug.c index 0cac372..cf4a0b5 100644 > --- a/drivers/iommu/omap-iommu-debug.c > +++ b/drivers/iommu/omap-iommu-debug.c > @@ -18,9 +18,9 @@ > #include <linux/uaccess.h> > #include <linux/platform_device.h> > #include <linux/debugfs.h> > +#include <linux/omap-iommu.h> > > #include <plat/iommu.h> > -#include <plat/iovmm.h> > > #include "omap-iopgtable.h" > > diff --git a/drivers/iommu/omap-iommu.c b/drivers/iommu/omap-iommu.c > index f2bbfb0..eadcfde 100644 > --- a/drivers/iommu/omap-iommu.c > +++ b/drivers/iommu/omap-iommu.c > @@ -19,6 +19,7 @@ > #include <linux/clk.h> > #include <linux/platform_device.h> > #include <linux/iommu.h> > +#include <linux/omap-iommu.h> > #include <linux/mutex.h> > #include <linux/spinlock.h> > > diff --git a/drivers/iommu/omap-iovmm.c b/drivers/iommu/omap-iovmm.c > index b332392..9852101 100644 > --- a/drivers/iommu/omap-iovmm.c > +++ b/drivers/iommu/omap-iovmm.c > @@ -17,15 +17,59 @@ > #include <linux/device.h> > #include <linux/scatterlist.h> > #include <linux/iommu.h> > +#include <linux/omap-iommu.h> > > #include <asm/cacheflush.h> > #include <asm/mach/map.h> > > #include <plat/iommu.h> > -#include <plat/iovmm.h> > > #include "omap-iopgtable.h" > > +/* > + * IOVMF_FLAGS: attribute for iommu virtual memory area(iovma) > + * > + * lower 16 bit is used for h/w and upper 16 bit is for s/w. > + */ > +#define IOVMF_SW_SHIFT 16 > + > +/* > + * iovma: h/w flags derived from cam and ram attribute > + */ > +#define IOVMF_CAM_MASK (~((1 << 10) - 1)) > +#define IOVMF_RAM_MASK (~IOVMF_CAM_MASK) > + > +#define IOVMF_PGSZ_MASK (3 << 0) > +#define IOVMF_PGSZ_1M MMU_CAM_PGSZ_1M > +#define IOVMF_PGSZ_64K MMU_CAM_PGSZ_64K > +#define IOVMF_PGSZ_4K MMU_CAM_PGSZ_4K > +#define IOVMF_PGSZ_16M MMU_CAM_PGSZ_16M > + > +#define IOVMF_ENDIAN_MASK (1 << 9) > +#define IOVMF_ENDIAN_BIG MMU_RAM_ENDIAN_BIG > + > +#define IOVMF_ELSZ_MASK (3 << 7) > +#define IOVMF_ELSZ_16 MMU_RAM_ELSZ_16 > +#define IOVMF_ELSZ_32 MMU_RAM_ELSZ_32 > +#define IOVMF_ELSZ_NONE MMU_RAM_ELSZ_NONE > + > +#define IOVMF_MIXED_MASK (1 << 6) > +#define IOVMF_MIXED MMU_RAM_MIXED > + > +/* > + * iovma: s/w flags, used for mapping and umapping internally. > + */ > +#define IOVMF_MMIO (1 << IOVMF_SW_SHIFT) > +#define IOVMF_ALLOC (2 << IOVMF_SW_SHIFT) > +#define IOVMF_ALLOC_MASK (3 << IOVMF_SW_SHIFT) > + > +/* "superpages" is supported just with physically linear pages */ > +#define IOVMF_DISCONT (1 << (2 + IOVMF_SW_SHIFT)) > +#define IOVMF_LINEAR (2 << (2 + IOVMF_SW_SHIFT)) > +#define IOVMF_LINEAR_MASK (3 << (2 + IOVMF_SW_SHIFT)) > + > +#define IOVMF_DA_FIXED (1 << (4 + IOVMF_SW_SHIFT)) > + > static struct kmem_cache *iovm_area_cachep; > > /* return the offset of the first scatterlist entry in a sg table */ > diff --git a/drivers/media/platform/omap3isp/isp.c > b/drivers/media/platform/omap3isp/isp.c index 99640d8..7f182f0 100644 > --- a/drivers/media/platform/omap3isp/isp.c > +++ b/drivers/media/platform/omap3isp/isp.c > @@ -61,6 +61,7 @@ > #include <linux/i2c.h> > #include <linux/interrupt.h> > #include <linux/module.h> > +#include <linux/omap-iommu.h> > #include <linux/platform_device.h> > #include <linux/regulator/consumer.h> > #include <linux/slab.h> > diff --git a/drivers/media/platform/omap3isp/isp.h > b/drivers/media/platform/omap3isp/isp.h index 8be7487..8d68669 100644 > --- a/drivers/media/platform/omap3isp/isp.h > +++ b/drivers/media/platform/omap3isp/isp.h > @@ -31,11 +31,9 @@ > #include <media/v4l2-device.h> > #include <linux/device.h> > #include <linux/io.h> > +#include <linux/iommu.h> > #include <linux/platform_device.h> > #include <linux/wait.h> > -#include <linux/iommu.h> > -#include <plat/iommu.h> > -#include <plat/iovmm.h> > > #include "ispstat.h" > #include "ispccdc.h" > diff --git a/drivers/media/platform/omap3isp/ispccdc.c > b/drivers/media/platform/omap3isp/ispccdc.c index 60181ab..6ae1ffb2 100644 > --- a/drivers/media/platform/omap3isp/ispccdc.c > +++ b/drivers/media/platform/omap3isp/ispccdc.c > @@ -30,6 +30,7 @@ > #include <linux/device.h> > #include <linux/dma-mapping.h> > #include <linux/mm.h> > +#include <linux/omap-iommu.h> > #include <linux/sched.h> > #include <linux/slab.h> > #include <media/v4l2-event.h> > diff --git a/drivers/media/platform/omap3isp/ispstat.c > b/drivers/media/platform/omap3isp/ispstat.c index d7ac76b..35c3823 100644 > --- a/drivers/media/platform/omap3isp/ispstat.c > +++ b/drivers/media/platform/omap3isp/ispstat.c > @@ -26,6 +26,7 @@ > */ > > #include <linux/dma-mapping.h> > +#include <linux/omap-iommu.h> > #include <linux/slab.h> > #include <linux/uaccess.h> > > diff --git a/drivers/media/platform/omap3isp/ispvideo.c > b/drivers/media/platform/omap3isp/ispvideo.c index a0b737fe..a4b8290 100644 > --- a/drivers/media/platform/omap3isp/ispvideo.c > +++ b/drivers/media/platform/omap3isp/ispvideo.c > @@ -27,6 +27,7 @@ > #include <linux/clk.h> > #include <linux/mm.h> > #include <linux/module.h> > +#include <linux/omap-iommu.h> > #include <linux/pagemap.h> > #include <linux/scatterlist.h> > #include <linux/sched.h> > @@ -35,7 +36,6 @@ > #include <media/v4l2-dev.h> > #include <media/v4l2-ioctl.h> > #include <plat/iommu.h> > -#include <plat/iovmm.h> > #include <plat/omap-pm.h> > > #include "ispvideo.h" > diff --git a/include/linux/omap-iommu.h b/include/linux/omap-iommu.h > new file mode 100644 > index 0000000..cac78de > --- /dev/null > +++ b/include/linux/omap-iommu.h > @@ -0,0 +1,52 @@ > +/* > + * omap iommu: simple virtual address space management > + * > + * Copyright (C) 2008-2009 Nokia Corporation > + * > + * Written by Hiroshi DOYU <Hiroshi.DOYU@nokia.com> > + * > + * This program is free software; you can redistribute it and/or modify > + * it under the terms of the GNU General Public License version 2 as > + * published by the Free Software Foundation. > + */ > + > +#ifndef _INTEL_IOMMU_H_ > +#define _INTEL_IOMMU_H_ > + > +struct iovm_struct { > + struct omap_iommu *iommu; /* iommu object which this belongs to */ > + u32 da_start; /* area definition */ > + u32 da_end; > + u32 flags; /* IOVMF_: see below */ > + struct list_head list; /* linked in ascending order */ > + const struct sg_table *sgt; /* keep 'page' <-> 'da' mapping */ > + void *va; /* mpu side mapped address */ > +}; > + > +#define MMU_RAM_ENDIAN_SHIFT 9 > +#define MMU_RAM_ENDIAN_LITTLE (0 << MMU_RAM_ENDIAN_SHIFT) > +#define MMU_RAM_ELSZ_8 (0 << MMU_RAM_ELSZ_SHIFT) > +#define IOVMF_ENDIAN_LITTLE MMU_RAM_ENDIAN_LITTLE > +#define MMU_RAM_ELSZ_SHIFT 7 > +#define IOVMF_ELSZ_8 MMU_RAM_ELSZ_8 > + > +struct iommu_domain; > + > +extern struct iovm_struct *omap_find_iovm_area(struct device *dev, u32 da); > +extern u32 > +omap_iommu_vmap(struct iommu_domain *domain, struct device *dev, u32 da, > + const struct sg_table *sgt, u32 flags); > +extern struct sg_table *omap_iommu_vunmap(struct iommu_domain *domain, > + struct device *dev, u32 da); > +extern u32 > +omap_iommu_vmalloc(struct iommu_domain *domain, struct device *dev, > + u32 da, size_t bytes, u32 flags); > +extern void > +omap_iommu_vfree(struct iommu_domain *domain, struct device *dev, > + const u32 da); > +extern void *omap_da_to_va(struct device *dev, u32 da); > + > +extern void omap_iommu_save_ctx(struct device *dev); > +extern void omap_iommu_restore_ctx(struct device *dev); > + > +#endif I still think you should split this in two files, omap-iommu.h and omap- iovmm.h. The later would just be arch/arm/plat-omap/include/plat/iovmm.h moved to include/linux.h. -- Regards, Laurent Pinchart ^ permalink raw reply [flat|nested] 21+ messages in thread
* Re: [PATCH 3/6] ARM: OMAP2+: Move plat/iovmm.h to include/linux/omap-iommu.h 2012-10-25 8:39 ` Laurent Pinchart @ 2012-10-25 16:56 ` Tony Lindgren 2012-10-25 20:22 ` Laurent Pinchart 0 siblings, 1 reply; 21+ messages in thread From: Tony Lindgren @ 2012-10-25 16:56 UTC (permalink / raw) To: Laurent Pinchart Cc: linux-arm-kernel, Ohad Ben-Cohen, Mauro Carvalho Chehab, Joerg Roedel, Omar Ramirez Luna, linux-omap, Ido Yariv, linux-media * Laurent Pinchart <laurent.pinchart@ideasonboard.com> [121025 01:39]: > > I still think you should split this in two files, omap-iommu.h and omap- > iovmm.h. The later would just be arch/arm/plat-omap/include/plat/iovmm.h moved > to include/linux.h. Can you please explain a bit more why you're thinking a separate omap-iovmm.h is needed in addtion to omap-iommu.h? My reasoning for not adding it is that neither intel nor amd needs more than intel-iommu.h and amd-iommu.h. And hopefully the iommu framework will eventually provide the API needed. And I'd rather not be the person introducing this second new file into include/linux :) Joerg and Ohad, do you have any opinions on this? Regards, Tony ^ permalink raw reply [flat|nested] 21+ messages in thread
* Re: [PATCH 3/6] ARM: OMAP2+: Move plat/iovmm.h to include/linux/omap-iommu.h 2012-10-25 16:56 ` Tony Lindgren @ 2012-10-25 20:22 ` Laurent Pinchart 2012-10-25 21:39 ` Tony Lindgren 0 siblings, 1 reply; 21+ messages in thread From: Laurent Pinchart @ 2012-10-25 20:22 UTC (permalink / raw) To: Tony Lindgren Cc: linux-arm-kernel, Ohad Ben-Cohen, Mauro Carvalho Chehab, Joerg Roedel, Omar Ramirez Luna, linux-omap, Ido Yariv, linux-media Hi Tony, On Thursday 25 October 2012 09:56:44 Tony Lindgren wrote: > * Laurent Pinchart <laurent.pinchart@ideasonboard.com> [121025 01:39]: > > I still think you should split this in two files, omap-iommu.h and omap- > > iovmm.h. The later would just be arch/arm/plat-omap/include/plat/iovmm.h > > moved to include/linux.h. > > Can you please explain a bit more why you're thinking a separate > omap-iovmm.h is needed in addtion to omap-iommu.h? The IOVMM API is layered top of the IOMMU API. It's really a separate API, so two header files make sense. This patch creates a hybrid omap-iommu.h header with mixed definitions, it just doesn't feel right :-) I won't insist for a split though, if you think it's better to have a single header we can keep it that way. > My reasoning for not adding it is that neither intel nor amd needs > more than intel-iommu.h and amd-iommu.h. And hopefully the iommu > framework will eventually provide the API needed. And I'd rather > not be the person introducing this second new file into > include/linux :) > > Joerg and Ohad, do you have any opinions on this? -- Regards, Laurent Pinchart ^ permalink raw reply [flat|nested] 21+ messages in thread
* Re: [PATCH 3/6] ARM: OMAP2+: Move plat/iovmm.h to include/linux/omap-iommu.h 2012-10-25 20:22 ` Laurent Pinchart @ 2012-10-25 21:39 ` Tony Lindgren 2012-10-26 5:50 ` Ohad Ben-Cohen 0 siblings, 1 reply; 21+ messages in thread From: Tony Lindgren @ 2012-10-25 21:39 UTC (permalink / raw) To: Laurent Pinchart Cc: linux-arm-kernel, Ohad Ben-Cohen, Mauro Carvalho Chehab, Joerg Roedel, Omar Ramirez Luna, linux-omap, Ido Yariv, linux-media * Laurent Pinchart <laurent.pinchart@ideasonboard.com> [121025 13:23]: > Hi Tony, > > On Thursday 25 October 2012 09:56:44 Tony Lindgren wrote: > > * Laurent Pinchart <laurent.pinchart@ideasonboard.com> [121025 01:39]: > > > I still think you should split this in two files, omap-iommu.h and omap- > > > iovmm.h. The later would just be arch/arm/plat-omap/include/plat/iovmm.h > > > moved to include/linux.h. > > > > Can you please explain a bit more why you're thinking a separate > > omap-iovmm.h is needed in addtion to omap-iommu.h? > > The IOVMM API is layered top of the IOMMU API. It's really a separate API, so > two header files make sense. This patch creates a hybrid omap-iommu.h header > with mixed definitions, it just doesn't feel right :-) I won't insist for a > split though, if you think it's better to have a single header we can keep it > that way. Yes it's true it's a separate layer. But it's still iommu specific. The functions exported by omap-iovmm.c have iommu_ prefix in the name except for one: drivers/iommu/omap-iovmm.c:EXPORT_SYMBOL_GPL(omap_find_iovm_area); drivers/iommu/omap-iovmm.c:EXPORT_SYMBOL_GPL(omap_da_to_va); drivers/iommu/omap-iovmm.c:EXPORT_SYMBOL_GPL(omap_iommu_vmap); drivers/iommu/omap-iovmm.c:EXPORT_SYMBOL_GPL(omap_iommu_vunmap); drivers/iommu/omap-iovmm.c:EXPORT_SYMBOL_GPL(omap_iommu_vmalloc); drivers/iommu/omap-iovmm.c:EXPORT_SYMBOL_GPL(omap_iommu_vfree); So it should be OK to keep it all in omap-iommu.h file. Let's see hear what.. > > My reasoning for not adding it is that neither intel nor amd needs > > more than intel-iommu.h and amd-iommu.h. And hopefully the iommu > > framework will eventually provide the API needed. And I'd rather > > not be the person introducing this second new file into > > include/linux :) > > > > Joerg and Ohad, do you have any opinions on this? ..Joerg and Ohad say. Regards, Tony ^ permalink raw reply [flat|nested] 21+ messages in thread
* Re: [PATCH 3/6] ARM: OMAP2+: Move plat/iovmm.h to include/linux/omap-iommu.h 2012-10-25 21:39 ` Tony Lindgren @ 2012-10-26 5:50 ` Ohad Ben-Cohen 2012-10-26 9:35 ` Laurent Pinchart 0 siblings, 1 reply; 21+ messages in thread From: Ohad Ben-Cohen @ 2012-10-26 5:50 UTC (permalink / raw) To: Tony Lindgren Cc: Laurent Pinchart, linux-arm-kernel, Mauro Carvalho Chehab, Joerg Roedel, Omar Ramirez Luna, linux-omap, Ido Yariv, linux-media On Thu, Oct 25, 2012 at 11:39 PM, Tony Lindgren <tony@atomide.com> wrote: >> > Joerg and Ohad, do you have any opinions on this? I agree that there's some merit in having a separate header file for IOVMM, since it's a different layer from the IOMMU API. But in reality it's tightly coupled with OMAP's IOMMU, and ideally it really should go away and be replaced with the DMA API. For this reason, and for the fact that anyway there's only a single user for it (omap3isp) and there will never be any more, maybe we shouldn't pollute include/linux anymore. Anyone volunteering to remove IOVMM and adapt omap3isp to the DMA API instead ? ;) Thanks, Ohad. ^ permalink raw reply [flat|nested] 21+ messages in thread
* Re: [PATCH 3/6] ARM: OMAP2+: Move plat/iovmm.h to include/linux/omap-iommu.h 2012-10-26 5:50 ` Ohad Ben-Cohen @ 2012-10-26 9:35 ` Laurent Pinchart 2012-10-26 9:54 ` Ohad Ben-Cohen 0 siblings, 1 reply; 21+ messages in thread From: Laurent Pinchart @ 2012-10-26 9:35 UTC (permalink / raw) To: Ohad Ben-Cohen Cc: Tony Lindgren, linux-arm-kernel, Mauro Carvalho Chehab, Joerg Roedel, Omar Ramirez Luna, linux-omap, Ido Yariv, linux-media Hi Ohad, On Friday 26 October 2012 07:50:56 Ohad Ben-Cohen wrote: > On Thu, Oct 25, 2012 at 11:39 PM, Tony Lindgren <tony@atomide.com> wrote: > >> > Joerg and Ohad, do you have any opinions on this? > > I agree that there's some merit in having a separate header file for > IOVMM, since it's a different layer from the IOMMU API. > > But in reality it's tightly coupled with OMAP's IOMMU, and ideally it > really should go away and be replaced with the DMA API. > > For this reason, and for the fact that anyway there's only a single > user for it (omap3isp) and there will never be any more, maybe we > shouldn't pollute include/linux anymore. > > Anyone volunteering to remove IOVMM and adapt omap3isp to the DMA API > instead ? ;) That's on my to-do list, as well as porting the OMAP3 ISP driver to videobuf2, adding DT support, moving to the common clock framework (when that will be available for the OMAP3), supporting missing V4L2 features, ... All this in my spare time of course, otherwise it wouldn't be fun, would it ? ;-) I would also like to move the tidspbridge to the DMA API, but I think we'll need to move step by step there, and using the OMAP IOMMU and IOVMM APIs as an intermediate step would allow splitting patches in reviewable chunks. I know it's a step backwards in term of OMAP IOMMU usage, but that's in my opinion a temporary nuisance to make the leap easier. -- Regards, Laurent Pinchart ^ permalink raw reply [flat|nested] 21+ messages in thread
* Re: [PATCH 3/6] ARM: OMAP2+: Move plat/iovmm.h to include/linux/omap-iommu.h 2012-10-26 9:35 ` Laurent Pinchart @ 2012-10-26 9:54 ` Ohad Ben-Cohen 2012-10-26 18:00 ` Tony Lindgren 0 siblings, 1 reply; 21+ messages in thread From: Ohad Ben-Cohen @ 2012-10-26 9:54 UTC (permalink / raw) To: Laurent Pinchart Cc: Tony Lindgren, linux-arm-kernel, Mauro Carvalho Chehab, Joerg Roedel, Omar Ramirez Luna, linux-omap, Ido Yariv, linux-media Hi Laurent, On Fri, Oct 26, 2012 at 11:35 AM, Laurent Pinchart <laurent.pinchart@ideasonboard.com> wrote: > That's on my to-do list, as well as porting the OMAP3 ISP driver to videobuf2, > adding DT support, moving to the common clock framework (when that will be > available for the OMAP3), supporting missing V4L2 features, ... All this in my > spare time of course, otherwise it wouldn't be fun, would it ? ;-) Hmm, seems like a short to-do list ;) > I would also like to move the tidspbridge to the DMA API, but I think we'll > need to move step by step there, and using the OMAP IOMMU and IOVMM APIs as an > intermediate step would allow splitting patches in reviewable chunks. I know > it's a step backwards in term of OMAP IOMMU usage, but that's in my opinion a > temporary nuisance to make the leap easier. Since tidspbridge is in staging I guess it's not a problem, though it sounds to me like using the correct API in the first place is going to make less churn. Thanks, Ohad. ^ permalink raw reply [flat|nested] 21+ messages in thread
* Re: [PATCH 3/6] ARM: OMAP2+: Move plat/iovmm.h to include/linux/omap-iommu.h 2012-10-26 9:54 ` Ohad Ben-Cohen @ 2012-10-26 18:00 ` Tony Lindgren 2012-10-30 16:29 ` Tony Lindgren 0 siblings, 1 reply; 21+ messages in thread From: Tony Lindgren @ 2012-10-26 18:00 UTC (permalink / raw) To: Ohad Ben-Cohen Cc: Laurent Pinchart, linux-arm-kernel, Mauro Carvalho Chehab, Joerg Roedel, Omar Ramirez Luna, linux-omap, Ido Yariv, linux-media * Ohad Ben-Cohen <ohad@wizery.com> [121026 02:56]: > Hi Laurent, > > On Fri, Oct 26, 2012 at 11:35 AM, Laurent Pinchart > <laurent.pinchart@ideasonboard.com> wrote: > > That's on my to-do list, as well as porting the OMAP3 ISP driver to videobuf2, > > adding DT support, moving to the common clock framework (when that will be > > available for the OMAP3), supporting missing V4L2 features, ... All this in my > > spare time of course, otherwise it wouldn't be fun, would it ? ;-) > > Hmm, seems like a short to-do list ;) Sounds Laurent will take care of it :) > > I would also like to move the tidspbridge to the DMA API, but I think we'll > > need to move step by step there, and using the OMAP IOMMU and IOVMM APIs as an > > intermediate step would allow splitting patches in reviewable chunks. I know > > it's a step backwards in term of OMAP IOMMU usage, but that's in my opinion a > > temporary nuisance to make the leap easier. > > Since tidspbridge is in staging I guess it's not a problem, though it > sounds to me like using the correct API in the first place is going to > make less churn. Not related to these patches, but also sounds like we may need to drop some staging/tidspbridge code to be able to move forward with the ARM common zImage plans. See the "[GIT PULL] omap plat header removal for v3.8 merge window, part1" thread for more info. Regards, Tony ^ permalink raw reply [flat|nested] 21+ messages in thread
* Re: [PATCH 3/6] ARM: OMAP2+: Move plat/iovmm.h to include/linux/omap-iommu.h 2012-10-26 18:00 ` Tony Lindgren @ 2012-10-30 16:29 ` Tony Lindgren 2012-11-02 18:55 ` Tony Lindgren 0 siblings, 1 reply; 21+ messages in thread From: Tony Lindgren @ 2012-10-30 16:29 UTC (permalink / raw) To: Ohad Ben-Cohen Cc: Laurent Pinchart, linux-arm-kernel, Mauro Carvalho Chehab, Joerg Roedel, Omar Ramirez Luna, linux-omap, Ido Yariv, linux-media * Tony Lindgren <tony@atomide.com> [121026 11:02]: > * Ohad Ben-Cohen <ohad@wizery.com> [121026 02:56]: > > Hi Laurent, > > > > On Fri, Oct 26, 2012 at 11:35 AM, Laurent Pinchart > > <laurent.pinchart@ideasonboard.com> wrote: > > > That's on my to-do list, as well as porting the OMAP3 ISP driver to videobuf2, > > > adding DT support, moving to the common clock framework (when that will be > > > available for the OMAP3), supporting missing V4L2 features, ... All this in my > > > spare time of course, otherwise it wouldn't be fun, would it ? ;-) > > > > Hmm, seems like a short to-do list ;) > > Sounds Laurent will take care of it :) > > > > I would also like to move the tidspbridge to the DMA API, but I think we'll > > > need to move step by step there, and using the OMAP IOMMU and IOVMM APIs as an > > > intermediate step would allow splitting patches in reviewable chunks. I know > > > it's a step backwards in term of OMAP IOMMU usage, but that's in my opinion a > > > temporary nuisance to make the leap easier. > > > > Since tidspbridge is in staging I guess it's not a problem, though it > > sounds to me like using the correct API in the first place is going to > > make less churn. > > Not related to these patches, but also sounds like we may need to drop > some staging/tidspbridge code to be able to move forward with the > ARM common zImage plans. See the "[GIT PULL] omap plat header removal > for v3.8 merge window, part1" thread for more info. OK so are people happy with the patches in this series? Please everybody ack if no more comments so we can move on towards getting CONFIG_MULTIPLATFORM to work for omaps. Regards, Tony ^ permalink raw reply [flat|nested] 21+ messages in thread
* Re: [PATCH 3/6] ARM: OMAP2+: Move plat/iovmm.h to include/linux/omap-iommu.h 2012-10-30 16:29 ` Tony Lindgren @ 2012-11-02 18:55 ` Tony Lindgren 0 siblings, 0 replies; 21+ messages in thread From: Tony Lindgren @ 2012-11-02 18:55 UTC (permalink / raw) To: Ohad Ben-Cohen Cc: Laurent Pinchart, linux-arm-kernel, Mauro Carvalho Chehab, Joerg Roedel, Omar Ramirez Luna, linux-omap, Ido Yariv, linux-media * Tony Lindgren <tony@atomide.com> [121030 09:31]: > > OK so are people happy with the patches in this series? > > Please everybody ack if no more comments so we can move on > towards getting CONFIG_MULTIPLATFORM to work for omaps. Looks like Joerg has a new email address, I'll send this series out one more time. Regards, Tony ^ permalink raw reply [flat|nested] 21+ messages in thread
[parent not found: <20121102192221.4253.34303.stgit@muffinssi.local>]
* [PATCH 3/6] ARM: OMAP2+: Move plat/iovmm.h to include/linux/omap-iommu.h [not found] <20121102192221.4253.34303.stgit@muffinssi.local> @ 2012-11-02 19:24 ` Tony Lindgren 0 siblings, 0 replies; 21+ messages in thread From: Tony Lindgren @ 2012-11-02 19:24 UTC (permalink / raw) To: linux-kernel Cc: Ohad Ben-Cohen, Mauro Carvalho Chehab, Joerg Roedel, Laurent Pinchart, Omar Ramirez Luna, linux-omap, Ido Yariv, linux-arm-kernel, linux-media Looks like the iommu framework does not have generic functions exported for all the needs yet. The hardware specific functions are defined in files like intel-iommu.h and amd-iommu.h. Follow the same standard for omap-iommu.h. This is needed because we are removing plat and mach includes for ARM common zImage support. Further work should continue in the iommu framework context as only pure platform data will be communicated from arch/arm/*omap*/* code to the iommu framework. Cc: Joerg Roedel <joro@8bytes.org> Cc: Ohad Ben-Cohen <ohad@wizery.com> Cc: Ido Yariv <ido@wizery.com> Cc: Laurent Pinchart <laurent.pinchart@ideasonboard.com> Cc: Omar Ramirez Luna <omar.luna@linaro.org> Cc: linux-media@vger.kernel.org Acked-by: Mauro Carvalho Chehab <mchehab@redhat.com> Signed-off-by: Tony Lindgren <tony@atomide.com> --- arch/arm/mach-omap2/iommu2.c | 1 arch/arm/plat-omap/include/plat/iommu.h | 10 +-- arch/arm/plat-omap/include/plat/iovmm.h | 89 ---------------------------- drivers/iommu/omap-iommu-debug.c | 2 - drivers/iommu/omap-iommu.c | 1 drivers/iommu/omap-iovmm.c | 46 ++++++++++++++ drivers/media/platform/omap3isp/isp.c | 1 drivers/media/platform/omap3isp/isp.h | 4 - drivers/media/platform/omap3isp/ispccdc.c | 1 drivers/media/platform/omap3isp/ispstat.c | 1 drivers/media/platform/omap3isp/ispvideo.c | 2 - include/linux/omap-iommu.h | 52 ++++++++++++++++ 12 files changed, 107 insertions(+), 103 deletions(-) delete mode 100644 arch/arm/plat-omap/include/plat/iovmm.h create mode 100644 include/linux/omap-iommu.h diff --git a/arch/arm/mach-omap2/iommu2.c b/arch/arm/mach-omap2/iommu2.c index eefc379..e8116cf 100644 --- a/arch/arm/mach-omap2/iommu2.c +++ b/arch/arm/mach-omap2/iommu2.c @@ -15,6 +15,7 @@ #include <linux/device.h> #include <linux/jiffies.h> #include <linux/module.h> +#include <linux/omap-iommu.h> #include <linux/slab.h> #include <linux/stringify.h> diff --git a/arch/arm/plat-omap/include/plat/iommu.h b/arch/arm/plat-omap/include/plat/iommu.h index 7e8c7b6..a4b71b1 100644 --- a/arch/arm/plat-omap/include/plat/iommu.h +++ b/arch/arm/plat-omap/include/plat/iommu.h @@ -216,13 +216,10 @@ static inline struct omap_iommu *dev_to_omap_iommu(struct device *dev) #define MMU_RAM_PADDR_SHIFT 12 #define MMU_RAM_PADDR_MASK \ ((~0UL >> MMU_RAM_PADDR_SHIFT) << MMU_RAM_PADDR_SHIFT) -#define MMU_RAM_ENDIAN_SHIFT 9 + #define MMU_RAM_ENDIAN_MASK (1 << MMU_RAM_ENDIAN_SHIFT) -#define MMU_RAM_ENDIAN_BIG (1 << MMU_RAM_ENDIAN_SHIFT) -#define MMU_RAM_ENDIAN_LITTLE (0 << MMU_RAM_ENDIAN_SHIFT) -#define MMU_RAM_ELSZ_SHIFT 7 #define MMU_RAM_ELSZ_MASK (3 << MMU_RAM_ELSZ_SHIFT) -#define MMU_RAM_ELSZ_8 (0 << MMU_RAM_ELSZ_SHIFT) + #define MMU_RAM_ELSZ_16 (1 << MMU_RAM_ELSZ_SHIFT) #define MMU_RAM_ELSZ_32 (2 << MMU_RAM_ELSZ_SHIFT) #define MMU_RAM_ELSZ_NONE (3 << MMU_RAM_ELSZ_SHIFT) @@ -269,9 +266,6 @@ extern int omap_iommu_set_isr(const char *name, void *priv), void *isr_priv); -extern void omap_iommu_save_ctx(struct device *dev); -extern void omap_iommu_restore_ctx(struct device *dev); - extern int omap_install_iommu_arch(const struct iommu_functions *ops); extern void omap_uninstall_iommu_arch(const struct iommu_functions *ops); diff --git a/arch/arm/plat-omap/include/plat/iovmm.h b/arch/arm/plat-omap/include/plat/iovmm.h deleted file mode 100644 index 498e57c..0000000 --- a/arch/arm/plat-omap/include/plat/iovmm.h +++ /dev/null @@ -1,89 +0,0 @@ -/* - * omap iommu: simple virtual address space management - * - * Copyright (C) 2008-2009 Nokia Corporation - * - * Written by Hiroshi DOYU <Hiroshi.DOYU@nokia.com> - * - * This program is free software; you can redistribute it and/or modify - * it under the terms of the GNU General Public License version 2 as - * published by the Free Software Foundation. - */ - -#ifndef __IOMMU_MMAP_H -#define __IOMMU_MMAP_H - -#include <linux/iommu.h> - -struct iovm_struct { - struct omap_iommu *iommu; /* iommu object which this belongs to */ - u32 da_start; /* area definition */ - u32 da_end; - u32 flags; /* IOVMF_: see below */ - struct list_head list; /* linked in ascending order */ - const struct sg_table *sgt; /* keep 'page' <-> 'da' mapping */ - void *va; /* mpu side mapped address */ -}; - -/* - * IOVMF_FLAGS: attribute for iommu virtual memory area(iovma) - * - * lower 16 bit is used for h/w and upper 16 bit is for s/w. - */ -#define IOVMF_SW_SHIFT 16 - -/* - * iovma: h/w flags derived from cam and ram attribute - */ -#define IOVMF_CAM_MASK (~((1 << 10) - 1)) -#define IOVMF_RAM_MASK (~IOVMF_CAM_MASK) - -#define IOVMF_PGSZ_MASK (3 << 0) -#define IOVMF_PGSZ_1M MMU_CAM_PGSZ_1M -#define IOVMF_PGSZ_64K MMU_CAM_PGSZ_64K -#define IOVMF_PGSZ_4K MMU_CAM_PGSZ_4K -#define IOVMF_PGSZ_16M MMU_CAM_PGSZ_16M - -#define IOVMF_ENDIAN_MASK (1 << 9) -#define IOVMF_ENDIAN_BIG MMU_RAM_ENDIAN_BIG -#define IOVMF_ENDIAN_LITTLE MMU_RAM_ENDIAN_LITTLE - -#define IOVMF_ELSZ_MASK (3 << 7) -#define IOVMF_ELSZ_8 MMU_RAM_ELSZ_8 -#define IOVMF_ELSZ_16 MMU_RAM_ELSZ_16 -#define IOVMF_ELSZ_32 MMU_RAM_ELSZ_32 -#define IOVMF_ELSZ_NONE MMU_RAM_ELSZ_NONE - -#define IOVMF_MIXED_MASK (1 << 6) -#define IOVMF_MIXED MMU_RAM_MIXED - -/* - * iovma: s/w flags, used for mapping and umapping internally. - */ -#define IOVMF_MMIO (1 << IOVMF_SW_SHIFT) -#define IOVMF_ALLOC (2 << IOVMF_SW_SHIFT) -#define IOVMF_ALLOC_MASK (3 << IOVMF_SW_SHIFT) - -/* "superpages" is supported just with physically linear pages */ -#define IOVMF_DISCONT (1 << (2 + IOVMF_SW_SHIFT)) -#define IOVMF_LINEAR (2 << (2 + IOVMF_SW_SHIFT)) -#define IOVMF_LINEAR_MASK (3 << (2 + IOVMF_SW_SHIFT)) - -#define IOVMF_DA_FIXED (1 << (4 + IOVMF_SW_SHIFT)) - - -extern struct iovm_struct *omap_find_iovm_area(struct device *dev, u32 da); -extern u32 -omap_iommu_vmap(struct iommu_domain *domain, struct device *dev, u32 da, - const struct sg_table *sgt, u32 flags); -extern struct sg_table *omap_iommu_vunmap(struct iommu_domain *domain, - struct device *dev, u32 da); -extern u32 -omap_iommu_vmalloc(struct iommu_domain *domain, struct device *dev, - u32 da, size_t bytes, u32 flags); -extern void -omap_iommu_vfree(struct iommu_domain *domain, struct device *dev, - const u32 da); -extern void *omap_da_to_va(struct device *dev, u32 da); - -#endif /* __IOMMU_MMAP_H */ diff --git a/drivers/iommu/omap-iommu-debug.c b/drivers/iommu/omap-iommu-debug.c index 0cac372..cf4a0b5 100644 --- a/drivers/iommu/omap-iommu-debug.c +++ b/drivers/iommu/omap-iommu-debug.c @@ -18,9 +18,9 @@ #include <linux/uaccess.h> #include <linux/platform_device.h> #include <linux/debugfs.h> +#include <linux/omap-iommu.h> #include <plat/iommu.h> -#include <plat/iovmm.h> #include "omap-iopgtable.h" diff --git a/drivers/iommu/omap-iommu.c b/drivers/iommu/omap-iommu.c index f2bbfb0..eadcfde 100644 --- a/drivers/iommu/omap-iommu.c +++ b/drivers/iommu/omap-iommu.c @@ -19,6 +19,7 @@ #include <linux/clk.h> #include <linux/platform_device.h> #include <linux/iommu.h> +#include <linux/omap-iommu.h> #include <linux/mutex.h> #include <linux/spinlock.h> diff --git a/drivers/iommu/omap-iovmm.c b/drivers/iommu/omap-iovmm.c index b332392..9852101 100644 --- a/drivers/iommu/omap-iovmm.c +++ b/drivers/iommu/omap-iovmm.c @@ -17,15 +17,59 @@ #include <linux/device.h> #include <linux/scatterlist.h> #include <linux/iommu.h> +#include <linux/omap-iommu.h> #include <asm/cacheflush.h> #include <asm/mach/map.h> #include <plat/iommu.h> -#include <plat/iovmm.h> #include "omap-iopgtable.h" +/* + * IOVMF_FLAGS: attribute for iommu virtual memory area(iovma) + * + * lower 16 bit is used for h/w and upper 16 bit is for s/w. + */ +#define IOVMF_SW_SHIFT 16 + +/* + * iovma: h/w flags derived from cam and ram attribute + */ +#define IOVMF_CAM_MASK (~((1 << 10) - 1)) +#define IOVMF_RAM_MASK (~IOVMF_CAM_MASK) + +#define IOVMF_PGSZ_MASK (3 << 0) +#define IOVMF_PGSZ_1M MMU_CAM_PGSZ_1M +#define IOVMF_PGSZ_64K MMU_CAM_PGSZ_64K +#define IOVMF_PGSZ_4K MMU_CAM_PGSZ_4K +#define IOVMF_PGSZ_16M MMU_CAM_PGSZ_16M + +#define IOVMF_ENDIAN_MASK (1 << 9) +#define IOVMF_ENDIAN_BIG MMU_RAM_ENDIAN_BIG + +#define IOVMF_ELSZ_MASK (3 << 7) +#define IOVMF_ELSZ_16 MMU_RAM_ELSZ_16 +#define IOVMF_ELSZ_32 MMU_RAM_ELSZ_32 +#define IOVMF_ELSZ_NONE MMU_RAM_ELSZ_NONE + +#define IOVMF_MIXED_MASK (1 << 6) +#define IOVMF_MIXED MMU_RAM_MIXED + +/* + * iovma: s/w flags, used for mapping and umapping internally. + */ +#define IOVMF_MMIO (1 << IOVMF_SW_SHIFT) +#define IOVMF_ALLOC (2 << IOVMF_SW_SHIFT) +#define IOVMF_ALLOC_MASK (3 << IOVMF_SW_SHIFT) + +/* "superpages" is supported just with physically linear pages */ +#define IOVMF_DISCONT (1 << (2 + IOVMF_SW_SHIFT)) +#define IOVMF_LINEAR (2 << (2 + IOVMF_SW_SHIFT)) +#define IOVMF_LINEAR_MASK (3 << (2 + IOVMF_SW_SHIFT)) + +#define IOVMF_DA_FIXED (1 << (4 + IOVMF_SW_SHIFT)) + static struct kmem_cache *iovm_area_cachep; /* return the offset of the first scatterlist entry in a sg table */ diff --git a/drivers/media/platform/omap3isp/isp.c b/drivers/media/platform/omap3isp/isp.c index 99640d8..7f182f0 100644 --- a/drivers/media/platform/omap3isp/isp.c +++ b/drivers/media/platform/omap3isp/isp.c @@ -61,6 +61,7 @@ #include <linux/i2c.h> #include <linux/interrupt.h> #include <linux/module.h> +#include <linux/omap-iommu.h> #include <linux/platform_device.h> #include <linux/regulator/consumer.h> #include <linux/slab.h> diff --git a/drivers/media/platform/omap3isp/isp.h b/drivers/media/platform/omap3isp/isp.h index 8be7487..8d68669 100644 --- a/drivers/media/platform/omap3isp/isp.h +++ b/drivers/media/platform/omap3isp/isp.h @@ -31,11 +31,9 @@ #include <media/v4l2-device.h> #include <linux/device.h> #include <linux/io.h> +#include <linux/iommu.h> #include <linux/platform_device.h> #include <linux/wait.h> -#include <linux/iommu.h> -#include <plat/iommu.h> -#include <plat/iovmm.h> #include "ispstat.h" #include "ispccdc.h" diff --git a/drivers/media/platform/omap3isp/ispccdc.c b/drivers/media/platform/omap3isp/ispccdc.c index 60181ab..6ae1ffb2 100644 --- a/drivers/media/platform/omap3isp/ispccdc.c +++ b/drivers/media/platform/omap3isp/ispccdc.c @@ -30,6 +30,7 @@ #include <linux/device.h> #include <linux/dma-mapping.h> #include <linux/mm.h> +#include <linux/omap-iommu.h> #include <linux/sched.h> #include <linux/slab.h> #include <media/v4l2-event.h> diff --git a/drivers/media/platform/omap3isp/ispstat.c b/drivers/media/platform/omap3isp/ispstat.c index d7ac76b..35c3823 100644 --- a/drivers/media/platform/omap3isp/ispstat.c +++ b/drivers/media/platform/omap3isp/ispstat.c @@ -26,6 +26,7 @@ */ #include <linux/dma-mapping.h> +#include <linux/omap-iommu.h> #include <linux/slab.h> #include <linux/uaccess.h> diff --git a/drivers/media/platform/omap3isp/ispvideo.c b/drivers/media/platform/omap3isp/ispvideo.c index a0b737fe..a4b8290 100644 --- a/drivers/media/platform/omap3isp/ispvideo.c +++ b/drivers/media/platform/omap3isp/ispvideo.c @@ -27,6 +27,7 @@ #include <linux/clk.h> #include <linux/mm.h> #include <linux/module.h> +#include <linux/omap-iommu.h> #include <linux/pagemap.h> #include <linux/scatterlist.h> #include <linux/sched.h> @@ -35,7 +36,6 @@ #include <media/v4l2-dev.h> #include <media/v4l2-ioctl.h> #include <plat/iommu.h> -#include <plat/iovmm.h> #include <plat/omap-pm.h> #include "ispvideo.h" diff --git a/include/linux/omap-iommu.h b/include/linux/omap-iommu.h new file mode 100644 index 0000000..cac78de --- /dev/null +++ b/include/linux/omap-iommu.h @@ -0,0 +1,52 @@ +/* + * omap iommu: simple virtual address space management + * + * Copyright (C) 2008-2009 Nokia Corporation + * + * Written by Hiroshi DOYU <Hiroshi.DOYU@nokia.com> + * + * This program is free software; you can redistribute it and/or modify + * it under the terms of the GNU General Public License version 2 as + * published by the Free Software Foundation. + */ + +#ifndef _INTEL_IOMMU_H_ +#define _INTEL_IOMMU_H_ + +struct iovm_struct { + struct omap_iommu *iommu; /* iommu object which this belongs to */ + u32 da_start; /* area definition */ + u32 da_end; + u32 flags; /* IOVMF_: see below */ + struct list_head list; /* linked in ascending order */ + const struct sg_table *sgt; /* keep 'page' <-> 'da' mapping */ + void *va; /* mpu side mapped address */ +}; + +#define MMU_RAM_ENDIAN_SHIFT 9 +#define MMU_RAM_ENDIAN_LITTLE (0 << MMU_RAM_ENDIAN_SHIFT) +#define MMU_RAM_ELSZ_8 (0 << MMU_RAM_ELSZ_SHIFT) +#define IOVMF_ENDIAN_LITTLE MMU_RAM_ENDIAN_LITTLE +#define MMU_RAM_ELSZ_SHIFT 7 +#define IOVMF_ELSZ_8 MMU_RAM_ELSZ_8 + +struct iommu_domain; + +extern struct iovm_struct *omap_find_iovm_area(struct device *dev, u32 da); +extern u32 +omap_iommu_vmap(struct iommu_domain *domain, struct device *dev, u32 da, + const struct sg_table *sgt, u32 flags); +extern struct sg_table *omap_iommu_vunmap(struct iommu_domain *domain, + struct device *dev, u32 da); +extern u32 +omap_iommu_vmalloc(struct iommu_domain *domain, struct device *dev, + u32 da, size_t bytes, u32 flags); +extern void +omap_iommu_vfree(struct iommu_domain *domain, struct device *dev, + const u32 da); +extern void *omap_da_to_va(struct device *dev, u32 da); + +extern void omap_iommu_save_ctx(struct device *dev); +extern void omap_iommu_restore_ctx(struct device *dev); + +#endif ^ permalink raw reply related [flat|nested] 21+ messages in thread
end of thread, other threads:[~2012-11-02 19:24 UTC | newest]
Thread overview: 21+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
[not found] <20121018202707.11834.1438.stgit@muffinssi.local>
2012-10-18 20:28 ` [PATCH 3/6] ARM: OMAP2+: Move plat/iovmm.h to include/linux/omap-iommu.h Tony Lindgren
2012-10-18 20:56 ` Mauro Carvalho Chehab
2012-10-18 22:11 ` Tony Lindgren
2012-10-19 9:40 ` Laurent Pinchart
2012-10-19 16:14 ` Tony Lindgren
2012-10-24 22:34 ` Tony Lindgren
2012-10-24 23:53 ` Laurent Pinchart
2012-10-25 0:25 ` Tony Lindgren
2012-10-18 20:28 ` [PATCH 4/6] ARM: OMAP2+: Move iommu2 to drivers/iommu/omap-iommu2.c Tony Lindgren
[not found] <20121025001913.2082.31062.stgit@muffinssi.local>
2012-10-25 0:20 ` [PATCH 3/6] ARM: OMAP2+: Move plat/iovmm.h to include/linux/omap-iommu.h Tony Lindgren
2012-10-25 8:39 ` Laurent Pinchart
2012-10-25 16:56 ` Tony Lindgren
2012-10-25 20:22 ` Laurent Pinchart
2012-10-25 21:39 ` Tony Lindgren
2012-10-26 5:50 ` Ohad Ben-Cohen
2012-10-26 9:35 ` Laurent Pinchart
2012-10-26 9:54 ` Ohad Ben-Cohen
2012-10-26 18:00 ` Tony Lindgren
2012-10-30 16:29 ` Tony Lindgren
2012-11-02 18:55 ` Tony Lindgren
[not found] <20121102192221.4253.34303.stgit@muffinssi.local>
2012-11-02 19:24 ` Tony Lindgren
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).