From: Tony Lindgren <tony@atomide.com>
To: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
Cc: linux-arm-kernel@lists.infradead.org,
Ohad Ben-Cohen <ohad@wizery.com>,
Mauro Carvalho Chehab <mchehab@redhat.com>,
Joerg Roedel <joerg.roedel@amd.com>,
Omar Ramirez Luna <omar.luna@linaro.org>,
linux-omap@vger.kernel.org, Ido Yariv <ido@wizery.com>,
linux-media@vger.kernel.org
Subject: Re: [PATCH 3/6] ARM: OMAP2+: Move plat/iovmm.h to include/linux/omap-iommu.h
Date: Thu, 25 Oct 2012 09:56:44 -0700 [thread overview]
Message-ID: <20121025165643.GP11928@atomide.com> (raw)
In-Reply-To: <1466344.HbU9q5zM1q@avalon>
* Laurent Pinchart <laurent.pinchart@ideasonboard.com> [121025 01:39]:
>
> I still think you should split this in two files, omap-iommu.h and omap-
> iovmm.h. The later would just be arch/arm/plat-omap/include/plat/iovmm.h moved
> to include/linux.h.
Can you please explain a bit more why you're thinking a separate
omap-iovmm.h is needed in addtion to omap-iommu.h?
My reasoning for not adding it is that neither intel nor amd needs
more than intel-iommu.h and amd-iommu.h. And hopefully the iommu
framework will eventually provide the API needed. And I'd rather
not be the person introducing this second new file into
include/linux :)
Joerg and Ohad, do you have any opinions on this?
Regards,
Tony
next prev parent reply other threads:[~2012-10-25 16:56 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20121025001913.2082.31062.stgit@muffinssi.local>
2012-10-25 0:20 ` [PATCH 3/6] ARM: OMAP2+: Move plat/iovmm.h to include/linux/omap-iommu.h Tony Lindgren
2012-10-25 8:39 ` Laurent Pinchart
2012-10-25 16:56 ` Tony Lindgren [this message]
2012-10-25 20:22 ` Laurent Pinchart
2012-10-25 21:39 ` Tony Lindgren
2012-10-26 5:50 ` Ohad Ben-Cohen
2012-10-26 9:35 ` Laurent Pinchart
2012-10-26 9:54 ` Ohad Ben-Cohen
2012-10-26 18:00 ` Tony Lindgren
2012-10-30 16:29 ` Tony Lindgren
2012-11-02 18:55 ` Tony Lindgren
2012-10-25 0:20 ` [PATCH 4/6] ARM: OMAP2+: Move iommu2 to drivers/iommu/omap-iommu2.c Tony Lindgren
[not found] <20121102192221.4253.34303.stgit@muffinssi.local>
2012-11-02 19:24 ` [PATCH 3/6] ARM: OMAP2+: Move plat/iovmm.h to include/linux/omap-iommu.h Tony Lindgren
[not found] <20121018202707.11834.1438.stgit@muffinssi.local>
2012-10-18 20:28 ` Tony Lindgren
2012-10-18 20:56 ` Mauro Carvalho Chehab
2012-10-18 22:11 ` Tony Lindgren
2012-10-19 9:40 ` Laurent Pinchart
2012-10-19 16:14 ` Tony Lindgren
2012-10-24 22:34 ` Tony Lindgren
2012-10-24 23:53 ` Laurent Pinchart
2012-10-25 0:25 ` Tony Lindgren
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20121025165643.GP11928@atomide.com \
--to=tony@atomide.com \
--cc=ido@wizery.com \
--cc=joerg.roedel@amd.com \
--cc=laurent.pinchart@ideasonboard.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-media@vger.kernel.org \
--cc=linux-omap@vger.kernel.org \
--cc=mchehab@redhat.com \
--cc=ohad@wizery.com \
--cc=omar.luna@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).