Re: [PATCH 35/68] [media] pwc-if: must check vb2_queue_init() success

[Mauro Carvalho Chehab <mchehab@redhat.com>]

Em Mon, 29 Oct 2012 08:37:31 -0300
Ezequiel Garcia <elezegarcia@gmail.com> escreveu:

> On Sat, Oct 27, 2012 at 5:40 PM, Mauro Carvalho Chehab
> <mchehab@redhat.com> wrote:
> > drivers/media/usb/pwc/pwc-if.c: In function 'usb_pwc_probe':
> > drivers/media/usb/pwc/pwc-if.c:1003:16: warning: ignoring return value of 'vb2_queue_init', declared with attribute warn_unused_result [-Wunused-result]
> > In the past, it used to have a logic there at queue init that would
> > BUG() on errors. This logic got removed. Drivers are now required
> > to explicitly handle the queue initialization errors, or very bad
> > things may happen.
> >
> > Signed-off-by: Mauro Carvalho Chehab <mchehab@redhat.com>
> > ---
> >  drivers/media/usb/pwc/pwc-if.c | 6 +++++-
> >  1 file changed, 5 insertions(+), 1 deletion(-)
> >
> > diff --git a/drivers/media/usb/pwc/pwc-if.c b/drivers/media/usb/pwc/pwc-if.c
> > index e191572..5210239 100644
> > --- a/drivers/media/usb/pwc/pwc-if.c
> > +++ b/drivers/media/usb/pwc/pwc-if.c
> > @@ -1000,7 +1000,11 @@ static int usb_pwc_probe(struct usb_interface *intf, const struct usb_device_id
> >         pdev->vb_queue.buf_struct_size = sizeof(struct pwc_frame_buf);
> >         pdev->vb_queue.ops = &pwc_vb_queue_ops;
> >         pdev->vb_queue.mem_ops = &vb2_vmalloc_memops;
> > -       vb2_queue_init(&pdev->vb_queue);
> > +       rc = vb2_queue_init(&pdev->vb_queue);
> > +       if (rc < 0) {
> > +               PWC_ERROR("Oops, could not initialize vb2 queue.\n");
> > +               goto err_free_mem;
> > +       }
> >
> >         /* Init video_device structure */
> >         memcpy(&pdev->vdev, &pwc_template, sizeof(pwc_template));
> > --
> > 1.7.11.7
> >
> 
> Weird, I thought this was already fixed...
> 
> https://patchwork.kernel.org/patch/1467211/
> 
> And even weirder...
> now all my patches are marked as 'New' by patchwork...
> 
> https://patchwork.kernel.org/project/linux-media/list/?submitter=37031&state=*
> 
> (this must be the last name mess I did...)

That's really weird. Did you receive the patchwork state notification email 
for any of those patches?
> 
>     Ezequiel
> --
> To unsubscribe from this list: send the line "unsubscribe linux-media" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html


-- 
Regards,
Mauro