From: Mauro Carvalho Chehab <mchehab@infradead.org>
To: Fabio Estevam <fabio.estevam@freescale.com>
Cc: <g.liakhovetski@gmx.de>, <kernel@pengutronix.de>,
<gcembed@gmail.com>, <javier.martin@vista-silicon.com>,
<linux-media@vger.kernel.org>,
<linux-arm-kernel@lists.infradead.org>
Subject: Re: [PATCH v4 1/2] ARM: clk-imx27: Add missing clock for mx2-camera
Date: Wed, 31 Oct 2012 09:56:32 -0200 [thread overview]
Message-ID: <20121031095632.536d9362@infradead.org> (raw)
In-Reply-To: <1351598606-8485-1-git-send-email-fabio.estevam@freescale.com>
Em Tue, 30 Oct 2012 10:03:25 -0200
Fabio Estevam <fabio.estevam@freescale.com> escreveu:
> During the clock conversion for mx27 the "per4_gate" clock was missed to get
> registered as a dependency of mx2-camera driver.
>
> In the old mx27 clock driver we used to have:
>
> DEFINE_CLOCK1(csi_clk, 0, NULL, 0, parent, &csi_clk1, &per4_clk);
>
> ,so does the same in the new clock driver
>
> Signed-off-by: Fabio Estevam <fabio.estevam@freescale.com>
> Acked-by: Sascha Hauer <s.hauer@pengutronix.de>
As it seems that those patches depend on some patches at the arm tree,
the better is to merge them via -arm tree.
So,
Acked-by: Mauro Carvalho Chehab <mchehab@redhat.com>
> ---
> Changes since v3:
> - Use imx27-camera.0 instead of mx2-camera.0, due to recent changes in the
> imx27 clock (commit 27b76486a3: media: mx2_camera: remove cpu_is_xxx by using platform_device_id)
>
> arch/arm/mach-imx/clk-imx27.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/arch/arm/mach-imx/clk-imx27.c b/arch/arm/mach-imx/clk-imx27.c
> index 585ab25..2880bd9 100644
> --- a/arch/arm/mach-imx/clk-imx27.c
> +++ b/arch/arm/mach-imx/clk-imx27.c
> @@ -224,6 +224,7 @@ int __init mx27_clocks_init(unsigned long fref)
> clk_register_clkdev(clk[lcdc_ipg_gate], "ipg", "imx21-fb.0");
> clk_register_clkdev(clk[lcdc_ahb_gate], "ahb", "imx21-fb.0");
> clk_register_clkdev(clk[csi_ahb_gate], "ahb", "imx27-camera.0");
> + clk_register_clkdev(clk[per4_gate], "per", "imx27-camera.0");
> clk_register_clkdev(clk[usb_div], "per", "fsl-usb2-udc");
> clk_register_clkdev(clk[usb_ipg_gate], "ipg", "fsl-usb2-udc");
> clk_register_clkdev(clk[usb_ahb_gate], "ahb", "fsl-usb2-udc");
Cheers,
Mauro
next prev parent reply other threads:[~2012-10-31 11:56 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-10-30 12:03 [PATCH v4 1/2] ARM: clk-imx27: Add missing clock for mx2-camera Fabio Estevam
2012-10-30 12:03 ` [PATCH v4 2/2] mx2_camera: Fix regression caused by clock conversion Fabio Estevam
2012-10-31 11:57 ` Mauro Carvalho Chehab
2012-11-14 18:22 ` Fabio Estevam
2012-11-14 19:58 ` Sascha Hauer
2012-10-31 11:56 ` Mauro Carvalho Chehab [this message]
2012-10-31 13:16 ` [PATCH v4 1/2] ARM: clk-imx27: Add missing clock for mx2-camera Sascha Hauer
2012-10-31 13:24 ` Fabio Estevam
2012-10-31 13:53 ` Guennadi Liakhovetski
2012-10-31 18:53 ` Mauro Carvalho Chehab
2012-10-31 19:02 ` Sascha Hauer
2012-10-31 19:50 ` Mauro Carvalho Chehab
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20121031095632.536d9362@infradead.org \
--to=mchehab@infradead.org \
--cc=fabio.estevam@freescale.com \
--cc=g.liakhovetski@gmx.de \
--cc=gcembed@gmail.com \
--cc=javier.martin@vista-silicon.com \
--cc=kernel@pengutronix.de \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-media@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).