Re: [PATCH v8 5/6] drm_modes: add videomode helpers

Thierry Reding
2012-11-13T11:31:41Z

[-- Attachment #1: Type: text/plain, Size: 580 bytes --]

On Mon, Nov 12, 2012 at 04:37:05PM +0100, Steffen Trumtrar wrote:
[...]
> diff --git a/drivers/gpu/drm/drm_modes.c b/drivers/gpu/drm/drm_modes.c
[...]
> +#if IS_ENABLED(CONFIG_VIDEOMODE)
> +int videomode_to_display_mode(struct videomode *vm, struct drm_display_mode *dmode)

This one as well may be more consistently named
drm_display_mode_from_videomode().

> diff --git a/include/drm/drmP.h b/include/drm/drmP.h
[...]
> +extern int videomode_to_display_mode(struct videomode *vm,
> + struct drm_display_mode *dmode);

And this also needs protection or a dummy.

Thierry

[-- Attachment #2: Type: application/pgp-signature, Size: 836 bytes --]