Re: [PATCH v8 1/6] video: add display_timing and videomode

Thierry Reding
2012-11-14T10:56:45Z

[-- Attachment #1: Type: text/plain, Size: 508 bytes --]

On Mon, Nov 12, 2012 at 04:37:01PM +0100, Steffen Trumtrar wrote:
[...]
> diff --git a/drivers/video/display_timing.c b/drivers/video/display_timing.c
[...]
> +void display_timings_release(struct display_timings *disp)
> +{
> + if (disp->timings) {
> + unsigned int i;
> +
> + for (i = 0; i < disp->num_timings; i++)
> + kfree(disp->timings[i]);
> + kfree(disp->timings);
> + }
> + kfree(disp);
> +}

I think this is still missing an EXPORT_SYMBOL_GPL. Otherwise it can't
be used from modules.

Thierry

[-- Attachment #2: Type: application/pgp-signature, Size: 836 bytes --]