From: Thierry Reding <thierry.reding@avionic-design.de>
To: Steffen Trumtrar <s.trumtrar@pengutronix.de>
Cc: devicetree-discuss@lists.ozlabs.org,
Rob Herring <robherring2@gmail.com>,
linux-fbdev@vger.kernel.org, dri-devel@lists.freedesktop.org,
Laurent Pinchart <laurent.pinchart@ideasonboard.com>,
Guennady Liakhovetski <g.liakhovetski@gmx.de>,
linux-media@vger.kernel.org,
Tomi Valkeinen <tomi.valkeinen@ti.com>,
Stephen Warren <swarren@wwwdotorg.org>,
kernel@pengutronix.de
Subject: Re: [PATCH v9 5/6] drm_modes: add videomode helpers
Date: Wed, 14 Nov 2012 13:49:44 +0100 [thread overview]
Message-ID: <20121114124944.GF2803@avionic-0098.mockup.avionic-design.de> (raw)
In-Reply-To: <1352893403-21168-6-git-send-email-s.trumtrar@pengutronix.de>
[-- Attachment #1: Type: text/plain, Size: 596 bytes --]
On Wed, Nov 14, 2012 at 12:43:22PM +0100, Steffen Trumtrar wrote:
[...]
> diff --git a/drivers/gpu/drm/drm_modes.c b/drivers/gpu/drm/drm_modes.c
[...]
> @@ -504,6 +505,41 @@ drm_gtf_mode(struct drm_device *dev, int hdisplay, int vdisplay, int vrefresh,
> }
> EXPORT_SYMBOL(drm_gtf_mode);
>
> +#if IS_ENABLED(CONFIG_VIDEOMODE)
> +int display_mode_from_videomode(struct videomode *vm, struct drm_display_mode *dmode)
Given that this is still a DRM core function, maybe it should get a drm_
prefix? Also the line is too long, so you may want to wrap the argument
list.
Thierry
[-- Attachment #2: Type: application/pgp-signature, Size: 836 bytes --]
next prev parent reply other threads:[~2012-11-14 12:50 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-11-14 11:43 [PATCH v9 0/6] of: add display helper Steffen Trumtrar
2012-11-14 11:43 ` [PATCH v9 1/6] video: add display_timing and videomode Steffen Trumtrar
2012-11-14 12:03 ` Thierry Reding
2012-11-14 11:43 ` [PATCH v9 2/6] video: add of helper for videomode Steffen Trumtrar
2012-11-14 12:00 ` Thierry Reding
2012-11-14 13:31 ` Steffen Trumtrar
2012-11-14 12:06 ` Thierry Reding
2012-11-14 11:43 ` [PATCH v9 3/6] fbmon: add videomode helpers Steffen Trumtrar
2012-11-14 12:12 ` Thierry Reding
2012-11-14 14:06 ` Steffen Trumtrar
2012-11-14 11:43 ` [PATCH v9 4/6] fbmon: add of_videomode helpers Steffen Trumtrar
2012-11-14 12:47 ` Thierry Reding
2012-11-14 11:43 ` [PATCH v9 5/6] drm_modes: add videomode helpers Steffen Trumtrar
2012-11-14 12:49 ` Thierry Reding [this message]
2012-11-14 14:18 ` Steffen Trumtrar
2012-11-14 11:43 ` [PATCH v9 6/6] drm_modes: add of_videomode helpers Steffen Trumtrar
2012-11-14 12:51 ` Thierry Reding
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20121114124944.GF2803@avionic-0098.mockup.avionic-design.de \
--to=thierry.reding@avionic-design.de \
--cc=devicetree-discuss@lists.ozlabs.org \
--cc=dri-devel@lists.freedesktop.org \
--cc=g.liakhovetski@gmx.de \
--cc=kernel@pengutronix.de \
--cc=laurent.pinchart@ideasonboard.com \
--cc=linux-fbdev@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=robherring2@gmail.com \
--cc=s.trumtrar@pengutronix.de \
--cc=swarren@wwwdotorg.org \
--cc=tomi.valkeinen@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox