Re: [GIT PULL] soc-camera + VEU for 3.8

[Mauro Carvalho Chehab <mchehab@redhat.com>]

Em Thu, 22 Nov 2012 11:41:05 -0200
Mauro Carvalho Chehab <mchehab@redhat.com> escreveu:

> Em Wed, 31 Oct 2012 13:01:19 +0100 (CET)
> Guennadi Liakhovetski <g.liakhovetski@gmx.de> escreveu:
> 
> > Hi Mauro
> > 
> > Please pull driver updates for 3.8. Apart from usual soc-camera 
> > development this pull request also includes a new VEU MEM2MEM driver.
> > 
> > The following changes since commit 016e804df1632fa99b1d96825df4c0db075ac196:
> > 
> >   media: sh_vou: fix const cropping related warnings (2012-10-31 11:35:51 +0100)
> > 
> > are available in the git repository at:
> > 
> >   git://linuxtv.org/gliakhovetski/v4l-dvb.git for-3.8
> > 
> > for you to fetch changes up to 223916e1817ce458e947a5f99026ee7d05acaa66:
> > 
> >   media: add a VEU MEM2MEM format conversion and scaling driver (2012-10-31 12:54:58 +0100)
> > 
> > ----------------------------------------------------------------
> > Anatolij Gustschin (4):
> >       V4L: soc_camera: allow reading from video device if supported
> >       mt9v022: add v4l2 controls for blanking
> >       mt9v022: support required register settings in snapshot mode
> >       mt9v022: set y_skip_top field to zero as default
> > 
> > Frank SchÀfer (1):
> >       ov2640: add support for V4L2_MBUS_FMT_YUYV8_2X8, V4L2_MBUS_FMT_RGB565_2X8_BE
> > 
> > Guennadi Liakhovetski (1):
> >       media: add a VEU MEM2MEM format conversion and scaling driver
> > 
> > Shawn Guo (1):
> >       media: mx1_camera: mark the driver BROKEN
> > 
> >  arch/arm/mach-pxa/pcm990-baseboard.c           |    6 +
> >  drivers/media/i2c/soc_camera/mt9v022.c         |   88 ++-
> >  drivers/media/i2c/soc_camera/ov2640.c          |   49 +-
> >  drivers/media/platform/Kconfig                 |    9 +
> >  drivers/media/platform/Makefile                |    2 +
> >  drivers/media/platform/sh_veu.c                | 1264 ++++++++++++++++++++++++
> 
> Applied, thanks!
> 
> Please submit a MAINTAINERS entry for this new driver.

Hmm... there are also some new warnings introduced by it (compiled on x86_64):

drivers/media/platform/sh_veu.c: In function 'sh_veu_process':
drivers/media/platform/sh_veu.c:269:2: warning: format '%x' expects argument of type 'unsigned int', but argument 5 has type 'dma_addr_t' [-Wformat]
drivers/media/platform/sh_veu.c:276:2: warning: format '%x' expects argument of type 'unsigned int', but argument 5 has type 'dma_addr_t' [-Wformat]
drivers/media/platform/sh_veu.c: In function 'sh_veu_probe':
drivers/media/platform/sh_veu.c:1199:2: warning: passing argument 1 of 'v4l2_m2m_init' discards 'const' qualifier from pointer target type [enabled by default]
In file included from drivers/media/platform/sh_veu.c:27:0:
include/media/v4l2-mem2mem.h:125:22: note: expected 'struct v4l2_m2m_ops *' but argument is of type 'const struct v4l2_m2m_ops *'

I'll just drop "media: add a VEU MEM2MEM format conversion and scaling driver" and
wait for a warning-free version with a MAINTAINERS entry patch series.

Regards,
Mauro