From: Jean-Francois Moine <moinejf@free.fr>
To: Linux Media Mailing List <linux-media@vger.kernel.org>,
Hans de Goede <hdegoede@redhat.com>
Subject: [PATCH] gspca - ov534: Fix the light frequency filter.
Date: Thu, 22 Nov 2012 12:33:57 +0100 [thread overview]
Message-ID: <20121122123357.4da1fa2c@armhf> (raw)
From: Jean-François Moine <moinejf@free.fr>
The exchanges relative to the light frequency filter were adapted
from a description found in a ms-windows driver. It seems that the
registers were the ones of some other sensor.
This patch was done thanks to the documentation of the right
OmniVision sensors.
Note: The light frequency filter is either off or automatic.
The application will see either off or "50Hz" only.
--- a/drivers/media/usb/gspca/ov534.c
+++ b/drivers/media/usb/gspca/ov534.c
@@ -1038,13 +1038,12 @@
{
struct sd *sd = (struct sd *) gspca_dev;
- val = val ? 0x9e : 0x00;
- if (sd->sensor == SENSOR_OV767x) {
- sccb_reg_write(gspca_dev, 0x2a, 0x00);
- if (val)
- val = 0x9d; /* insert dummy to 25fps for 50Hz */
- }
- sccb_reg_write(gspca_dev, 0x2b, val);
+ if (!val)
+ sccb_reg_write(gspca_dev, 0x13, /* off */
+ sccb_reg_read(gspca_dev, 0x13) & ~0x20);
+ else
+ sccb_reg_write(gspca_dev, 0x13, /* auto */
+ sccb_reg_read(gspca_dev, 0x13) | 0x20);
}
--
Ken ar c'hentañ | ** Breizh ha Linux atav! **
Jef | http://moinejf.free.fr/
next reply other threads:[~2012-11-22 18:40 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-11-22 11:33 Jean-Francois Moine [this message]
-- strict thread matches above, loose matches on Subject: below --
2012-11-22 11:46 [PATCH] gspca - ov534: Fix the light frequency filter Jean-Francois Moine
2012-11-23 17:09 ` Antonio Ospite
2012-11-23 18:12 ` Jean-Francois Moine
2012-11-26 13:08 ` Antonio Ospite
2012-11-26 15:23 ` Jean-Francois Moine
2012-11-26 17:12 ` Antonio Ospite
2012-11-26 17:51 ` Jean-Francois Moine
2012-11-29 9:25 ` Hans de Goede
2012-11-29 22:14 ` Antonio Ospite
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20121122123357.4da1fa2c@armhf \
--to=moinejf@free.fr \
--cc=hdegoede@redhat.com \
--cc=linux-media@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox