From mboxrd@z Thu Jan 1 00:00:00 1970 Return-path: Received: from mx1.redhat.com ([209.132.183.28]:44290 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755779Ab2LMT5q convert rfc822-to-8bit (ORCPT ); Thu, 13 Dec 2012 14:57:46 -0500 Date: Thu, 13 Dec 2012 17:57:15 -0200 From: Mauro Carvalho Chehab To: Frank =?UTF-8?B?U2Now6RmZXI=?= Cc: Antti Palosaari , Devin Heitmueller , Matthew Gyurgyik , Linux Media Mailing List Subject: Re: em28xx: msi Digivox ATSC board id [0db0:8810] Message-ID: <20121213175715.77d8582d@redhat.com> In-Reply-To: <50C636E7.8060003@googlemail.com> References: <50B5779A.9090807@pyther.net> <50BEC253.4080006@pyther.net> <50BF3F9A.3020803@iki.fi> <50BFBE39.90901@pyther.net> <50BFC445.6020305@iki.fi> <50BFCBBB.5090407@pyther.net> <50BFECEA.9060808@iki.fi> <50BFFFF6.1000204@pyther.net> <50C11301.10205@googlemail.com> <50C12302.80603@pyther.net> <50C34628.5030407@googlemail.com> <50C34A50.6000207@pyther.net> <50C35AD1.3040000@googlemail.com> <50C48891.2050903@googlemail.com> <50C4A520.6020908@pyther.net> <50C4BA20.8060003@googlemail.com> <50C4BAFB.60304@googlemail.com> <50C4C525.6020006@googlemail.com> <50C4D011.6010700@pyther.net> <50C60220.8050908@googlemail.com> <50C60772.2010904@googlemail.com> <50C6226C.8090302@iki.fi> <50C636E7.8060003@googlemail.com> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8BIT Sender: linux-media-owner@vger.kernel.org List-ID: Em Mon, 10 Dec 2012 20:24:23 +0100 Frank Schäfer escreveu: > Am 10.12.2012 18:57, schrieb Antti Palosaari: > > On 12/10/2012 06:13 PM, Devin Heitmueller wrote: > >> On Mon, Dec 10, 2012 at 11:01 AM, Frank Schäfer > >>> Adding a new property to the RC profile certainly seems to be the > >>> cleanest solution. > >>> Do all protocols have paritiy checking ? Otherwise we could add a new > >>> type RC_TYPE_NEC_NO_PARITY. > >>> OTOH, introducing a new bitfield in struct rc_map might be usefull for > >>> other flags, too, in the future... > >> > >> It's probably also worth mentioning that in that mode the device > >> reports four bytes, not two. I guess perhaps if parity is ignored it > >> reports the data in some other format? You will probably have to do > >> some experimentation there. > > > > Uh, current em28xx NEC implementation is locked to traditional 16 bit > > NEC, where is hw checksum used. It is not the current NEC implementation at the driver; it is, instead, a hardware issue. At least on the tests I did in the past with em28xx and remote controllers capable of producing 32 bit keycodes, the NEC hardware decoder inside em28xx were only providing 16 bits. Regards, Mauro