* [PATCH] [media] ivtv: ivtv-driver: Replace 'flush_work_sync()'
@ 2012-10-24 12:14 Fabio Estevam
2012-10-24 16:48 ` Tejun Heo
0 siblings, 1 reply; 5+ messages in thread
From: Fabio Estevam @ 2012-10-24 12:14 UTC (permalink / raw)
To: awalls; +Cc: mchehab, linux-media, tj, Fabio Estevam
From: Fabio Estevam <fabio.estevam@freescale.com>
Since commit 43829731d (workqueue: deprecate flush[_delayed]_work_sync()),
flush_work() should be used instead of flush_work_sync().
Signed-off-by: Fabio Estevam <fabio.estevam@freescale.com>
---
drivers/media/pci/ivtv/ivtv-driver.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/media/pci/ivtv/ivtv-driver.c b/drivers/media/pci/ivtv/ivtv-driver.c
index 74e9a50..5d0a5df 100644
--- a/drivers/media/pci/ivtv/ivtv-driver.c
+++ b/drivers/media/pci/ivtv/ivtv-driver.c
@@ -304,7 +304,7 @@ static void request_modules(struct ivtv *dev)
static void flush_request_modules(struct ivtv *dev)
{
- flush_work_sync(&dev->request_module_wk);
+ flush_work(&dev->request_module_wk);
}
#else
#define request_modules(dev)
--
1.7.9.5
^ permalink raw reply related [flat|nested] 5+ messages in thread
* Re: [PATCH] [media] ivtv: ivtv-driver: Replace 'flush_work_sync()'
2012-10-24 12:14 Fabio Estevam
@ 2012-10-24 16:48 ` Tejun Heo
0 siblings, 0 replies; 5+ messages in thread
From: Tejun Heo @ 2012-10-24 16:48 UTC (permalink / raw)
To: Fabio Estevam; +Cc: awalls, mchehab, linux-media, Fabio Estevam
On Wed, Oct 24, 2012 at 8:14 AM, Fabio Estevam <festevam@gmail.com> wrote:
> From: Fabio Estevam <fabio.estevam@freescale.com>
>
> Since commit 43829731d (workqueue: deprecate flush[_delayed]_work_sync()),
> flush_work() should be used instead of flush_work_sync().
>
> Signed-off-by: Fabio Estevam <fabio.estevam@freescale.com>
Acked-by: Tejun Heo <tj@kernel.org>
Thanks!
--
tejun
^ permalink raw reply [flat|nested] 5+ messages in thread
* Fw: [PATCH] [media] ivtv: ivtv-driver: Replace 'flush_work_sync()'
@ 2012-11-21 17:28 Mauro Carvalho Chehab
2012-12-20 17:18 ` Mauro Carvalho Chehab
0 siblings, 1 reply; 5+ messages in thread
From: Mauro Carvalho Chehab @ 2012-11-21 17:28 UTC (permalink / raw)
To: Andy Walls; +Cc: Linux Media ML
Hi Andy,
I'm understanding that you'll be reviewing this patch. So, I'm marking it as
under_review at patchwork.
Thanks,
Mauro
Forwarded message:
Date: Wed, 24 Oct 2012 10:14:16 -0200
From: Fabio Estevam <festevam@gmail.com>
To: awalls@md.metrocast.net
Cc: mchehab@infradead.org, linux-media@vger.kernel.org, tj@kernel.org, Fabio Estevam <fabio.estevam@freescale.com>
Subject: [PATCH] [media] ivtv: ivtv-driver: Replace 'flush_work_sync()'
From: Fabio Estevam <fabio.estevam@freescale.com>
Since commit 43829731d (workqueue: deprecate flush[_delayed]_work_sync()),
flush_work() should be used instead of flush_work_sync().
Signed-off-by: Fabio Estevam <fabio.estevam@freescale.com>
---
drivers/media/pci/ivtv/ivtv-driver.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/media/pci/ivtv/ivtv-driver.c b/drivers/media/pci/ivtv/ivtv-driver.c
index 74e9a50..5d0a5df 100644
--- a/drivers/media/pci/ivtv/ivtv-driver.c
+++ b/drivers/media/pci/ivtv/ivtv-driver.c
@@ -304,7 +304,7 @@ static void request_modules(struct ivtv *dev)
static void flush_request_modules(struct ivtv *dev)
{
- flush_work_sync(&dev->request_module_wk);
+ flush_work(&dev->request_module_wk);
}
#else
#define request_modules(dev)
--
1.7.9.5
--
To unsubscribe from this list: send the line "unsubscribe linux-media" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
--
Regards,
Mauro
^ permalink raw reply related [flat|nested] 5+ messages in thread
* Re: [PATCH] [media] ivtv: ivtv-driver: Replace 'flush_work_sync()'
2012-11-21 17:28 Fw: [PATCH] [media] ivtv: ivtv-driver: Replace 'flush_work_sync()' Mauro Carvalho Chehab
@ 2012-12-20 17:18 ` Mauro Carvalho Chehab
2013-01-07 0:04 ` Andy Walls
0 siblings, 1 reply; 5+ messages in thread
From: Mauro Carvalho Chehab @ 2012-12-20 17:18 UTC (permalink / raw)
To: Mauro Carvalho Chehab; +Cc: Andy Walls, Linux Media ML
Em Wed, 21 Nov 2012 15:28:09 -0200
Mauro Carvalho Chehab <mchehab@redhat.com> escreveu:
> Hi Andy,
>
> I'm understanding that you'll be reviewing this patch. So, I'm marking it as
> under_review at patchwork.
-ENOANSWER. Let me apply it, in order to fix the warning.
>
> Thanks,
> Mauro
>
> Forwarded message:
>
> Date: Wed, 24 Oct 2012 10:14:16 -0200
> From: Fabio Estevam <festevam@gmail.com>
> To: awalls@md.metrocast.net
> Cc: mchehab@infradead.org, linux-media@vger.kernel.org, tj@kernel.org, Fabio Estevam <fabio.estevam@freescale.com>
> Subject: [PATCH] [media] ivtv: ivtv-driver: Replace 'flush_work_sync()'
>
>
> From: Fabio Estevam <fabio.estevam@freescale.com>
>
> Since commit 43829731d (workqueue: deprecate flush[_delayed]_work_sync()),
> flush_work() should be used instead of flush_work_sync().
>
> Signed-off-by: Fabio Estevam <fabio.estevam@freescale.com>
> ---
> drivers/media/pci/ivtv/ivtv-driver.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/media/pci/ivtv/ivtv-driver.c b/drivers/media/pci/ivtv/ivtv-driver.c
> index 74e9a50..5d0a5df 100644
> --- a/drivers/media/pci/ivtv/ivtv-driver.c
> +++ b/drivers/media/pci/ivtv/ivtv-driver.c
> @@ -304,7 +304,7 @@ static void request_modules(struct ivtv *dev)
>
> static void flush_request_modules(struct ivtv *dev)
> {
> - flush_work_sync(&dev->request_module_wk);
> + flush_work(&dev->request_module_wk);
> }
> #else
> #define request_modules(dev)
--
Cheers,
Mauro
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] [media] ivtv: ivtv-driver: Replace 'flush_work_sync()'
2012-12-20 17:18 ` Mauro Carvalho Chehab
@ 2013-01-07 0:04 ` Andy Walls
0 siblings, 0 replies; 5+ messages in thread
From: Andy Walls @ 2013-01-07 0:04 UTC (permalink / raw)
To: Mauro Carvalho Chehab; +Cc: Linux Media ML
On Thu, 2012-12-20 at 15:18 -0200, Mauro Carvalho Chehab wrote:
> Em Wed, 21 Nov 2012 15:28:09 -0200
> Mauro Carvalho Chehab <mchehab@redhat.com> escreveu:
>
> > Hi Andy,
> >
> > I'm understanding that you'll be reviewing this patch. So, I'm marking it as
> > under_review at patchwork.
>
> -ENOANSWER. Let me apply it, in order to fix the warning.
Ooops. Sorry about that.
Strictly speaking, I think the patch introduces a race condition that is
extremely unlikely to be encountered, and it likely wouldn't have
terrible consequences anyway.
For the normal end-user, it will never be a problem.
FWIW:
Acked-by: Andy Walls <awalls@md.metrocast.net>
Regards,
Andy
> >
> > Thanks,
> > Mauro
> >
> > Forwarded message:
> >
> > Date: Wed, 24 Oct 2012 10:14:16 -0200
> > From: Fabio Estevam <festevam@gmail.com>
> > To: awalls@md.metrocast.net
> > Cc: mchehab@infradead.org, linux-media@vger.kernel.org, tj@kernel.org, Fabio Estevam <fabio.estevam@freescale.com>
> > Subject: [PATCH] [media] ivtv: ivtv-driver: Replace 'flush_work_sync()'
> >
> >
> > From: Fabio Estevam <fabio.estevam@freescale.com>
> >
> > Since commit 43829731d (workqueue: deprecate flush[_delayed]_work_sync()),
> > flush_work() should be used instead of flush_work_sync().
> >
> > Signed-off-by: Fabio Estevam <fabio.estevam@freescale.com>
> > ---
> > drivers/media/pci/ivtv/ivtv-driver.c | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/drivers/media/pci/ivtv/ivtv-driver.c b/drivers/media/pci/ivtv/ivtv-driver.c
> > index 74e9a50..5d0a5df 100644
> > --- a/drivers/media/pci/ivtv/ivtv-driver.c
> > +++ b/drivers/media/pci/ivtv/ivtv-driver.c
> > @@ -304,7 +304,7 @@ static void request_modules(struct ivtv *dev)
> >
> > static void flush_request_modules(struct ivtv *dev)
> > {
> > - flush_work_sync(&dev->request_module_wk);
> > + flush_work(&dev->request_module_wk);
> > }
> > #else
> > #define request_modules(dev)
>
>
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2013-01-07 0:05 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2012-11-21 17:28 Fw: [PATCH] [media] ivtv: ivtv-driver: Replace 'flush_work_sync()' Mauro Carvalho Chehab
2012-12-20 17:18 ` Mauro Carvalho Chehab
2013-01-07 0:04 ` Andy Walls
-- strict thread matches above, loose matches on Subject: below --
2012-10-24 12:14 Fabio Estevam
2012-10-24 16:48 ` Tejun Heo
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).