linux-media.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Mauro Carvalho Chehab <mchehab@redhat.com>
To: "Frank Schäfer" <fschaefer.oss@googlemail.com>
Cc: Linux Media Mailing List <linux-media@vger.kernel.org>
Subject: Re: em28xx: module parameter prefer_bulk ?
Date: Mon, 24 Dec 2012 13:16:25 -0200	[thread overview]
Message-ID: <20121224131625.128de19c@redhat.com> (raw)
In-Reply-To: <50D83BB2.4070308@googlemail.com>

Em Mon, 24 Dec 2012 12:25:38 +0100
Frank Schäfer <fschaefer.oss@googlemail.com> escreveu:

> Hi Mauro,
> 
> now that we prefer bulk transfers for webcams and isoc transfers for TV,
> I wonder if prefer_bulk is still a good name for this module parameter.
> What about something like 'usb_mode', 'usb_xfer_mode' or
> 'frame_xfer_mode' with 0=auto, 1=prefer isoc, 2=prefer bulk ?

while keeping it as-is is not bad, IMHO, we can change it if people prefer
renaming it.

usb_xfer_mode sounds good for me. Feel free to submit a patch if you want.

It should be noticed that we can change it while it was not upstreamed. 

With regards to the range, we generally use -1 for "auto" (at least, we do
that on several other places).

-- 

Cheers,
Mauro

  reply	other threads:[~2012-12-24 15:16 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-12-24 11:25 em28xx: module parameter prefer_bulk ? Frank Schäfer
2012-12-24 15:16 ` Mauro Carvalho Chehab [this message]
2012-12-26 18:55   ` Frank Schäfer

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20121224131625.128de19c@redhat.com \
    --to=mchehab@redhat.com \
    --cc=fschaefer.oss@googlemail.com \
    --cc=linux-media@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).