From mboxrd@z Thu Jan 1 00:00:00 1970 Return-path: Received: from caramon.arm.linux.org.uk ([78.32.30.218]:39288 "EHLO caramon.arm.linux.org.uk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753594Ab3ACNxY (ORCPT ); Thu, 3 Jan 2013 08:53:24 -0500 Date: Thu, 3 Jan 2013 13:52:56 +0000 From: Russell King - ARM Linux To: Dan Carpenter Cc: Tony Prisk , Tomasz Stanislawski , Dan Carpenter , Sergei Shtylyov , kernel-janitors@vger.kernel.org, linux-kernel@vger.kernel.org, Kyungmin Park , Sylwester Nawrocki , linux-arm-kernel@lists.infradead.org, linux-media@vger.kernel.org Subject: Re: [PATCH RESEND 6/6] clk: s5p-g2d: Fix incorrect usage of IS_ERR_OR_NULL Message-ID: <20130103135256.GO2631@n2100.arm.linux.org.uk> References: <1355852048-23188-7-git-send-email-linux@prisktech.co.nz> <50D62BC9.9010706@mvista.com> <50E32C06.5020104@gmail.com> <1357104713.30504.8.camel@gitbox> <20130103090520.GC7247@mwanda> <20130103100000.GJ2631@n2100.arm.linux.org.uk> <20130103111040.GD7247@mwanda> <20130103112102.GM2631@n2100.arm.linux.org.uk> <20130103134554.GJ7247@mwanda> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20130103134554.GJ7247@mwanda> Sender: linux-media-owner@vger.kernel.org List-ID: On Thu, Jan 03, 2013 at 04:45:54PM +0300, Dan Carpenter wrote: > On Thu, Jan 03, 2013 at 11:21:02AM +0000, Russell King - ARM Linux wrote: > > Maybe you don't realise, but IS_ERR(NULL) is false. Therefore, this falls > > into category (2). > > No, obviously, I know the difference between IS_ERR() and > IS_ERR_OR_NULL(). That's how we started this thread. Well, if you know that, then how is the documentation anything _but_ clear?