From mboxrd@z Thu Jan 1 00:00:00 1970 Return-path: Received: from mx1.redhat.com ([209.132.183.28]:27210 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751869Ab3APTXi (ORCPT ); Wed, 16 Jan 2013 14:23:38 -0500 Date: Wed, 16 Jan 2013 17:22:40 -0200 From: Mauro Carvalho Chehab To: Manu Abraham Cc: Antti Palosaari , Linux Media Mailing List Subject: Re: [PATCH RFCv10 00/15] DVB QoS statistics API Message-ID: <20130116172240.5d41da32@redhat.com> In-Reply-To: References: <1358217061-14982-1-git-send-email-mchehab@redhat.com> <50F522AD.8000109@iki.fi> <20130115111041.6b78a935@redhat.com> <50F56C63.7010503@iki.fi> <50F57519.5060402@iki.fi> <20130115151203.7221b1db@redhat.com> <50F5BE14.9000705@iki.fi> <20130116115605.0fea6d03@redhat.com> <20130116152151.5461221c@redhat.com> Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-media-owner@vger.kernel.org List-ID: Em Wed, 16 Jan 2013 23:56:48 +0530 Manu Abraham escreveu: > Consider this simple situation: > Your new API is using get_frontend and is polling the hardware, Now an > existing application is also doing monitoring of the statistics. So, now all > the decision box calculations are screwed. -EREADTHEFUCKINGPATCHES Patch 04/15: ... +static int mb86a20s_read_signal_strength_from_cache(struct dvb_frontend *fe, + u16 *strength) +{ + struct dtv_frontend_properties *c = &fe->dtv_property_cache; + + *strength = c->strength.stat[0].uvalue; + + return 0; } ... The returned value there is in the same range as before. Enough. If you don't read the patches, you're just making everybody loosing their time with your biased and incorrect comments. Cheers, Mauro