Re: [PATCH RFCv10 00/15] DVB QoS statistics API

[Mauro Carvalho Chehab <mchehab@redhat.com>]

Em Fri, 18 Jan 2013 00:07:17 +0530
Manu Abraham <abraham.manu@gmail.com> escreveu:

> On Thu, Jan 17, 2013 at 11:57 PM, Antti Palosaari <crope@iki.fi> wrote:
> 
> >
> >
> > Resetting counters when user tunes channel sounds the only correct option.
> >
> 
> This might not be correct, especially when we have true Multiple Input Streams.
> The tune might be single, but the filter setup would be different. In
> which case it
> wouldn't correct to do a reset of the counters ona tune. Resetting the counters
> should be the responsibility of the driver.

I moved the counters reset to the driver's logic on v11. I'm posting the
patches in a few.

> As I said in an earlier
> post, anything
> other than the driver handling any statistical event monitoring, such an API is
> broken for sure, without even reading single line of code for that API for which
>  it is written for.

Yes, driver should have full control on it.

> > OK, maybe we will see in near future if that works well or not. I think that
> > for calculating of PER it is required to start continuous polling to keep up
> > total block counters. Maybe updating UCB counter continously needs that too,
> > so it should work.
> 
> 
> With multi-standard demodulators, some of them PER compute is a by-product
> of some internal demodulator algorithmic operation. In some cases, it might
> require a loop in the driver. As I said, again; It is very hard/wrong
> to do basic
> generalizations.

Agreed.

-- 

Cheers,
Mauro