linux-media.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: mrf <gc2majortom@gmail.com>
To: linux-media@vger.kernel.org
Subject: tuner-xc2028.c fix for EVGA inDtube tuner
Date: Sun, 20 Jan 2013 21:03:24 -0500	[thread overview]
Message-ID: <20130121020324.GB9028@orion> (raw)

Hi,
Let me begin with, I'm an end user, not a programmer...

I have noticed the EVGA inDtube tuner that I use (North American ATSC)
has been broken for quite a while. The Frequency offsets are wrong,
and up till now I have always had to fudge the frequency to account
for the incorrect offset. 
I found a fix that works for me, and waiting for a friend of mine,
another inDtube user, to try the same fix and get back to me.

Pending his report, would it be possible to get this fixed in the
kernel for good?

Thanks,

Bill

/ linux / drivers / media / common / tuners / tuner-xc2028.c

was commented out by someone somewhere along the way in development. Putting the
commented code back in, the inDtube tuner works correctly, no more having to
fudge the frequency offset in user land.

Would it be possible to get this fixed for good in the kernel?
I am using xc3028L-v36.fw firmware

here is a snippet adding two comments, to remove the comments.


/* #if 0 */
                /*
                 * Still need tests for XC3028L (firmware 3.2 or
                 * upper)
                 * So, for now, let's just comment the per-firmware
                 * version of this change. Reports with xc3028l
                 * working
                 * with and without the lines bellow are welcome
                 */

                if (priv->firm_version < 0x0302) {
                        if (priv->cur_fw.type & DTV7)
                                offset += 500000;
                } else {
                        if (priv->cur_fw.type & DTV7)
                                offset -= 300000;
                        else if (type != ATSC) /* DVB @6MHz, DTV 8 and
DTV 7/8 */
                                offset += 200000;
                }
/* #endif */




                 reply	other threads:[~2013-01-21  2:09 UTC|newest]

Thread overview: [no followups] expand[flat|nested]  mbox.gz  Atom feed

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20130121020324.GB9028@orion \
    --to=gc2majortom@gmail.com \
    --cc=linux-media@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).