From: 'Sakari Ailus' <sakari.ailus@iki.fi>
To: Hans Verkuil <hverkuil@xs4all.nl>
Cc: Kamil Debski <k.debski@samsung.com>,
Sylwester Nawrocki <s.nawrocki@samsung.com>,
linux-media@vger.kernel.org, arun.kk@samsung.com,
mchehab@redhat.com, laurent.pinchart@ideasonboard.com,
hans.verkuil@cisco.com, kyungmin.park@samsung.com
Subject: Re: [PATCH 3/3] v4l: Set proper timestamp type in selected drivers which use videobuf2
Date: Wed, 23 Jan 2013 15:55:14 +0200 [thread overview]
Message-ID: <20130123135514.GD18639@valkosipuli.retiisi.org.uk> (raw)
In-Reply-To: <201301231003.47396.hverkuil@xs4all.nl>
On Wed, Jan 23, 2013 at 10:03:47AM +0100, Hans Verkuil wrote:
...
> Right. And in my view there should be no default timestamp. Drivers should
> always select MONOTONIC or COPY, and never UNKNOWN. The vb2 code should
> check for that and issue a WARN_ON if no proper timestamp type was provided.
>
> v4l2-compliance already checks for that as well.
I agree with that.
Speaking of non-vb2 drivers --- I guess there's no reason for a driver not
to use vb2 these days. There are actually already multple reasons to use it
instead.
So, vb2 drivers should choose the timestamps, and non-vb2 drivers... well,
we shouldn't have more, but in case we do, they _must_ set the timestamp
type, as there's no "default" since the relevant IOCTLs are handled by the
driver itself rather than the V4L2 framework.
--
Kind regards,
Sakari Ailus
e-mail: sakari.ailus@iki.fi XMPP: sailus@retiisi.org.uk
next prev parent reply other threads:[~2013-01-23 13:55 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-01-14 9:36 [PATCH/RFC 0/3] Add proper timestamp types handling in videobuf2 Kamil Debski
2013-01-14 9:36 ` [PATCH 1/3] v4l: Define video buffer flag for the COPY timestamp type Kamil Debski
2013-01-14 9:36 ` [PATCH 2/3] vb2: Add support for non monotonic timestamps Kamil Debski
2013-01-14 9:36 ` [PATCH 3/3] v4l: Set proper timestamp type in selected drivers which use videobuf2 Kamil Debski
2013-01-19 17:43 ` Sakari Ailus
2013-01-21 14:07 ` Kamil Debski
2013-01-22 10:03 ` 'Sakari Ailus'
2013-01-22 10:24 ` Kamil Debski
2013-01-23 0:25 ` Laurent Pinchart
2013-01-23 8:46 ` Kamil Debski
2013-01-24 1:10 ` Laurent Pinchart
2013-01-22 10:35 ` Hans Verkuil
2013-01-22 17:57 ` Kamil Debski
2013-01-22 10:37 ` Sylwester Nawrocki
2013-01-22 17:58 ` Kamil Debski
2013-01-22 18:44 ` 'Sakari Ailus'
2013-01-23 8:47 ` Kamil Debski
2013-01-23 9:03 ` Hans Verkuil
2013-01-23 13:55 ` 'Sakari Ailus' [this message]
2013-01-23 14:50 ` Kamil Debski
2013-01-22 9:43 ` Kamil Debski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130123135514.GD18639@valkosipuli.retiisi.org.uk \
--to=sakari.ailus@iki.fi \
--cc=arun.kk@samsung.com \
--cc=hans.verkuil@cisco.com \
--cc=hverkuil@xs4all.nl \
--cc=k.debski@samsung.com \
--cc=kyungmin.park@samsung.com \
--cc=laurent.pinchart@ideasonboard.com \
--cc=linux-media@vger.kernel.org \
--cc=mchehab@redhat.com \
--cc=s.nawrocki@samsung.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox