From: "Michael Büsch" <m@bues.ch>
To: linux-media@vger.kernel.org
Cc: mchehab@redhat.com
Subject: Re: [git:v4l-dvb/for_v3.9] [media] fc0011: Return early, if the frequency is already tuned
Date: Mon, 11 Feb 2013 21:59:19 +0100 [thread overview]
Message-ID: <20130211215919.344d30ee@milhouse> (raw)
In-Reply-To: <E1U3tzD-0007O1-4M@www.linuxtv.org>
[-- Attachment #1: Type: text/plain, Size: 1439 bytes --]
Can you please revert this one again? It might cause issues if the dvb device
is reset/reinitialized.
On Fri, 08 Feb 2013 20:51:36 +0100
Mauro Carvalho Chehab <mchehab@redhat.com> wrote:
> This is an automatic generated email to let you know that the following patch were queued at the
> http://git.linuxtv.org/media_tree.git tree:
>
> Subject: [media] fc0011: Return early, if the frequency is already tuned
> Author: Michael Büsch <m@bues.ch>
> Date: Thu Feb 7 12:21:06 2013 -0300
>
> Return early, if we already tuned to a frequency.
>
> Signed-off-by: Michael Buesch <m@bues.ch>
> Signed-off-by: Mauro Carvalho Chehab <mchehab@redhat.com>
>
> drivers/media/tuners/fc0011.c | 3 +++
> 1 files changed, 3 insertions(+), 0 deletions(-)
>
> ---
>
> http://git.linuxtv.org/media_tree.git?a=commitdiff;h=a92591a7112042f92b609be42bc332d989776e9b
>
> diff --git a/drivers/media/tuners/fc0011.c b/drivers/media/tuners/fc0011.c
> index 3932aa8..18caab1 100644
> --- a/drivers/media/tuners/fc0011.c
> +++ b/drivers/media/tuners/fc0011.c
> @@ -187,6 +187,9 @@ static int fc0011_set_params(struct dvb_frontend *fe)
> u8 fa, fp, vco_sel, vco_cal;
> u8 regs[FC11_NR_REGS] = { };
>
> + if (priv->frequency == p->frequency)
> + return 0;
> +
> regs[FC11_REG_7] = 0x0F;
> regs[FC11_REG_8] = 0x3E;
> regs[FC11_REG_10] = 0xB8;
>
--
Greetings, Michael.
PGP: 908D8B0E
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 836 bytes --]
parent reply other threads:[~2013-02-11 20:59 UTC|newest]
Thread overview: expand[flat|nested] mbox.gz Atom feed
[parent not found: <E1U3tzD-0007O1-4M@www.linuxtv.org>]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130211215919.344d30ee@milhouse \
--to=m@bues.ch \
--cc=linux-media@vger.kernel.org \
--cc=mchehab@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).