From: Ismael Luceno <ismael.luceno@corp.bluecherry.net>
To: Hans Verkuil <hverkuil@xs4all.nl>
Cc: linux-media@vger.kernel.org
Subject: Re: [RFC PATCH 00/20] solo6x10: V4L2 compliancy fixes and major overhaul
Date: Thu, 7 Mar 2013 15:46:53 -0300 [thread overview]
Message-ID: <20130307154653.32b94e7f@pirotess> (raw)
In-Reply-To: <1362267936-6772-1-git-send-email-hverkuil@xs4all.nl>
On Sun, 3 Mar 2013 00:45:16 +0100
Hans Verkuil <hverkuil@xs4all.nl> wrote:
> 3) What is the meaning of this snippet of code in v4l2-enc.c?
>
> if (pix->priv)
> solo_enc->type = SOLO_ENC_TYPE_EXT;
>
> I've commented it out since it is completely undocumented and no
> driver should assume that priv is non-zero anymore, precisely because
> of issues like this. Ismael, do you know what the difference is
> between SOLO_ENC_TYPE_STD and SOLO_ENC_TYPE_EXT?
When written to the first bit of the 0x480-0x4BC registers
(SOLO_CAP_CH_COMP_ENA_E(n)), it enables the encoding of the respective
extended channel.
It's a bad name :/.
prev parent reply other threads:[~2013-03-07 18:52 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-03-02 23:45 [RFC PATCH 00/20] solo6x10: V4L2 compliancy fixes and major overhaul Hans Verkuil
2013-03-02 23:45 ` [RFC PATCH 01/20] videobuf2: add gfp_flags Hans Verkuil
2013-03-02 23:45 ` [RFC PATCH 02/20] vb2-dma-sg: add debug module option Hans Verkuil
2013-03-02 23:45 ` [RFC PATCH 03/20] solo6x10: fix querycap Hans Verkuil
2013-03-02 23:45 ` [RFC PATCH 04/20] solo6x10: add v4l2_device Hans Verkuil
2013-03-02 23:45 ` [RFC PATCH 05/20] solo6x10: add control framework Hans Verkuil
2013-03-02 23:45 ` [RFC PATCH 06/20] solo6x10: fix scheduling while atomic error Hans Verkuil
2013-03-02 23:45 ` [RFC PATCH 07/20] solo6x10: fix various format-related compliancy issues Hans Verkuil
2013-03-02 23:45 ` [RFC PATCH 08/20] solo6x10: add support for prio and control event handling Hans Verkuil
2013-03-02 23:45 ` [RFC PATCH 09/20] solo6x10: move global fields in solo_enc_fh to solo_enc_dev Hans Verkuil
2013-03-02 23:45 ` [RFC PATCH 10/20] solo6x10: move global fields in solo_dev_fh to solo_dev Hans Verkuil
2013-03-02 23:45 ` [RFC PATCH 11/20] solo6x10: add missing size-- to enc_write_sg Hans Verkuil
2013-03-02 23:45 ` [RFC PATCH 12/20] solo6x10: rename the spinlock 'lock' to 'slock' Hans Verkuil
2013-03-02 23:45 ` [RFC PATCH 13/20] solo6x10: convert encoder nodes to vb2 Hans Verkuil
2013-03-02 23:45 ` [RFC PATCH 14/20] solo6x10: convert the display node " Hans Verkuil
2013-03-02 23:45 ` [RFC PATCH 15/20] solo6x10: use monotonic timestamps Hans Verkuil
2013-03-02 23:45 ` [RFC PATCH 16/20] solo6x10: drop video_type and add proper s_std support Hans Verkuil
2013-03-02 23:45 ` [RFC PATCH 17/20] solo6x10: update buffer flags to fix clash with existing flags Hans Verkuil
2013-03-02 23:45 ` [RFC PATCH 18/20] solo6x10: use correct __GFP_DMA32 flags Hans Verkuil
2013-03-02 23:45 ` [RFC PATCH 19/20] solo6x10: small big-endian fix Hans Verkuil
2013-03-02 23:45 ` [RFC PATCH 20/20] solo6x10: also stop DMA if the SOLO_PCI_ERR_P2M_DESC is raised Hans Verkuil
2013-03-07 18:46 ` Ismael Luceno [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130307154653.32b94e7f@pirotess \
--to=ismael.luceno@corp.bluecherry.net \
--cc=hverkuil@xs4all.nl \
--cc=linux-media@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox