From: Arnd Bergmann <arnd@arndb.de>
To: Fabio Porcedda <fabio.porcedda@gmail.com>
Cc: H Hartley Sweeten <hartleys@visionengravers.com>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"linux-arm-kernel@lists.infradead.org"
<linux-arm-kernel@lists.infradead.org>,
"linux-media@vger.kernel.org" <linux-media@vger.kernel.org>,
"linux-ide@vger.kernel.org" <linux-ide@vger.kernel.org>,
"lm-sensors@lm-sensors.org" <lm-sensors@lm-sensors.org>,
"linux-input@vger.kernel.org" <linux-input@vger.kernel.org>,
"linux-fbdev@vger.kernel.org" <linux-fbdev@vger.kernel.org>,
"Greg Kroah-Hartman" <gregkh@linuxfoundation.org>,
"Hans-Christian Egtvedt" <hans-christian.egtvedt@atmel.com>,
Grant Likely <grant.likely@secretlab.ca>
Subject: Re: [PATCH 10/10] drivers: misc: use module_platform_driver_probe()
Date: Mon, 18 Mar 2013 10:58:51 +0000 [thread overview]
Message-ID: <201303181058.51641.arnd@arndb.de> (raw)
In-Reply-To: <CAHkwnC9YFTw8gVzyZB3_gZCgM5zMA6tLch15EDqcA2F4CAOpAQ@mail.gmail.com>
On Monday 18 March 2013, Fabio Porcedda wrote:
> Since by using platform_driver_probe() the function
> ep93xx_pwm_probe() is freed after initialization,
> is better to use module_platform_drive_probe().
> IMHO i don't see any good reason to use module_platform_driver() for
> this driver.
As I commented earlier, the platform_driver_probe() and
module_platform_drive_probe() interfaces are rather dangerous in combination
with deferred probing, I would much prefer Harley's patch.
Arnd
next prev parent reply other threads:[~2013-03-18 10:59 UTC|newest]
Thread overview: 39+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-03-14 13:11 [PATCH 00/10] Use module_platform_driver_probe() part 2 Fabio Porcedda
2013-03-14 13:11 ` [PATCH 01/10] drivers: media: use module_platform_driver_probe() Fabio Porcedda
2013-03-14 13:25 ` Guennadi Liakhovetski
2013-03-14 16:40 ` Fabio Porcedda
2013-03-14 13:11 ` [PATCH] drivers: misc: " Fabio Porcedda
2013-03-14 13:11 ` [PATCH 02/10] drivers: ata: " Fabio Porcedda
2013-03-14 13:11 ` [PATCH 03/10] drivers: char: " Fabio Porcedda
2013-03-14 13:11 ` [PATCH 04/10] drivers: hwmon: " Fabio Porcedda
2013-03-14 14:01 ` Guenter Roeck
2013-03-14 16:42 ` Fabio Porcedda
2013-03-14 13:11 ` [PATCH 05/10] drivers: ide: " Fabio Porcedda
2013-03-14 13:11 ` [PATCH 06/10] drivers: input: " Fabio Porcedda
2013-03-14 13:11 ` [PATCH 07/10] drivers: memory: " Fabio Porcedda
2013-03-14 13:11 ` [PATCH 08/10] drivers: mfd: " Fabio Porcedda
2013-04-09 8:06 ` Samuel Ortiz
2013-04-09 9:23 ` Fabio Porcedda
2013-03-14 13:11 ` [PATCH 09/10] drivers: video: " Fabio Porcedda
2013-03-14 13:11 ` [PATCH 10/10] drivers: misc: " Fabio Porcedda
2013-03-14 13:58 ` Arnd Bergmann
2013-03-14 14:06 ` Sascha Hauer
2013-03-15 11:18 ` Fabio Porcedda
2013-03-15 11:28 ` Arnd Bergmann
2013-03-15 18:09 ` Fabio Porcedda
2013-03-15 17:43 ` H Hartley Sweeten
2013-03-15 20:18 ` Arnd Bergmann
2013-03-18 10:03 ` Fabio Porcedda
2013-03-18 10:58 ` Arnd Bergmann [this message]
2013-03-18 11:20 ` Fabio Porcedda
2013-03-18 11:28 ` Arnd Bergmann
2013-03-19 8:55 ` Fabio Porcedda
2013-03-19 9:04 ` Geert Uytterhoeven
2013-03-19 16:48 ` Arnd Bergmann
2013-03-19 17:11 ` Fabio Porcedda
2013-03-19 17:59 ` Arnd Bergmann
2013-03-20 9:02 ` Fabio Porcedda
2013-03-20 10:20 ` Arnd Bergmann
2013-03-20 10:39 ` Fabio Porcedda
2013-03-20 11:46 ` Arnd Bergmann
2013-03-21 13:10 ` Fabio Porcedda
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201303181058.51641.arnd@arndb.de \
--to=arnd@arndb.de \
--cc=fabio.porcedda@gmail.com \
--cc=grant.likely@secretlab.ca \
--cc=gregkh@linuxfoundation.org \
--cc=hans-christian.egtvedt@atmel.com \
--cc=hartleys@visionengravers.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-fbdev@vger.kernel.org \
--cc=linux-ide@vger.kernel.org \
--cc=linux-input@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=lm-sensors@lm-sensors.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).