Re: [PATCH 2/2] dvb_frontend: Simplify the emulation logic

[Mauro Carvalho Chehab <mchehab@redhat.com>]

Em Mon, 18 Mar 2013 17:05:12 -0300
Fabio Estevam <festevam@gmail.com> escreveu:

> Hi Mauro,
> 
> On Mon, Mar 18, 2013 at 4:25 PM, Mauro Carvalho Chehab
> <mchehab@redhat.com> wrote:
> 
> > -static int emulate_delivery_system(struct dvb_frontend *fe,
> > -                                  enum dvbv3_emulation_type type,
> > -                                  u32 delsys, u32 desired_system)
> > +/**
> > + * emulate_delivery_system - emulate a DVBv5 delivery system with a DVBv3 type
> > + * @fe:                        struct frontend;
> > + * @desired_system:    DVBv5 type that will be used for emulation
> 
> 'desired_system' parameter has been removed in this patch. 'delsys'
> should be put in the description instead.

Thanks for reviewing it!

Yeah, internally I made several versions of this patch, in order to make
each routine clear. On the very last minute, I ended by just removing
desired_system, keeping just one parameter there after fe.

I'm changing it at the version I'm committing.

Thanks!
Mauro