From: Mauro Carvalho Chehab <mchehab@redhat.com>
To: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
Cc: Mark Brown <broonie@kernel.org>,
Sylwester Nawrocki <s.nawrocki@samsung.com>,
linux-media@vger.kernel.org,
Mike Turquette <mturquette@linaro.org>
Subject: Re: [GIT PULL FOR v3.10] Camera sensors patches
Date: Wed, 17 Apr 2013 11:36:39 -0300 [thread overview]
Message-ID: <20130417113639.1c98f574@redhat.com> (raw)
In-Reply-To: <20130417135503.GL13687@opensource.wolfsonmicro.com>
Em Wed, 17 Apr 2013 14:55:03 +0100
Mark Brown <broonie@kernel.org> escreveu:
> On Tue, Apr 16, 2013 at 08:04:52PM +0200, Sylwester Nawrocki wrote:
>
> > It's probably more clean to provide a dummy clock/regulator in a host driver
> > (platform) than to add something in a sub-device drivers that would resolve
> > which resources should be requested and which not.
>
> Yes, that's the general theory for regulators at least - it allows the
> device driver to just trundle along and not worry about how the board is
> hooked up. The other issue it resolves that you didn't mention is that
> it avoids just ignoring errors which isn't terribly clever.
I agree. Adding dummy clock/regulator at the host platform driver makes
sense, as the platform driver knows how the board is hooked up; keeping
it at the I2C driver doesn't make sense, so the code needs to be moved
away from it.
Laurent,
Could you please work on a patch moving that code to the host platform
driver?
Thanks!
Mauro
next prev parent reply other threads:[~2013-04-17 14:36 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-04-12 9:13 [GIT PULL FOR v3.10] Camera sensors patches Laurent Pinchart
2013-04-14 19:59 ` Mauro Carvalho Chehab
2013-04-15 10:19 ` Laurent Pinchart
2013-04-15 12:42 ` Mauro Carvalho Chehab
2013-04-16 15:30 ` Laurent Pinchart
2013-04-16 17:36 ` Mauro Carvalho Chehab
2013-04-16 18:04 ` Sylwester Nawrocki
2013-04-17 13:55 ` Mark Brown
2013-04-17 14:36 ` Mauro Carvalho Chehab [this message]
2013-04-21 23:14 ` Laurent Pinchart
2013-04-22 10:03 ` Mark Brown
2013-04-22 12:46 ` Mauro Carvalho Chehab
2013-04-22 12:56 ` Mark Brown
2013-04-22 12:46 ` Mauro Carvalho Chehab
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130417113639.1c98f574@redhat.com \
--to=mchehab@redhat.com \
--cc=broonie@kernel.org \
--cc=laurent.pinchart@ideasonboard.com \
--cc=linux-media@vger.kernel.org \
--cc=mturquette@linaro.org \
--cc=s.nawrocki@samsung.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).