From: Dan Carpenter <dan.carpenter@oracle.com>
To: Mauro Carvalho Chehab <mchehab@redhat.com>
Cc: linux-media@vger.kernel.org, kernel-janitors@vger.kernel.org,
kbuild@01.org
Subject: [patch 1/2] [media] r820t: precendence bug in r820t_xtal_check()
Date: Thu, 18 Apr 2013 22:20:40 +0300 [thread overview]
Message-ID: <20130418192040.GA17798@elgon.mountain> (raw)
The test as written is always false. It looks like the intent was to
test that the bit was not set.
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
diff --git a/drivers/media/tuners/r820t.c b/drivers/media/tuners/r820t.c
index 905a106..ba033fd 100644
--- a/drivers/media/tuners/r820t.c
+++ b/drivers/media/tuners/r820t.c
@@ -1378,7 +1378,7 @@ static int r820t_xtal_check(struct r820t_priv *priv)
rc = r820t_read(priv, 0x00, data, sizeof(data));
if (rc < 0)
return rc;
- if ((!data[2]) & 0x40)
+ if (!(data[2] & 0x40))
continue;
val = data[2] & 0x3f;
reply other threads:[~2013-04-18 19:20 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130418192040.GA17798@elgon.mountain \
--to=dan.carpenter@oracle.com \
--cc=kbuild@01.org \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=mchehab@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).