* [patch 1/2] [media] r820t: precendence bug in r820t_xtal_check()
@ 2013-04-18 19:20 Dan Carpenter
0 siblings, 0 replies; only message in thread
From: Dan Carpenter @ 2013-04-18 19:20 UTC (permalink / raw)
To: Mauro Carvalho Chehab; +Cc: linux-media, kernel-janitors, kbuild
The test as written is always false. It looks like the intent was to
test that the bit was not set.
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
diff --git a/drivers/media/tuners/r820t.c b/drivers/media/tuners/r820t.c
index 905a106..ba033fd 100644
--- a/drivers/media/tuners/r820t.c
+++ b/drivers/media/tuners/r820t.c
@@ -1378,7 +1378,7 @@ static int r820t_xtal_check(struct r820t_priv *priv)
rc = r820t_read(priv, 0x00, data, sizeof(data));
if (rc < 0)
return rc;
- if ((!data[2]) & 0x40)
+ if (!(data[2] & 0x40))
continue;
val = data[2] & 0x3f;
^ permalink raw reply related [flat|nested] only message in thread
only message in thread, other threads:[~2013-04-18 19:20 UTC | newest]
Thread overview: (only message) (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2013-04-18 19:20 [patch 1/2] [media] r820t: precendence bug in r820t_xtal_check() Dan Carpenter
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).