From: Mauro Carvalho Chehab <mchehab@redhat.com>
To: Ezequiel Garcia <ezequiel.garcia@free-electrons.com>
Cc: "Jon Arne Jørgensen" <jonarne@jonarne.no>,
"Linux Media Mailing List" <linux-media@vger.kernel.org>
Subject: Re: [PATCH 0/2] saa7115: add detection code for gm7113c
Date: Fri, 26 Apr 2013 11:25:59 -0300 [thread overview]
Message-ID: <20130426112559.7d642984@redhat.com> (raw)
In-Reply-To: <20130426134621.GC20185@localhost>
Em Fri, 26 Apr 2013 10:46:22 -0300
Ezequiel Garcia <ezequiel.garcia@free-electrons.com> escreveu:
> Hi Mauro,
>
> Thanks for the patch!
>
> On Fri, Apr 26, 2013 at 09:49:15AM -0300, Mauro Carvalho Chehab wrote:
> >
> > I didn't add there the part of your code with the gm7113c specifics,
> > as I prefer if you can rebase your patch on the top of those two,
> > of course assuming that they'll work.
> >
> > Patches weren't test yet.
> >
> > Jen/Ezequiel,
> >
> > Could you please test them?
> >
>
> I've done some quick testing on stk1160+saa7113 and also stk1160+gm7113c,
> everything looks OK (except from the minor misname comment, see the patch 2/2).
Thanks for testing and for the comments.
Just respin a v2 fixing the pointed minor pitnicks.
> Let me do some more testing just to be sure.
Ok. I don't intend to merge it without Jon's patches.
> @Jon: Do you mind sending the standard fix for gm7113c? We need those
> to make stk1160+gm7113c work. I'll put my Tested-by so we can merge it!
>
> FWIW, some user reported he didn't need those quirks to capture a PAL (?)
> source. But in my experience, I *do* need them, otherwise I get a noisy
> PAL-Nc output and no video capture at all on NTSC/PAL-M.
>
> Thanks a lot for the good work!
Regards,
Mauro
prev parent reply other threads:[~2013-04-26 14:26 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-04-26 12:49 [PATCH 0/2] saa7115: add detection code for gm7113c Mauro Carvalho Chehab
2013-04-26 12:49 ` [PATCH 1/2] saa7115: move the autodetection code out of the probe function Mauro Carvalho Chehab
2013-04-26 13:41 ` Ezequiel Garcia
2013-04-26 12:49 ` [PATCH 2/2] saa7115: add detection code for gm7113c Mauro Carvalho Chehab
2013-04-26 13:39 ` Ezequiel Garcia
2013-04-26 13:46 ` [PATCH 0/2] " Ezequiel Garcia
2013-04-26 14:25 ` Mauro Carvalho Chehab [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130426112559.7d642984@redhat.com \
--to=mchehab@redhat.com \
--cc=ezequiel.garcia@free-electrons.com \
--cc=jonarne@jonarne.no \
--cc=linux-media@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).