linux-media.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Mauro Carvalho Chehab <mchehab@redhat.com>
To: Patrick Boettcher <pboettcher@kernellabs.com>
Cc: linux-media@vger.kernel.org,
	Olivier GRENIE <olivier.grenie@parrot.com>,
	Patrick BOETTCHER <patrick.boettcher@parrot.com>
Subject: Re: [GIT PULL FOR 3.10] DiBxxxx: fixes and improvements
Date: Sat, 27 Apr 2013 11:28:33 -0300	[thread overview]
Message-ID: <20130427112833.203d7fbb@redhat.com> (raw)
In-Reply-To: <1411209.JetyNPSOgp@dibcom294>

Hi Patrick,

Em Mon, 22 Apr 2013 10:12:34 +0200
Patrick Boettcher <pboettcher@kernellabs.com> escreveu:

> Hi Mauro,
> 
> These patches contains some fixes and changes for the DiBcom demods and 
> SIPs.
> 
> Please merge for 3.10 if possible.
> 
> 
> The following changes since commit 60d509fa6a9c4653a86ad830e4c4b30360b23f0e:
> 
>   Linux 3.9-rc8 (2013-04-21 14:38:45 -0700)
> 
> are available in the git repository at:
> 
>   git://git.linuxtv.org/pb/media_tree.git/ master

Hmm... I suspect that there's something wrong with those changes.

Testing it with a dib8076 usb stick seems that the code is worse than
before, as it is now harder to get a lock here.

With the previous code:

INFO     Scanning frequency #1 725142857
Carrier(0x03) Signal= 67.46% C/N= 0.00% UCB= 0 postBER= 0
Viterbi(0x05) Signal= 67.08% C/N= 0.00% UCB= 0 postBER= 2097151
Viterbi(0x07) Signal= 67.54% C/N= 0.25% UCB= 165 postBER= 0
Sync   (0x0f) Signal= 67.06% C/N= 0.23% UCB= 151 postBER= 0
Lock   (0x1f) Signal= 67.58% C/N= 0.24% UCB= 160 postBER= 338688
Service #0 (60320) BAND HD channel 57.1.0
Service #1 (60345) BAND 1SEG channel 57.1.1

With the new code:

INFO     Scanning frequency #1 725142857
       (0x00) Signal= 68.80% C/N= 0.00% UCB= 0 postBER= 0
RF     (0x01) Signal= 68.78% C/N= 0.00% UCB= 0 postBER= 0
RF     (0x01) Signal= 68.69% C/N= 0.00% UCB= 0 postBER= 0
RF     (0x01) Signal= 69.82% C/N= 0.00% UCB= 0 postBER= 0
RF     (0x01) Signal= 69.29% C/N= 0.00% UCB= 0 postBER= 0
RF     (0x01) Signal= 69.27% C/N= 0.00% UCB= 0 postBER= 0
RF     (0x01) Signal= 69.28% C/N= 0.00% UCB= 0 postBER= 0
RF     (0x01) Signal= 69.27% C/N= 0.00% UCB= 0 postBER= 0
RF     (0x01) Signal= 68.55% C/N= 0.00% UCB= 0 postBER= 0
RF     (0x01) Signal= 68.50% C/N= 0.00% UCB= 0 postBER= 0
RF     (0x01) Signal= 68.43% C/N= 0.00% UCB= 0 postBER= 0
RF     (0x01) Signal= 68.65% C/N= 0.00% UCB= 0 postBER= 0
RF     (0x01) Signal= 69.75% C/N= 0.00% UCB= 0 postBER= 0
RF     (0x01) Signal= 69.29% C/N= 0.00% UCB= 0 postBER= 0
RF     (0x01) Signal= 69.28% C/N= 0.00% UCB= 0 postBER= 0
RF     (0x01) Signal= 69.25% C/N= 0.00% UCB= 0 postBER= 0
RF     (0x01) Signal= 68.43% C/N= 0.00% UCB= 0 postBER= 0
RF     (0x01) Signal= 68.46% C/N= 0.00% UCB= 0 postBER= 0
RF     (0x01) Signal= 68.43% C/N= 0.00% UCB= 0 postBER= 0
RF     (0x01) Signal= 68.90% C/N= 0.00% UCB= 0 postBER= 0
RF     (0x01) Signal= 69.50% C/N= 0.00% UCB= 0 postBER= 0
RF     (0x01) Signal= 69.28% C/N= 0.00% UCB= 0 postBER= 0
RF     (0x01) Signal= 69.22% C/N= 0.00% UCB= 0 postBER= 0
RF     (0x01) Signal= 69.22% C/N= 0.00% UCB= 0 postBER= 0
RF     (0x01) Signal= 68.43% C/N= 0.00% UCB= 0 postBER= 0
RF     (0x01) Signal= 68.41% C/N= 0.00% UCB= 0 postBER= 0
RF     (0x01) Signal= 68.41% C/N= 0.00% UCB= 0 postBER= 0
RF     (0x01) Signal= 68.96% C/N= 0.00% UCB= 0 postBER= 0
RF     (0x01) Signal= 69.42% C/N= 0.00% UCB= 0 postBER= 0
RF     (0x01) Signal= 69.24% C/N= 0.00% UCB= 0 postBER= 0
RF     (0x01) Signal= 69.22% C/N= 0.00% UCB= 0 postBER= 0
RF     (0x01) Signal= 69.25% C/N= 0.00% UCB= 0 postBER= 0

So, it seems that the changes broke something.

Regards,
Mauro

  reply	other threads:[~2013-04-27 14:28 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-04-22  8:12 [GIT PULL FOR 3.10] DiBxxxx: fixes and improvements Patrick Boettcher
2013-04-27 14:28 ` Mauro Carvalho Chehab [this message]
2013-04-28 20:28   ` Olivier GRENIE
2013-05-04  4:05   ` Olivier GRENIE
2013-06-02 17:03     ` Michael Krufky

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20130427112833.203d7fbb@redhat.com \
    --to=mchehab@redhat.com \
    --cc=linux-media@vger.kernel.org \
    --cc=olivier.grenie@parrot.com \
    --cc=patrick.boettcher@parrot.com \
    --cc=pboettcher@kernellabs.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).