From: Ezequiel Garcia <ezequiel.garcia@free-electrons.com>
To: "Jon Arne Jørgensen" <jonarne@jonarne.no>
Cc: mchehab@redhat.com, linux-media@vger.kernel.org,
jonjon.arnearne@gmail.com
Subject: Re: [PATCH 0/3] saa7115: add detection code for gm7113c
Date: Thu, 2 May 2013 23:00:41 -0300 [thread overview]
Message-ID: <20130503020039.GA5722@localhost> (raw)
In-Reply-To: <1367268069-11429-1-git-send-email-jonarne@jonarne.no>
Hi Jon,
On Mon, Apr 29, 2013 at 10:41:06PM +0200, Jon Arne Jørgensen wrote:
> This is the second version of a patch-set previously posted by Mauro,
> the first verseon was posted on 26 April, and can be found here:
> http://www.spinics.net/lists/linux-media/msg63079.html
>
> The purpose of this patch is to add support for the gm7113c chip in the saa7115 driver.
> The gm7113c chip is a chinese clone of the Philips/NXP saa7113 chip.
> The chip is found in several cheap usb video capture devices.
>
> drivers/media/i2c/saa7115.c | 207 +++++++++++++++++++++++++++++-----------
> include/media/v4l2-chip-ident.h | 2 +
> 2 files changed, 155 insertions(+), 54 deletions(-)
>
Good work! Just some minor comments about the way the patchset
has been submitted.
First of all, this is a very ackward cover letter patch (cover letter is
the zero-index patch). I think you will find easier to use
git-format-patch command like this (just an example):
# Create a three-patch patchset:
$ git format-patch -3 --cover-letter --subject "PATCH v2" -o my-v2-patchset
--
Ezequiel García, Free Electrons
Embedded Linux, Kernel and Android Engineering
http://free-electrons.com
next prev parent reply other threads:[~2013-05-03 2:00 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-04-29 20:41 [PATCH 0/3] saa7115: add detection code for gm7113c Jon Arne Jørgensen
2013-04-29 20:41 ` [PATCH V2 1/3] saa7115: move the autodetection code out of the probe function Jon Arne Jørgensen
2013-05-03 2:09 ` Ezequiel Garcia
2013-05-03 6:32 ` Jon Arne Jørgensen
2013-05-03 11:37 ` Mauro Carvalho Chehab
2013-05-03 6:58 ` Jon Arne Jørgensen
2013-05-03 11:20 ` Ezequiel Garcia
2013-05-03 12:08 ` Mauro Carvalho Chehab
2013-05-05 8:20 ` Jon Arne Jørgensen
2013-05-05 11:29 ` Mauro Carvalho Chehab
2013-04-29 20:41 ` [PATCH V2 2/3] saa7115: add detection code for gm7113c Jon Arne Jørgensen
2013-05-03 2:10 ` Ezequiel Garcia
2013-04-29 20:41 ` [PATCH V2 3/3] saa7115: Add register setup and config " Jon Arne Jørgensen
2013-05-03 2:24 ` Ezequiel Garcia
2013-05-03 6:35 ` Jon Arne Jørgensen
2013-05-03 2:00 ` Ezequiel Garcia [this message]
2013-05-03 6:27 ` [PATCH 0/3] saa7115: add detection code " Jon Arne Jørgensen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130503020039.GA5722@localhost \
--to=ezequiel.garcia@free-electrons.com \
--cc=jonarne@jonarne.no \
--cc=jonjon.arnearne@gmail.com \
--cc=linux-media@vger.kernel.org \
--cc=mchehab@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).