Can you take a look at these dvb-apps warnings/errors?

Can you take a look at these dvb-apps warnings/errors?

[Hans Verkuil]

Hi Mauro,

Can you take a look at these? The daily build is failing because of this.

Thanks!

	Hans

test_video.c:322:2: warning: format ‘%d’ expects argument of type ‘int’, but argument 2 has type ‘ssize_t’ [-Wformat]
dvbscan.c:128:6: warning: variable ‘output_type’ set but not used [-Wunused-but-set-variable]
dvbscan.c:126:6: warning: variable ‘uk_ordering’ set but not used [-Wunused-but-set-variable]
dvbscan.c:124:32: warning: variable ‘inversion’ set but not used [-Wunused-but-set-variable]
dvbscan_dvb.c:27:44: warning: unused parameter ‘fe’ [-Wunused-parameter]
dvbscan_atsc.c:27:45: warning: unused parameter ‘fe’ [-Wunused-parameter]
util.c:193:7: error: ‘SYS_DVBC_ANNEX_A’ undeclared (first use in this function)
util.c:194:7: error: ‘SYS_DVBC_ANNEX_C’ undeclared (first use in this function)
util.c:262:26: error: ‘DTV_ENUM_DELSYS’ undeclared (first use in this function)
util.c:263:1: warning: control reaches end of non-void function [-Wreturn-type]
make[2]: *** [util.o] Error 1
make[1]: *** [all] Error 2
make: *** [all] Error 2

Re: Can you take a look at these dvb-apps warnings/errors?

[Mauro Carvalho Chehab]

Hi Hans,

Em Fri, 17 May 2013 10:30:57 +0200
Hans Verkuil <hverkuil@xs4all.nl> escreveu:

> Hi Mauro,
> 
> Can you take a look at these? The daily build is failing because of this.
> 
> Thanks!
> 
> 	Hans
> 
> test_video.c:322:2: warning: format ‘%d’ expects argument of type ‘int’, but argument 2 has type ‘ssize_t’ [-Wformat]
> dvbscan.c:128:6: warning: variable ‘output_type’ set but not used [-Wunused-but-set-variable]
> dvbscan.c:126:6: warning: variable ‘uk_ordering’ set but not used [-Wunused-but-set-variable]
> dvbscan.c:124:32: warning: variable ‘inversion’ set but not used [-Wunused-but-set-variable]
> dvbscan_dvb.c:27:44: warning: unused parameter ‘fe’ [-Wunused-parameter]
> dvbscan_atsc.c:27:45: warning: unused parameter ‘fe’ [-Wunused-parameter]
> util.c:193:7: error: ‘SYS_DVBC_ANNEX_A’ undeclared (first use in this function)
> util.c:194:7: error: ‘SYS_DVBC_ANNEX_C’ undeclared (first use in this function)
> util.c:262:26: error: ‘DTV_ENUM_DELSYS’ undeclared (first use in this function)
> util.c:263:1: warning: control reaches end of non-void function [-Wreturn-type]
> make[2]: *** [util.o] Error 1
> make[1]: *** [all] Error 2
> make: *** [all] Error 2

I'm not touching on dvb-apps for a long time. From my side, all I need in
terms of userspace apps for DVB is there at dvbv5/libdvbv5 on v4l-utils.

That's said, from the above errors, it seems that it got added (partial)
support for DVB v5 but, somehow, it is compiling with an older
dvb/frontend.h header on your build.

Regards,
Mauro

Re: Can you take a look at these dvb-apps warnings/errors?

[Hans Verkuil]

On Mon 20 May 2013 23:22:15 Mauro Carvalho Chehab wrote:
> Hi Hans,
> 
> Em Fri, 17 May 2013 10:30:57 +0200
> Hans Verkuil <hverkuil@xs4all.nl> escreveu:
> 
> > Hi Mauro,
> > 
> > Can you take a look at these? The daily build is failing because of this.
> > 
> > Thanks!
> > 
> > 	Hans
> > 
> > test_video.c:322:2: warning: format ‘%d’ expects argument of type ‘int’, but argument 2 has type ‘ssize_t’ [-Wformat]
> > dvbscan.c:128:6: warning: variable ‘output_type’ set but not used [-Wunused-but-set-variable]
> > dvbscan.c:126:6: warning: variable ‘uk_ordering’ set but not used [-Wunused-but-set-variable]
> > dvbscan.c:124:32: warning: variable ‘inversion’ set but not used [-Wunused-but-set-variable]
> > dvbscan_dvb.c:27:44: warning: unused parameter ‘fe’ [-Wunused-parameter]
> > dvbscan_atsc.c:27:45: warning: unused parameter ‘fe’ [-Wunused-parameter]
> > util.c:193:7: error: ‘SYS_DVBC_ANNEX_A’ undeclared (first use in this function)
> > util.c:194:7: error: ‘SYS_DVBC_ANNEX_C’ undeclared (first use in this function)
> > util.c:262:26: error: ‘DTV_ENUM_DELSYS’ undeclared (first use in this function)
> > util.c:263:1: warning: control reaches end of non-void function [-Wreturn-type]
> > make[2]: *** [util.o] Error 1
> > make[1]: *** [all] Error 2
> > make: *** [all] Error 2
> 
> I'm not touching on dvb-apps for a long time. From my side, all I need in
> terms of userspace apps for DVB is there at dvbv5/libdvbv5 on v4l-utils.
> 
> That's said, from the above errors, it seems that it got added (partial)
> support for DVB v5 but, somehow, it is compiling with an older
> dvb/frontend.h header on your build.
> 
> Regards,
> Mauro
> 

I've running a 3.8 kernel on my daily build server, so that's why those
headers are old. I've manually updated the headers.

Note that dvb-apps has an include directory with old headers as well, but
those headers aren't used anyway it seems.

Should I bother with building dvb-apps at all?

Regards,

	Hans

Re: Can you take a look at these dvb-apps warnings/errors?

[Mauro Carvalho Chehab]

Em Tue, 21 May 2013 11:20:18 +0200
Hans Verkuil <hverkuil@xs4all.nl> escreveu:

> On Mon 20 May 2013 23:22:15 Mauro Carvalho Chehab wrote:
> > Hi Hans,
> > 
> > Em Fri, 17 May 2013 10:30:57 +0200
> > Hans Verkuil <hverkuil@xs4all.nl> escreveu:
> > 
> > > Hi Mauro,
> > > 
> > > Can you take a look at these? The daily build is failing because of this.
> > > 
> > > Thanks!
> > > 
> > > 	Hans
> > > 
> > > test_video.c:322:2: warning: format ‘%d’ expects argument of type ‘int’, but argument 2 has type ‘ssize_t’ [-Wformat]
> > > dvbscan.c:128:6: warning: variable ‘output_type’ set but not used [-Wunused-but-set-variable]
> > > dvbscan.c:126:6: warning: variable ‘uk_ordering’ set but not used [-Wunused-but-set-variable]
> > > dvbscan.c:124:32: warning: variable ‘inversion’ set but not used [-Wunused-but-set-variable]
> > > dvbscan_dvb.c:27:44: warning: unused parameter ‘fe’ [-Wunused-parameter]
> > > dvbscan_atsc.c:27:45: warning: unused parameter ‘fe’ [-Wunused-parameter]
> > > util.c:193:7: error: ‘SYS_DVBC_ANNEX_A’ undeclared (first use in this function)
> > > util.c:194:7: error: ‘SYS_DVBC_ANNEX_C’ undeclared (first use in this function)
> > > util.c:262:26: error: ‘DTV_ENUM_DELSYS’ undeclared (first use in this function)
> > > util.c:263:1: warning: control reaches end of non-void function [-Wreturn-type]
> > > make[2]: *** [util.o] Error 1
> > > make[1]: *** [all] Error 2
> > > make: *** [all] Error 2
> > 
> > I'm not touching on dvb-apps for a long time. From my side, all I need in
> > terms of userspace apps for DVB is there at dvbv5/libdvbv5 on v4l-utils.
> > 
> > That's said, from the above errors, it seems that it got added (partial)
> > support for DVB v5 but, somehow, it is compiling with an older
> > dvb/frontend.h header on your build.
> > 
> > Regards,
> > Mauro
> > 
> 
> I've running a 3.8 kernel on my daily build server, so that's why those
> headers are old. I've manually updated the headers.
> 
> Note that dvb-apps has an include directory with old headers as well, but
> those headers aren't used anyway it seems.

Yes, it has old headers on it, but I've no idea if it uses them or not.

> Should I bother with building dvb-apps at all?

It's your call. As I said, from my side, I don't bother about it anymore.

Regards,
Mauro