From mboxrd@z Thu Jan 1 00:00:00 1970 Return-path: Received: from aserp1040.oracle.com ([141.146.126.69]:45629 "EHLO aserp1040.oracle.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755963Ab3EaMY5 (ORCPT ); Fri, 31 May 2013 08:24:57 -0400 Date: Fri, 31 May 2013 15:24:45 +0300 From: Dan Carpenter To: Mauro Carvalho Chehab Cc: linux-media@vger.kernel.org, kernel-janitors@vger.kernel.org Subject: Re: [patch] [media] media: info leak in __media_device_enum_links() Message-ID: <20130531122444.GS23987@mwanda> References: <20130413093215.GB11215@elgon.mountain> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20130413093215.GB11215@elgon.mountain> Sender: linux-media-owner@vger.kernel.org List-ID: Ping? regards, dan carpenter On Sat, Apr 13, 2013 at 12:32:15PM +0300, Dan Carpenter wrote: > These structs have holes and reserved struct members which aren't > cleared. I've added a memset() so we don't leak stack information. > > Signed-off-by: Dan Carpenter > > diff --git a/drivers/media/media-device.c b/drivers/media/media-device.c > index 99b80b6..450c0d1 100644 > --- a/drivers/media/media-device.c > +++ b/drivers/media/media-device.c > @@ -139,6 +139,8 @@ static long __media_device_enum_links(struct media_device *mdev, > > for (p = 0; p < entity->num_pads; p++) { > struct media_pad_desc pad; > + > + memset(&pad, 0, sizeof(pad)); > media_device_kpad_to_upad(&entity->pads[p], &pad); > if (copy_to_user(&links->pads[p], &pad, sizeof(pad))) > return -EFAULT; > @@ -156,6 +158,7 @@ static long __media_device_enum_links(struct media_device *mdev, > if (entity->links[l].source->entity != entity) > continue; > > + memset(&link, 0, sizeof(link)); > media_device_kpad_to_upad(entity->links[l].source, > &link.source); > media_device_kpad_to_upad(entity->links[l].sink,