From: Jonathan Corbet <corbet@lwn.net>
To: <lbyang@marvell.com>
Cc: <g.liakhovetski@gmx.de>, <mchehab@redhat.com>,
<linux-media@vger.kernel.org>, <albert.v.wang@gmail.com>
Subject: Re: [PATCH 2/7] marvell-ccic: add clock tree support for marvell-ccic driver
Date: Fri, 21 Jun 2013 11:02:24 -0600 [thread overview]
Message-ID: <20130621110224.6adf7492@lwn.net> (raw)
In-Reply-To: <1370324564.26072.22.camel@younglee-desktop>
On Tue, 4 Jun 2013 13:42:44 +0800
lbyang <lbyang@marvell.com> wrote:
> +static void mcam_clk_enable(struct mcam_camera *mcam)
> +{
> + unsigned int i;
> +
> + for (i = 0; i < NR_MCAM_CLK; i++) {
> + if (!IS_ERR_OR_NULL(mcam->clk[i]))
> + clk_prepare_enable(mcam->clk[i]);
> + }
> +}
It seems I already acked this patch, and I won't take that back. I
will point out, though, that IS_ERR_OR_NULL has become a sort of
lightning rod and that its use is probably best avoided.
http://lists.infradead.org/pipermail/linux-arm-kernel/2013-January/140543.html
This relates to the use of ERR_PTR with that particular pointer value;
I still think just using NULL is better, but maybe I'm missing
something.
jon
next prev parent reply other threads:[~2013-06-21 17:02 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-06-04 5:42 [PATCH 2/7] marvell-ccic: add clock tree support for marvell-ccic driver lbyang
2013-06-21 17:02 ` Jonathan Corbet [this message]
2013-06-25 7:33 ` Libin Yang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130621110224.6adf7492@lwn.net \
--to=corbet@lwn.net \
--cc=albert.v.wang@gmail.com \
--cc=g.liakhovetski@gmx.de \
--cc=lbyang@marvell.com \
--cc=linux-media@vger.kernel.org \
--cc=mchehab@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox