From mboxrd@z Thu Jan 1 00:00:00 1970 Return-path: Received: from userp1040.oracle.com ([156.151.31.81]:28937 "EHLO userp1040.oracle.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750729Ab3FZPKS (ORCPT ); Wed, 26 Jun 2013 11:10:18 -0400 Date: Wed, 26 Jun 2013 18:10:01 +0300 From: Dan Carpenter To: Andy Shevchenko Cc: Jarod Wilson , Mauro Carvalho Chehab , YAMANE Toshiaki , linux-media@vger.kernel.org Subject: Re: [PATCH v2] staging: lirc: clean error handling in probe() Message-ID: <20130626151001.GM5714@mwanda> References: <1372257456-19212-1-git-send-email-andriy.shevchenko@linux.intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1372257456-19212-1-git-send-email-andriy.shevchenko@linux.intel.com> Sender: linux-media-owner@vger.kernel.org List-ID: On Wed, Jun 26, 2013 at 05:37:36PM +0300, Andy Shevchenko wrote: > From: Dan Carpenter > > We have reorganized the error handling into a simpler and more canonical > format. > > Additionally we removed extra empty lines, switched to devm_kzalloc(), and > substitute 'minor' by 'ret' in the igorplugusb_remote_probe() function. > > Signed-off-by: Dan Carpenter > Signed-off-by: Andy Shevchenko I don't want credit for this, because I didn't do the work. Signed-off-by is a legal thing like signing a document... But I have reviewed it and it looks good. Acked-by: Dan Carpenter regards, dan carpenter