From: "André Roth" <neolynx@gmail.com>
To: Guy Martin <gmsoft@tuxicoman.be>
Cc: linux-media@vger.kernel.org
Subject: Re: [PATCH 3/6] libdvbv5: Export dvb_fe_is_satellite()
Date: Tue, 2 Jul 2013 20:29:45 +0200 [thread overview]
Message-ID: <20130702202945.4591f98d@myon.exnihilo> (raw)
In-Reply-To: <8745561db2ff7870ad9feb1ee0c7a32537dee18d.1371561676.git.gmsoft@tuxicoman.be>
Acked-by: André Roth <neolynx@gmail.com>
On Tue, 18 Jun 2013 16:19:06 +0200
Guy Martin <gmsoft@tuxicoman.be> wrote:
> This patch makes the function dvb_fe_is_satellite() availble from libdvbv5. This function is simple
> but yet very handful to have around.
>
> Signed-off-by: Guy Martin <gmsoft@tuxicoman.be>
> ---
> lib/include/dvb-fe.h | 1 +
> lib/libdvbv5/dvb-fe.c | 14 +++++++-------
> 2 files changed, 8 insertions(+), 7 deletions(-)
>
> diff --git a/lib/include/dvb-fe.h b/lib/include/dvb-fe.h
> index d725a42..7352218 100644
> --- a/lib/include/dvb-fe.h
> +++ b/lib/include/dvb-fe.h
> @@ -203,6 +203,7 @@ int dvb_fe_diseqc_cmd(struct dvb_v5_fe_parms *parms, const unsigned len,
> const unsigned char *buf);
> int dvb_fe_diseqc_reply(struct dvb_v5_fe_parms *parms, unsigned *len, char *buf,
> int timeout);
> +int dvb_fe_is_satellite(uint32_t delivery_system);
>
> #ifdef __cplusplus
> }
> diff --git a/lib/libdvbv5/dvb-fe.c b/lib/libdvbv5/dvb-fe.c
> index 550b6e2..b786a85 100644
> --- a/lib/libdvbv5/dvb-fe.c
> +++ b/lib/libdvbv5/dvb-fe.c
> @@ -230,7 +230,7 @@ struct dvb_v5_fe_parms *dvb_fe_open2(int adapter, int frontend, unsigned verbose
> }
>
>
> -static int is_satellite(uint32_t delivery_system)
> +int dvb_fe_is_satellite(uint32_t delivery_system)
> {
> switch (delivery_system) {
> case SYS_DVBS:
> @@ -254,7 +254,7 @@ void dvb_fe_close(struct dvb_v5_fe_parms *parms)
> return;
>
> /* Disable LNBf power */
> - if (is_satellite(parms->current_sys))
> + if (dvb_fe_is_satellite(parms->current_sys))
> dvb_fe_sec_voltage(parms, 0, 0);
>
> close(parms->fd);
> @@ -298,8 +298,8 @@ int dvb_set_sys(struct dvb_v5_fe_parms *parms,
>
> if (sys != parms->current_sys) {
> /* Disable LNBf power */
> - if (is_satellite(parms->current_sys) &&
> - !is_satellite(sys))
> + if (dvb_fe_is_satellite(parms->current_sys) &&
> + !dvb_fe_is_satellite(sys))
> dvb_fe_sec_voltage(parms, 0, 0);
>
> /* Can't change standard with the legacy FE support */
> @@ -594,7 +594,7 @@ int dvb_fe_get_parms(struct dvb_v5_fe_parms *parms)
>
> ret:
> /* For satellite, need to recover from LNBf IF frequency */
> - if (is_satellite(parms->current_sys))
> + if (dvb_fe_is_satellite(parms->current_sys))
> return dvb_sat_get_parms(parms);
>
> return 0;
> @@ -609,7 +609,7 @@ int dvb_fe_set_parms(struct dvb_v5_fe_parms *parms)
>
> struct dtv_property fe_prop[DTV_MAX_COMMAND];
>
> - if (is_satellite(parms->current_sys)) {
> + if (dvb_fe_is_satellite(parms->current_sys)) {
> dvb_fe_retrieve_parm(parms, DTV_FREQUENCY, &freq);
> dvb_sat_set_parms(parms);
> }
> @@ -673,7 +673,7 @@ int dvb_fe_set_parms(struct dvb_v5_fe_parms *parms)
> }
> ret:
> /* For satellite, need to recover from LNBf IF frequency */
> - if (is_satellite(parms->current_sys))
> + if (dvb_fe_is_satellite(parms->current_sys))
> dvb_fe_store_parm(parms, DTV_FREQUENCY, freq);
>
> return 0;
next prev parent reply other threads:[~2013-07-02 18:29 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-06-18 14:19 [PATCH v2 0/6] v4l-utils: v4l-utils: Fix satellite support in dvbv5-{scan,zap} tools Guy Martin
2013-06-18 14:19 ` [PATCH v2 1/6] libdvbv5: Remove buggy parsing of extra DTV_foo parameters Guy Martin
2013-07-02 18:28 ` André Roth
2013-06-18 14:19 ` [PATCH 2/6] libdvbv5: Add parsing of POLARIZATION Guy Martin
2013-07-02 18:29 ` André Roth
2013-06-18 14:19 ` [PATCH 3/6] libdvbv5: Export dvb_fe_is_satellite() Guy Martin
2013-07-02 18:29 ` André Roth [this message]
2013-06-18 14:19 ` [PATCH 4/6] libdvbv5: Fix satellite handling and apply polarization parameter to the frontend Guy Martin
2013-07-02 18:30 ` André Roth
2013-06-18 14:19 ` [PATCH 5/6] libdvbv5: Use a temporary copy of the dvb parameters when tuning Guy Martin
2013-07-02 18:31 ` André Roth
2013-06-18 14:19 ` [PATCH 6/6] dvbv5-zap: Parse the LNB from the channel file Guy Martin
2013-07-02 18:31 ` André Roth
2013-07-02 18:04 ` [PATCH v2 0/6] v4l-utils: v4l-utils: Fix satellite support in dvbv5-{scan,zap} tools André Roth
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130702202945.4591f98d@myon.exnihilo \
--to=neolynx@gmail.com \
--cc=gmsoft@tuxicoman.be \
--cc=linux-media@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox