From: Ezequiel Garcia <ezequiel.garcia@free-electrons.com>
To: Hans Verkuil <hverkuil@xs4all.nl>
Cc: Sergey 'Jin' Bostandzhyan <jin@mediatomb.cc>,
linux-media@vger.kernel.org
Subject: Re: Possible problem with stk1160 driver
Date: Thu, 18 Jul 2013 09:55:59 -0300 [thread overview]
Message-ID: <20130718125557.GB2307@localhost> (raw)
In-Reply-To: <51E78BB1.4020108@xs4all.nl>
Hi Hans,
Thanks for jumping in.
On Thu, Jul 18, 2013 at 08:31:13AM +0200, Hans Verkuil wrote:
> On 07/18/2013 02:17 AM, Ezequiel Garcia wrote:
> >
> > Ah... forgot to mention about that. I haven't included the fix for standard
> > setting, because either the stk1160 chip or the userspace application didn't
> > seem to behave properly: I got wrongly coloured frames when trying to
> > change the standard while streaming.
>
> You generally can't switch standards while streaming. That said, it is OK
> to accept the same standard, i.e. return 0 if the standard is unchanged and
> EBUSY otherwise.
>
Ok, I'll add a check for unchanged standards to overcome this situation.
> In the end it is an application bug, though. It shouldn't try to change the
> standard while streaming has started.
>
Ok, so that confirms we should not allow it.
Sergey: Hopefully, with these two patches you won't need any further
patching on your side.
--
Ezequiel García, Free Electrons
Embedded Linux, Kernel and Android Engineering
http://free-electrons.com
next prev parent reply other threads:[~2013-07-18 12:56 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-07-16 22:04 Possible problem with stk1160 driver Sergey 'Jin' Bostandzhyan
2013-07-16 22:45 ` Ezequiel Garcia
2013-07-17 8:44 ` Ezequiel Garcia
2013-07-17 21:31 ` Sergey 'Jin' Bostandzhyan
2013-07-18 0:17 ` Ezequiel Garcia
2013-07-18 0:44 ` Sergey 'Jin' Bostandzhyan
2013-07-18 6:31 ` Hans Verkuil
2013-07-18 12:55 ` Ezequiel Garcia [this message]
2013-07-18 22:19 ` Sergey 'Jin' Bostandzhyan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130718125557.GB2307@localhost \
--to=ezequiel.garcia@free-electrons.com \
--cc=hverkuil@xs4all.nl \
--cc=jin@mediatomb.cc \
--cc=linux-media@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).