From: Jonathan Corbet <corbet@lwn.net>
To: Julia Lawall <julia.lawall@lip6.fr>
Cc: Dan Carpenter <dan.carpenter@oracle.com>,
trivial@kernel.org, kernel-janitors@vger.kernel.org,
m.chehab@samsung.com, linux-media@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] trivial: adjust code alignment
Date: Mon, 5 Aug 2013 10:52:14 -0600 [thread overview]
Message-ID: <20130805105214.14b77ced@lwn.net> (raw)
In-Reply-To: <alpine.DEB.2.02.1308051810360.2134@hadrien>
On Mon, 5 Aug 2013 18:19:18 +0200 (CEST)
Julia Lawall <julia.lawall@lip6.fr> wrote:
> Oops, thanks for spotting that. I'm not sure whether it is safe to abort
> these calls as soon as the first one fails, but perhaps I could introduce
> some more variables, and test them all afterwards.
Yes, it would be safe. But it's hard to imagine a scenario where any of
those particular calls would fail that doesn't involve smoke.
The code is evidence of ancient laziness on my part. I'll add fixing it
up to my list of things to do.
Thanks,
jon
prev parent reply other threads:[~2013-08-05 16:52 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <1375714059-29567-1-git-send-email-Julia.Lawall@lip6.fr>
[not found] ` <1375714059-29567-5-git-send-email-Julia.Lawall@lip6.fr>
[not found] ` <20130805160645.GI5051@mwanda>
2013-08-05 16:19 ` [PATCH] trivial: adjust code alignment Julia Lawall
2013-08-05 16:24 ` walter harms
2013-08-05 16:28 ` Julia Lawall
2013-08-05 17:05 ` Dan Carpenter
2013-08-05 16:52 ` Jonathan Corbet [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130805105214.14b77ced@lwn.net \
--to=corbet@lwn.net \
--cc=dan.carpenter@oracle.com \
--cc=julia.lawall@lip6.fr \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=m.chehab@samsung.com \
--cc=trivial@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).