From: Mauro Carvalho Chehab <m.chehab@samsung.com>
To: "Alfredo Jesús Delaiti" <alfredodelaiti@netscape.net>
Cc: Linux Media Mailing List <linux-media@vger.kernel.org>,
Mauro Carvalho Chehab <mchehab@infradead.org>
Subject: Re: [PATCH RFC 0/3] Experimental patches for ISDB-T on Mygica X8502/X8507
Date: Fri, 09 Aug 2013 10:24:10 -0300 [thread overview]
Message-ID: <20130809102410.73d896de@samsung.com> (raw)
In-Reply-To: <5204311E.6070602@netscape.net>
Em Thu, 08 Aug 2013 21:00:30 -0300
Alfredo Jesús Delaiti <alfredodelaiti@netscape.net> escreveu:
> Hi
>
>
> El 08/08/13 13:51, Mauro Carvalho Chehab escribió:
> > This is a first set of experimental patches for Mygica X8502/X8507.
> >
> > The last patch is just a very dirty hack, for testing purposes. I intend
> > to get rid of it, but it is there to replace exactly the same changes that
> > Alfredo reported to work on Kernel 3.2.
> >
> > I intend to remove it on a final series, eventually replacing by some
> > other changes at mb86a20s.
> >
> > Alfredo,
> >
> > Please test, and send your tested-by, if this works for you.
>
> tested-by: Alfredo Delaiti <alfredodelaiti@netscape.net>
>
>
>
> two comments:
>
> two "breaks":
>
> @@ -1106,6 +1112,8 @@ static int dvb_register(struct cx23885_tsport *port)
> &i2c_bus2->i2c_adap,
> &mygica_x8506_xc5000_config);
> }
> + cx23885_set_frontend_hook(port, fe0->dvb.frontend);
> + break;
> break;
>
>
> and I would add this on cx23885-cards.c (is not a patch):
>
> case CX23885_BOARD_MYGICA_X8506:
> case CX23885_BOARD_MAGICPRO_PROHDTVE2:
> case CX23885_BOARD_MYGICA_X8507:
> /* GPIO-0 (0)Analog / (1)Digital TV */
> /* GPIO-1 reset XC5000 */
> - /* GPIO-2 reset LGS8GL5 / LGS8G75 */
> + /* GPIO-2 reset LGS8GL5 / LGS8G75 / MB86A20S */
> cx23885_gpio_enable(dev, GPIO_0 | GPIO_1 | GPIO_2, 1);
> cx23885_gpio_clear(dev, GPIO_1 | GPIO_2);
> mdelay(100);
> cx23885_gpio_set(dev, GPIO_0 | GPIO_1 | GPIO_2);
> mdelay(100);
> break;
>
>
> Thanks again Mauro,
Thank you for your tests. I just pushed a new patch series addressing the
above, and getting rid of the horrible mb86a20s hack.
Please test it again, to see if the mb86a20s fixes also worked for you.
Thanks!
Mauro
next prev parent reply other threads:[~2013-08-09 13:24 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-08-08 16:51 [PATCH RFC 0/3] Experimental patches for ISDB-T on Mygica X8502/X8507 Mauro Carvalho Chehab
2013-08-08 16:51 ` [PATCH RFC 1/3] cx23885-dvb: use a better approach to hook set_frontend Mauro Carvalho Chehab
2013-08-08 16:51 ` [PATCH RFC 2/3] cx23885: Add DTV support for Mygica X8502/X8507 boards Mauro Carvalho Chehab
2013-08-08 16:51 ` [PATCH RFC 3/3] mb86a20s: hack it to emulate what x8502 driver does Mauro Carvalho Chehab
2013-08-09 0:00 ` [PATCH RFC 0/3] Experimental patches for ISDB-T on Mygica X8502/X8507 Alfredo Jesús Delaiti
2013-08-09 13:24 ` Mauro Carvalho Chehab [this message]
2013-08-10 13:22 ` Alfredo Jesús Delaiti
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130809102410.73d896de@samsung.com \
--to=m.chehab@samsung.com \
--cc=alfredodelaiti@netscape.net \
--cc=linux-media@vger.kernel.org \
--cc=mchehab@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox