* [PATCH RFC 0/3] Experimental patches for ISDB-T on Mygica X8502/X8507
@ 2013-08-08 16:51 Mauro Carvalho Chehab
2013-08-08 16:51 ` [PATCH RFC 1/3] cx23885-dvb: use a better approach to hook set_frontend Mauro Carvalho Chehab
` (3 more replies)
0 siblings, 4 replies; 7+ messages in thread
From: Mauro Carvalho Chehab @ 2013-08-08 16:51 UTC (permalink / raw)
To: Alfredo Jesús Delaiti
Cc: Mauro Carvalho Chehab, Linux Media Mailing List,
Mauro Carvalho Chehab
This is a first set of experimental patches for Mygica X8502/X8507.
The last patch is just a very dirty hack, for testing purposes. I intend
to get rid of it, but it is there to replace exactly the same changes that
Alfredo reported to work on Kernel 3.2.
I intend to remove it on a final series, eventually replacing by some
other changes at mb86a20s.
Alfredo,
Please test, and send your tested-by, if this works for you.
Thanks!
Mauro
Mauro Carvalho Chehab (3):
cx23885-dvb: use a better approach to hook set_frontend
cx23885: Add DTV support for Mygica X8502/X8507 boards
mb86a20s: hack it to emulate what x8502 driver does
drivers/media/dvb-frontends/mb86a20s.c | 100 ++++++++++++++++++++++++++++++
drivers/media/pci/cx23885/Kconfig | 1 +
drivers/media/pci/cx23885/cx23885-cards.c | 4 +-
drivers/media/pci/cx23885/cx23885-dvb.c | 49 ++++++++++++---
drivers/media/pci/cx23885/cx23885.h | 2 +
5 files changed, 147 insertions(+), 9 deletions(-)
--
1.8.3.1
^ permalink raw reply [flat|nested] 7+ messages in thread* [PATCH RFC 1/3] cx23885-dvb: use a better approach to hook set_frontend 2013-08-08 16:51 [PATCH RFC 0/3] Experimental patches for ISDB-T on Mygica X8502/X8507 Mauro Carvalho Chehab @ 2013-08-08 16:51 ` Mauro Carvalho Chehab 2013-08-08 16:51 ` [PATCH RFC 2/3] cx23885: Add DTV support for Mygica X8502/X8507 boards Mauro Carvalho Chehab ` (2 subsequent siblings) 3 siblings, 0 replies; 7+ messages in thread From: Mauro Carvalho Chehab @ 2013-08-08 16:51 UTC (permalink / raw) To: Alfredo Jesús Delaiti Cc: Mauro Carvalho Chehab, Linux Media Mailing List, Mauro Carvalho Chehab When the frontend drivers got converted to DVBv5 API, the original hook that tracked when a frontend is set got removed, being replaced by an approach that would use the gate control. That doesn't work fine with some boards. Also, the code were called more times than desired. Replace it by a logic that will hook the dvb set_frontend ops, with works with both DVBv3 and DVBv5 calls. Tested on a Mygica X8502 OEM board. Signed-off-by: Mauro Carvalho Chehab <m.chehab@samsung.com> --- drivers/media/pci/cx23885/cx23885-dvb.c | 25 +++++++++++++++++-------- drivers/media/pci/cx23885/cx23885.h | 2 ++ 2 files changed, 19 insertions(+), 8 deletions(-) diff --git a/drivers/media/pci/cx23885/cx23885-dvb.c b/drivers/media/pci/cx23885/cx23885-dvb.c index bb291c6..c0613fb 100644 --- a/drivers/media/pci/cx23885/cx23885-dvb.c +++ b/drivers/media/pci/cx23885/cx23885-dvb.c @@ -119,8 +119,6 @@ static void dvb_buf_release(struct videobuf_queue *q, cx23885_free_buffer(q, (struct cx23885_buffer *)vb); } -static int cx23885_dvb_set_frontend(struct dvb_frontend *fe); - static void cx23885_dvb_gate_ctrl(struct cx23885_tsport *port, int open) { struct videobuf_dvb_frontends *f; @@ -135,12 +133,6 @@ static void cx23885_dvb_gate_ctrl(struct cx23885_tsport *port, int open) if (fe && fe->dvb.frontend && fe->dvb.frontend->ops.i2c_gate_ctrl) fe->dvb.frontend->ops.i2c_gate_ctrl(fe->dvb.frontend, open); - - /* - * FIXME: Improve this path to avoid calling the - * cx23885_dvb_set_frontend() every time it passes here. - */ - cx23885_dvb_set_frontend(fe->dvb.frontend); } static struct videobuf_queue_ops dvb_qops = { @@ -561,9 +553,21 @@ static int cx23885_dvb_set_frontend(struct dvb_frontend *fe) cx23885_gpio_set(dev, GPIO_0); break; } + + /* Call the real set_frontend */ + if (port->set_frontend) + return port->set_frontend(fe); + return 0; } +static void cx23885_set_frontend_hook(struct cx23885_tsport *port, + struct dvb_frontend *fe) +{ + port->set_frontend = fe->ops.set_frontend; + fe->ops.set_frontend = cx23885_dvb_set_frontend; +} + static struct lgs8gxx_config magicpro_prohdtve2_lgs8g75_config = { .prod = LGS8GXX_PROD_LGS8G75, .demod_address = 0x19, @@ -771,6 +775,8 @@ static int dvb_register(struct cx23885_tsport *port) 0x60, &dev->i2c_bus[1].i2c_adap, &hauppauge_hvr127x_config); } + if (dev->board == CX23885_BOARD_HAUPPAUGE_HVR1275) + cx23885_set_frontend_hook(port, fe0->dvb.frontend); break; case CX23885_BOARD_HAUPPAUGE_HVR1255: case CX23885_BOARD_HAUPPAUGE_HVR1255_22111: @@ -1106,6 +1112,8 @@ static int dvb_register(struct cx23885_tsport *port) &i2c_bus2->i2c_adap, &mygica_x8506_xc5000_config); } + cx23885_set_frontend_hook(port, fe0->dvb.frontend); + break; break; case CX23885_BOARD_MAGICPRO_PROHDTVE2: i2c_bus = &dev->i2c_bus[0]; @@ -1119,6 +1127,7 @@ static int dvb_register(struct cx23885_tsport *port) &i2c_bus2->i2c_adap, &magicpro_prohdtve2_xc5000_config); } + cx23885_set_frontend_hook(port, fe0->dvb.frontend); break; case CX23885_BOARD_HAUPPAUGE_HVR1850: i2c_bus = &dev->i2c_bus[0]; diff --git a/drivers/media/pci/cx23885/cx23885.h b/drivers/media/pci/cx23885/cx23885.h index 5687d3f..038caf5 100644 --- a/drivers/media/pci/cx23885/cx23885.h +++ b/drivers/media/pci/cx23885/cx23885.h @@ -320,6 +320,8 @@ struct cx23885_tsport { /* Workaround for a temp dvb_frontend that the tuner can attached to */ struct dvb_frontend analog_fe; + + int (*set_frontend)(struct dvb_frontend *fe); }; struct cx23885_kernel_ir { -- 1.8.3.1 ^ permalink raw reply related [flat|nested] 7+ messages in thread
* [PATCH RFC 2/3] cx23885: Add DTV support for Mygica X8502/X8507 boards 2013-08-08 16:51 [PATCH RFC 0/3] Experimental patches for ISDB-T on Mygica X8502/X8507 Mauro Carvalho Chehab 2013-08-08 16:51 ` [PATCH RFC 1/3] cx23885-dvb: use a better approach to hook set_frontend Mauro Carvalho Chehab @ 2013-08-08 16:51 ` Mauro Carvalho Chehab 2013-08-08 16:51 ` [PATCH RFC 3/3] mb86a20s: hack it to emulate what x8502 driver does Mauro Carvalho Chehab 2013-08-09 0:00 ` [PATCH RFC 0/3] Experimental patches for ISDB-T on Mygica X8502/X8507 Alfredo Jesús Delaiti 3 siblings, 0 replies; 7+ messages in thread From: Mauro Carvalho Chehab @ 2013-08-08 16:51 UTC (permalink / raw) To: Alfredo Jesús Delaiti Cc: Mauro Carvalho Chehab, Linux Media Mailing List, Mauro Carvalho Chehab Those boards were missing the ISDB-T support. Most of the work on this patch were done by Alfredo. My work here were to port this patch from Kernel 3.2 to upstream, fix the issue caused by the set_frontend bad hook, and add the Kconfig bits. Tested on a X8502 board rebranded as: "Leadership - Placa PCI-e de Captura de Vídeo Híbrida" - product code 3800. Thanks-to: Alfredo Jesús Delaiti <alfredodelaiti@netscape.net> Signed-off-by: Mauro Carvalho Chehab <m.chehab@samsung.com> --- drivers/media/pci/cx23885/Kconfig | 1 + drivers/media/pci/cx23885/cx23885-cards.c | 4 +++- drivers/media/pci/cx23885/cx23885-dvb.c | 24 ++++++++++++++++++++++++ 3 files changed, 28 insertions(+), 1 deletion(-) diff --git a/drivers/media/pci/cx23885/Kconfig b/drivers/media/pci/cx23885/Kconfig index b3688aa..5104c80 100644 --- a/drivers/media/pci/cx23885/Kconfig +++ b/drivers/media/pci/cx23885/Kconfig @@ -29,6 +29,7 @@ config VIDEO_CX23885 select DVB_STV0367 if MEDIA_SUBDRV_AUTOSELECT select DVB_TDA10071 if MEDIA_SUBDRV_AUTOSELECT select DVB_A8293 if MEDIA_SUBDRV_AUTOSELECT + select DVB_MB86A20S if MEDIA_SUBDRV_AUTOSELECT select MEDIA_TUNER_MT2063 if MEDIA_SUBDRV_AUTOSELECT select MEDIA_TUNER_MT2131 if MEDIA_SUBDRV_AUTOSELECT select MEDIA_TUNER_XC2028 if MEDIA_SUBDRV_AUTOSELECT diff --git a/drivers/media/pci/cx23885/cx23885-cards.c b/drivers/media/pci/cx23885/cx23885-cards.c index 7e923f8..6f49f99 100644 --- a/drivers/media/pci/cx23885/cx23885-cards.c +++ b/drivers/media/pci/cx23885/cx23885-cards.c @@ -528,11 +528,12 @@ struct cx23885_board cx23885_boards[] = { } }, }, [CX23885_BOARD_MYGICA_X8507] = { - .name = "Mygica X8507", + .name = "Mygica X8502/X8507 ISDB-T", .tuner_type = TUNER_XC5000, .tuner_addr = 0x61, .tuner_bus = 1, .porta = CX23885_ANALOG_VIDEO, + .portb = CX23885_MPEG_DVB, .input = { { .type = CX23885_VMUX_TELEVISION, @@ -1677,6 +1678,7 @@ void cx23885_card_setup(struct cx23885_dev *dev) break; case CX23885_BOARD_MYGICA_X8506: case CX23885_BOARD_MAGICPRO_PROHDTVE2: + case CX23885_BOARD_MYGICA_X8507: ts1->gen_ctrl_val = 0x5; /* Parallel */ ts1->ts_clk_en_val = 0x1; /* Enable TS_CLK */ ts1->src_sel_val = CX23885_SRC_SEL_PARALLEL_MPEG_VIDEO; diff --git a/drivers/media/pci/cx23885/cx23885-dvb.c b/drivers/media/pci/cx23885/cx23885-dvb.c index c0613fb..971e4ff 100644 --- a/drivers/media/pci/cx23885/cx23885-dvb.c +++ b/drivers/media/pci/cx23885/cx23885-dvb.c @@ -69,6 +69,7 @@ #include "stb6100_cfg.h" #include "tda10071.h" #include "a8293.h" +#include "mb86a20s.h" static unsigned int debug; @@ -492,6 +493,15 @@ static struct xc5000_config mygica_x8506_xc5000_config = { .if_khz = 5380, }; +static struct mb86a20s_config mygica_x8507_mb86a20s_config = { + .demod_address = 0x10, +}; + +static struct xc5000_config mygica_x8507_xc5000_config = { + .i2c_address = 0x61, + .if_khz = 4000, +}; + static struct stv090x_config prof_8000_stv090x_config = { .device = STV0903, .demod_mode = STV090x_SINGLE, @@ -548,6 +558,7 @@ static int cx23885_dvb_set_frontend(struct dvb_frontend *fe) } break; case CX23885_BOARD_MYGICA_X8506: + case CX23885_BOARD_MYGICA_X8507: case CX23885_BOARD_MAGICPRO_PROHDTVE2: /* Select Digital TV */ cx23885_gpio_set(dev, GPIO_0); @@ -1114,6 +1125,19 @@ static int dvb_register(struct cx23885_tsport *port) } cx23885_set_frontend_hook(port, fe0->dvb.frontend); break; + case CX23885_BOARD_MYGICA_X8507: + i2c_bus = &dev->i2c_bus[0]; + i2c_bus2 = &dev->i2c_bus[1]; + fe0->dvb.frontend = dvb_attach(mb86a20s_attach, + &mygica_x8507_mb86a20s_config, + &i2c_bus->i2c_adap); + if (fe0->dvb.frontend != NULL) { + dvb_attach(xc5000_attach, + fe0->dvb.frontend, + &i2c_bus2->i2c_adap, + &mygica_x8507_xc5000_config); + } + cx23885_set_frontend_hook(port, fe0->dvb.frontend); break; case CX23885_BOARD_MAGICPRO_PROHDTVE2: i2c_bus = &dev->i2c_bus[0]; -- 1.8.3.1 ^ permalink raw reply related [flat|nested] 7+ messages in thread
* [PATCH RFC 3/3] mb86a20s: hack it to emulate what x8502 driver does 2013-08-08 16:51 [PATCH RFC 0/3] Experimental patches for ISDB-T on Mygica X8502/X8507 Mauro Carvalho Chehab 2013-08-08 16:51 ` [PATCH RFC 1/3] cx23885-dvb: use a better approach to hook set_frontend Mauro Carvalho Chehab 2013-08-08 16:51 ` [PATCH RFC 2/3] cx23885: Add DTV support for Mygica X8502/X8507 boards Mauro Carvalho Chehab @ 2013-08-08 16:51 ` Mauro Carvalho Chehab 2013-08-09 0:00 ` [PATCH RFC 0/3] Experimental patches for ISDB-T on Mygica X8502/X8507 Alfredo Jesús Delaiti 3 siblings, 0 replies; 7+ messages in thread From: Mauro Carvalho Chehab @ 2013-08-08 16:51 UTC (permalink / raw) To: Alfredo Jesús Delaiti Cc: Mauro Carvalho Chehab, Linux Media Mailing List, Mauro Carvalho Chehab This is just a dirty hack that replaces the init sequence to the one found on Mygica X8502, as reported by Alfredo. This patch should never be merged as-is upstream, as it likely breaks support for other devices. Signed-off-by: Mauro Carvalho Chehab <m.chehab@samsung.com> --- drivers/media/dvb-frontends/mb86a20s.c | 100 +++++++++++++++++++++++++++++++++ 1 file changed, 100 insertions(+) diff --git a/drivers/media/dvb-frontends/mb86a20s.c b/drivers/media/dvb-frontends/mb86a20s.c index 856374b..3cf547b 100644 --- a/drivers/media/dvb-frontends/mb86a20s.c +++ b/drivers/media/dvb-frontends/mb86a20s.c @@ -204,6 +204,106 @@ static struct regdata mb86a20s_init2[] = { { 0xec, 0x0f }, { 0xeb, 0x1f }, { 0x28, 0x6a }, { 0x29, 0x00 }, { 0x2a, 0x00 }, { 0x2b, 0x00 }, + + /* HACK: Init sequence as found on X8502 driver */ + + { 0x09, 0x3a }, + { 0x50, 0xd1 }, { 0x51, 0x22 }, + { 0x39, 0x00 }, + { 0x28, 0x2a }, { 0x29, 0x00 }, { 0x2a, 0xfd }, { 0x2b, 0xc8 }, + { 0x3c, 0x38 }, + { 0x28, 0x20 }, { 0x29, 0x3e }, { 0x2a, 0xde }, { 0x2b, 0x4d }, + { 0x28, 0x22 }, { 0x29, 0x00 }, { 0x2a, 0x1f }, { 0x2b, 0xf0 }, + { 0x04, 0x08 }, { 0x05, 0x03 }, + { 0x04, 0x0e }, { 0x05, 0x00 }, + { 0x04, 0x0f }, { 0x05, 0x32 }, + { 0x04, 0x0b }, { 0x05, 0x78 }, + { 0x04, 0x00 }, { 0x05, 0x00 }, + { 0x04, 0x01 }, { 0x05, 0x1e }, + { 0x04, 0x02 }, { 0x05, 0x07 }, + { 0x04, 0x03 }, { 0x05, 0xd0 }, + { 0x04, 0x09 }, { 0x05, 0x00 }, + { 0x04, 0x0a }, { 0x05, 0xff }, + { 0x04, 0x27 }, { 0x05, 0x00 }, + { 0x04, 0x28 }, { 0x05, 0x00 }, + { 0x04, 0x1e }, { 0x05, 0x00 }, + { 0x04, 0x29 }, { 0x05, 0x64 }, + { 0x04, 0x32 }, { 0x05, 0x64 }, + { 0x04, 0x14 }, { 0x05, 0x02 }, + { 0x04, 0x04 }, { 0x05, 0x00 }, + { 0x04, 0x05 }, { 0x05, 0x22 }, + { 0x04, 0x06 }, { 0x05, 0x0e }, + { 0x04, 0x07 }, { 0x05, 0xd8 }, + { 0x04, 0x12 }, { 0x05, 0x00 }, + { 0x04, 0x13 }, { 0x05, 0xff }, + { 0x50, 0xa7 }, { 0x51, 0x00 }, + { 0x50, 0xa8 }, { 0x51, 0xff }, + { 0x50, 0xa9 }, { 0x51, 0xff }, + { 0x50, 0xaa }, { 0x51, 0x00 }, + { 0x50, 0xab }, { 0x51, 0xff }, + { 0x50, 0xac }, { 0x51, 0xff }, + { 0x50, 0xad }, { 0x51, 0x00 }, + { 0x50, 0xae }, { 0x51, 0xff }, + { 0x50, 0xaf }, { 0x51, 0xff }, + { 0x50, 0xdc }, { 0x51, 0x3f }, + { 0x50, 0xdd }, { 0x51, 0xff }, + { 0x50, 0xde }, { 0x51, 0x3f }, + { 0x50, 0xdf }, { 0x51, 0xff }, + { 0x50, 0xe0 }, { 0x51, 0x3f }, + { 0x50, 0xe1 }, { 0x51, 0xff }, + { 0x50, 0xb0 }, { 0x51, 0x07 }, + { 0x50, 0xb2 }, { 0x51, 0x3f }, + { 0x50, 0xb3 }, { 0x51, 0xff }, + { 0x50, 0xb4 }, { 0x51, 0x3f }, + { 0x50, 0xb5 }, { 0x51, 0xff }, + { 0x50, 0xb6 }, { 0x51, 0x3f }, + { 0x50, 0xb7 }, { 0x51, 0xff }, + { 0x50, 0x51 }, { 0x51, 0x04 }, + { 0x50, 0x50 }, { 0x51, 0x02 }, + { 0x50, 0xd5 }, { 0x51, 0x00 }, + { 0x50, 0xd6 }, { 0x51, 0x1f }, + { 0x50, 0xd2 }, { 0x51, 0x03 }, + { 0x50, 0xd7 }, { 0x51, 0x3f }, + { 0x28, 0x74 }, { 0x29, 0x00 }, { 0x2a, 0x00 }, { 0x2b, 0xff }, + { 0x28, 0x46 }, { 0x29, 0x00 }, { 0x2a, 0x1a }, { 0x2b, 0x0c }, + { 0x04, 0x40 }, + { 0x05, 0x00 }, + { 0x28, 0x00 }, { 0x2b, 0x08 }, + { 0x28, 0x05 }, { 0x2b, 0x00 }, + { 0x28, 0x06 }, { 0x29, 0x00 }, { 0x2a, 0x00 }, { 0x2b, 0x1f }, + { 0x28, 0x07 }, { 0x29, 0x00 }, { 0x2a, 0x00 }, { 0x2b, 0x18 }, + { 0x28, 0x08 }, { 0x29, 0x00 }, { 0x2a, 0x00 }, { 0x2b, 0x18 }, + { 0x28, 0x09 }, { 0x29, 0x00 }, { 0x2a, 0x00 }, { 0x2b, 0x30 }, + { 0x28, 0x0a }, { 0x29, 0x00 }, { 0x2a, 0x00 }, { 0x2b, 0x37 }, + { 0x28, 0x0b }, { 0x29, 0x00 }, { 0x2a, 0x00 }, { 0x2b, 0x02 }, + { 0x28, 0x0c }, { 0x29, 0x00 }, { 0x2a, 0x00 }, { 0x2b, 0x09 }, + { 0x28, 0x0d }, { 0x29, 0x00 }, { 0x2a, 0x00 }, { 0x2b, 0x06 }, + { 0x28, 0x0e }, { 0x29, 0x00 }, { 0x2a, 0x00 }, { 0x2b, 0x7b }, + { 0x28, 0x0f }, { 0x29, 0x00 }, { 0x2a, 0x00 }, { 0x2b, 0x76 }, + { 0x28, 0x10 }, { 0x29, 0x00 }, { 0x2a, 0x00 }, { 0x2b, 0x7d }, + { 0x28, 0x11 }, { 0x29, 0x00 }, { 0x2a, 0x00 }, { 0x2b, 0x08 }, + { 0x28, 0x12 }, { 0x29, 0x00 }, { 0x2a, 0x00 }, { 0x2b, 0x0b }, + { 0x28, 0x13 }, { 0x29, 0x00 }, { 0x2a, 0x00 }, { 0x2b, 0x00 }, + { 0x28, 0x14 }, { 0x29, 0x00 }, { 0x2a, 0x01 }, { 0x2b, 0xf2 }, + { 0x28, 0x15 }, { 0x29, 0x00 }, { 0x2a, 0x01 }, { 0x2b, 0xf3 }, + { 0x28, 0x16 }, { 0x29, 0x00 }, { 0x2a, 0x00 }, { 0x2b, 0x05 }, + { 0x28, 0x17 }, { 0x29, 0x00 }, { 0x2a, 0x00 }, { 0x2b, 0x16 }, + { 0x28, 0x18 }, { 0x29, 0x00 }, { 0x2a, 0x00 }, { 0x2b, 0x0f }, + { 0x28, 0x19 }, { 0x29, 0x00 }, { 0x2a, 0x07 }, { 0x2b, 0xef }, + { 0x28, 0x1a }, { 0x29, 0x00 }, { 0x2a, 0x07 }, { 0x2b, 0xd8 }, + { 0x28, 0x1b }, { 0x29, 0x00 }, { 0x2a, 0x07 }, { 0x2b, 0xf1 }, + { 0x28, 0x1c }, { 0x29, 0x00 }, { 0x2a, 0x00 }, { 0x2b, 0x3d }, + { 0x28, 0x1d }, { 0x29, 0x00 }, { 0x2a, 0x00 }, { 0x2b, 0x94 }, + { 0x28, 0x1e }, { 0x29, 0x00 }, { 0x2a, 0x00 }, { 0x2b, 0xba }, + { 0x50, 0x1e }, { 0x51, 0x5d }, + { 0x50, 0x22 }, { 0x51, 0x00 }, + { 0x50, 0x23 }, { 0x51, 0xc8 }, + { 0x50, 0x24 }, { 0x51, 0x00 }, + { 0x50, 0x25 }, { 0x51, 0xf0 }, + { 0x50, 0x26 }, { 0x51, 0x00 }, + { 0x50, 0x27 }, { 0x51, 0xc3 }, + { 0x50, 0x39 }, { 0x51, 0x02 }, + { 0xd0, 0x00 }, }; -- 1.8.3.1 ^ permalink raw reply related [flat|nested] 7+ messages in thread
* Re: [PATCH RFC 0/3] Experimental patches for ISDB-T on Mygica X8502/X8507 2013-08-08 16:51 [PATCH RFC 0/3] Experimental patches for ISDB-T on Mygica X8502/X8507 Mauro Carvalho Chehab ` (2 preceding siblings ...) 2013-08-08 16:51 ` [PATCH RFC 3/3] mb86a20s: hack it to emulate what x8502 driver does Mauro Carvalho Chehab @ 2013-08-09 0:00 ` Alfredo Jesús Delaiti 2013-08-09 13:24 ` Mauro Carvalho Chehab 3 siblings, 1 reply; 7+ messages in thread From: Alfredo Jesús Delaiti @ 2013-08-09 0:00 UTC (permalink / raw) To: Mauro Carvalho Chehab; +Cc: Linux Media Mailing List, Mauro Carvalho Chehab Hi El 08/08/13 13:51, Mauro Carvalho Chehab escribió: > This is a first set of experimental patches for Mygica X8502/X8507. > > The last patch is just a very dirty hack, for testing purposes. I intend > to get rid of it, but it is there to replace exactly the same changes that > Alfredo reported to work on Kernel 3.2. > > I intend to remove it on a final series, eventually replacing by some > other changes at mb86a20s. > > Alfredo, > > Please test, and send your tested-by, if this works for you. tested-by: Alfredo Delaiti <alfredodelaiti@netscape.net> two comments: two "breaks": @@ -1106,6 +1112,8 @@ static int dvb_register(struct cx23885_tsport *port) &i2c_bus2->i2c_adap, &mygica_x8506_xc5000_config); } + cx23885_set_frontend_hook(port, fe0->dvb.frontend); + break; break; and I would add this on cx23885-cards.c (is not a patch): case CX23885_BOARD_MYGICA_X8506: case CX23885_BOARD_MAGICPRO_PROHDTVE2: case CX23885_BOARD_MYGICA_X8507: /* GPIO-0 (0)Analog / (1)Digital TV */ /* GPIO-1 reset XC5000 */ - /* GPIO-2 reset LGS8GL5 / LGS8G75 */ + /* GPIO-2 reset LGS8GL5 / LGS8G75 / MB86A20S */ cx23885_gpio_enable(dev, GPIO_0 | GPIO_1 | GPIO_2, 1); cx23885_gpio_clear(dev, GPIO_1 | GPIO_2); mdelay(100); cx23885_gpio_set(dev, GPIO_0 | GPIO_1 | GPIO_2); mdelay(100); break; Thanks again Mauro, Alfredo > > Thanks! > Mauro > > Mauro Carvalho Chehab (3): > cx23885-dvb: use a better approach to hook set_frontend > cx23885: Add DTV support for Mygica X8502/X8507 boards > mb86a20s: hack it to emulate what x8502 driver does > > drivers/media/dvb-frontends/mb86a20s.c | 100 ++++++++++++++++++++++++++++++ > drivers/media/pci/cx23885/Kconfig | 1 + > drivers/media/pci/cx23885/cx23885-cards.c | 4 +- > drivers/media/pci/cx23885/cx23885-dvb.c | 49 ++++++++++++--- > drivers/media/pci/cx23885/cx23885.h | 2 + > 5 files changed, 147 insertions(+), 9 deletions(-) > ^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH RFC 0/3] Experimental patches for ISDB-T on Mygica X8502/X8507 2013-08-09 0:00 ` [PATCH RFC 0/3] Experimental patches for ISDB-T on Mygica X8502/X8507 Alfredo Jesús Delaiti @ 2013-08-09 13:24 ` Mauro Carvalho Chehab 2013-08-10 13:22 ` Alfredo Jesús Delaiti 0 siblings, 1 reply; 7+ messages in thread From: Mauro Carvalho Chehab @ 2013-08-09 13:24 UTC (permalink / raw) To: Alfredo Jesús Delaiti Cc: Linux Media Mailing List, Mauro Carvalho Chehab Em Thu, 08 Aug 2013 21:00:30 -0300 Alfredo Jesús Delaiti <alfredodelaiti@netscape.net> escreveu: > Hi > > > El 08/08/13 13:51, Mauro Carvalho Chehab escribió: > > This is a first set of experimental patches for Mygica X8502/X8507. > > > > The last patch is just a very dirty hack, for testing purposes. I intend > > to get rid of it, but it is there to replace exactly the same changes that > > Alfredo reported to work on Kernel 3.2. > > > > I intend to remove it on a final series, eventually replacing by some > > other changes at mb86a20s. > > > > Alfredo, > > > > Please test, and send your tested-by, if this works for you. > > tested-by: Alfredo Delaiti <alfredodelaiti@netscape.net> > > > > two comments: > > two "breaks": > > @@ -1106,6 +1112,8 @@ static int dvb_register(struct cx23885_tsport *port) > &i2c_bus2->i2c_adap, > &mygica_x8506_xc5000_config); > } > + cx23885_set_frontend_hook(port, fe0->dvb.frontend); > + break; > break; > > > and I would add this on cx23885-cards.c (is not a patch): > > case CX23885_BOARD_MYGICA_X8506: > case CX23885_BOARD_MAGICPRO_PROHDTVE2: > case CX23885_BOARD_MYGICA_X8507: > /* GPIO-0 (0)Analog / (1)Digital TV */ > /* GPIO-1 reset XC5000 */ > - /* GPIO-2 reset LGS8GL5 / LGS8G75 */ > + /* GPIO-2 reset LGS8GL5 / LGS8G75 / MB86A20S */ > cx23885_gpio_enable(dev, GPIO_0 | GPIO_1 | GPIO_2, 1); > cx23885_gpio_clear(dev, GPIO_1 | GPIO_2); > mdelay(100); > cx23885_gpio_set(dev, GPIO_0 | GPIO_1 | GPIO_2); > mdelay(100); > break; > > > Thanks again Mauro, Thank you for your tests. I just pushed a new patch series addressing the above, and getting rid of the horrible mb86a20s hack. Please test it again, to see if the mb86a20s fixes also worked for you. Thanks! Mauro ^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH RFC 0/3] Experimental patches for ISDB-T on Mygica X8502/X8507 2013-08-09 13:24 ` Mauro Carvalho Chehab @ 2013-08-10 13:22 ` Alfredo Jesús Delaiti 0 siblings, 0 replies; 7+ messages in thread From: Alfredo Jesús Delaiti @ 2013-08-10 13:22 UTC (permalink / raw) To: Mauro Carvalho Chehab; +Cc: Linux Media Mailing List, Mauro Carvalho Chehab El 09/08/13 10:24, Mauro Carvalho Chehab escribió: > Em Thu, 08 Aug 2013 21:00:30 -0300 > Alfredo Jesús Delaiti <alfredodelaiti@netscape.net> escreveu: > >> Hi >> >> >> El 08/08/13 13:51, Mauro Carvalho Chehab escribió: >>> This is a first set of experimental patches for Mygica X8502/X8507. >>> >>> The last patch is just a very dirty hack, for testing purposes. I intend >>> to get rid of it, but it is there to replace exactly the same changes that >>> Alfredo reported to work on Kernel 3.2. >>> >>> I intend to remove it on a final series, eventually replacing by some >>> other changes at mb86a20s. >>> >>> Alfredo, >>> >>> Please test, and send your tested-by, if this works for you. >> tested-by: Alfredo Delaiti <alfredodelaiti@netscape.net> >> >> >> >> two comments: >> >> two "breaks": >> >> @@ -1106,6 +1112,8 @@ static int dvb_register(struct cx23885_tsport *port) >> &i2c_bus2->i2c_adap, >> &mygica_x8506_xc5000_config); >> } >> + cx23885_set_frontend_hook(port, fe0->dvb.frontend); >> + break; >> break; >> >> >> and I would add this on cx23885-cards.c (is not a patch): >> >> case CX23885_BOARD_MYGICA_X8506: >> case CX23885_BOARD_MAGICPRO_PROHDTVE2: >> case CX23885_BOARD_MYGICA_X8507: >> /* GPIO-0 (0)Analog / (1)Digital TV */ >> /* GPIO-1 reset XC5000 */ >> - /* GPIO-2 reset LGS8GL5 / LGS8G75 */ >> + /* GPIO-2 reset LGS8GL5 / LGS8G75 / MB86A20S */ >> cx23885_gpio_enable(dev, GPIO_0 | GPIO_1 | GPIO_2, 1); >> cx23885_gpio_clear(dev, GPIO_1 | GPIO_2); >> mdelay(100); >> cx23885_gpio_set(dev, GPIO_0 | GPIO_1 | GPIO_2); >> mdelay(100); >> break; >> >> >> Thanks again Mauro, > Thank you for your tests. I just pushed a new patch series addressing the > above, and getting rid of the horrible mb86a20s hack. > > Please test it again, to see if the mb86a20s fixes also worked for you. > > Thanks! > Mauro Thanks, it works, and now more faster, and I only tested with last driver that have on git://linuxtv.org/media_build.git I hope with happiness see those patch on new kernels. Again,Thannks Alfredo ^ permalink raw reply [flat|nested] 7+ messages in thread
end of thread, other threads:[~2013-08-10 13:22 UTC | newest] Thread overview: 7+ messages (download: mbox.gz follow: Atom feed -- links below jump to the message on this page -- 2013-08-08 16:51 [PATCH RFC 0/3] Experimental patches for ISDB-T on Mygica X8502/X8507 Mauro Carvalho Chehab 2013-08-08 16:51 ` [PATCH RFC 1/3] cx23885-dvb: use a better approach to hook set_frontend Mauro Carvalho Chehab 2013-08-08 16:51 ` [PATCH RFC 2/3] cx23885: Add DTV support for Mygica X8502/X8507 boards Mauro Carvalho Chehab 2013-08-08 16:51 ` [PATCH RFC 3/3] mb86a20s: hack it to emulate what x8502 driver does Mauro Carvalho Chehab 2013-08-09 0:00 ` [PATCH RFC 0/3] Experimental patches for ISDB-T on Mygica X8502/X8507 Alfredo Jesús Delaiti 2013-08-09 13:24 ` Mauro Carvalho Chehab 2013-08-10 13:22 ` Alfredo Jesús Delaiti
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox