From: "André Roth" <neolynx@gmail.com>
To: Mauro Carvalho Chehab <m.chehab@samsung.com>
Cc: Linux Media Mailing List <linux-media@vger.kernel.org>,
Mauro Carvalho Chehab <mchehab@infradead.org>
Subject: Re: [PATCH 1/3] [media] siano: Don't show debug messages as errors
Date: Fri, 13 Sep 2013 01:28:02 +0200 [thread overview]
Message-ID: <20130913012802.1a0eaef9@neutrino.exnihilo> (raw)
In-Reply-To: <1379016000-19577-2-git-send-email-m.chehab@samsung.com>
On Thu, 12 Sep 2013 16:59:58 -0300
Mauro Carvalho Chehab <m.chehab@samsung.com> wrote:
Tested-by: André Roth <neolynx@gmail.com>
> At this bugzilla and similar ones:
> https://bugzilla.kernel.org/show_bug.cgi?id=60645
>
> Those debug messages were seen as errors, but they're just debug
> data, and are OK to appear on sms1100 and sms2270. Re-tag them
> to appear only if debug is enabled.
>
> Signed-off-by: Mauro Carvalho Chehab <m.chehab@samsung.com>
> ---
> drivers/media/common/siano/smscoreapi.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/media/common/siano/smscoreapi.c b/drivers/media/common/siano/smscoreapi.c
> index a142f79..acf39ad 100644
> --- a/drivers/media/common/siano/smscoreapi.c
> +++ b/drivers/media/common/siano/smscoreapi.c
> @@ -982,7 +982,7 @@ static int smscore_load_firmware_family2(struct smscore_device_t *coredev,
> if (rc < 0)
> goto exit_fw_download;
>
> - sms_err("sending MSG_SMS_DATA_VALIDITY_REQ expecting 0x%x",
> + sms_debug("sending MSG_SMS_DATA_VALIDITY_REQ expecting 0x%x",
> calc_checksum);
> SMS_INIT_MSG(&msg->x_msg_header, MSG_SMS_DATA_VALIDITY_REQ,
> sizeof(msg->x_msg_header) +
> @@ -1562,7 +1562,7 @@ void smscore_onresponse(struct smscore_device_t *coredev,
> {
> struct sms_msg_data *validity = (struct sms_msg_data *) phdr;
>
> - sms_err("MSG_SMS_DATA_VALIDITY_RES, checksum = 0x%x",
> + sms_debug("MSG_SMS_DATA_VALIDITY_RES, checksum = 0x%x",
> validity->msg_data[0]);
> complete(&coredev->data_validity_done);
> break;
next prev parent reply other threads:[~2013-09-12 23:28 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-09-12 19:59 [PATCH 0/3] Some improvements/fixes for Siano driver Mauro Carvalho Chehab
2013-09-12 19:59 ` [PATCH 1/3] [media] siano: Don't show debug messages as errors Mauro Carvalho Chehab
2013-09-12 23:28 ` André Roth [this message]
2013-09-12 19:59 ` [PATCH 2/3] [media] siano: Improve debug/info messages Mauro Carvalho Chehab
2013-09-12 23:28 ` André Roth
2013-09-12 20:00 ` [PATCH 3/3] [media] siano: Fix initialization for Stellar models Mauro Carvalho Chehab
2013-09-12 23:29 ` André Roth
2013-09-12 23:32 ` André Roth
2013-09-12 20:04 ` [PATCH 4/3] [media] siano: Use the default firmware for Stellar Mauro Carvalho Chehab
2013-09-12 23:33 ` André Roth
2013-09-12 23:35 ` [PATCH 0/3] Some improvements/fixes for Siano driver André Roth
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130913012802.1a0eaef9@neutrino.exnihilo \
--to=neolynx@gmail.com \
--cc=linux-media@vger.kernel.org \
--cc=m.chehab@samsung.com \
--cc=mchehab@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).